From: David Woodhouse <dwmw2@infradead.org>
To: klightspeed@killerwolves.net
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Anton Vorontsov <anton@enomsg.org>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <pawel.moll@arm.com>,
devicetree@vger.kernel.org,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 4/5] ARM: Kirkwood: Fix qnap vendor prefix
Date: Wed, 19 Feb 2014 12:59:03 +0000 [thread overview]
Message-ID: <1392814743.9366.306.camel@i7.infradead.org> (raw)
In-Reply-To: <1392814154-11284-5-git-send-email-klightspeed@killerwolves.net>
[-- Attachment #1.1: Type: text/plain, Size: 747 bytes --]
On Wed, 2014-02-19 at 22:49 +1000, klightspeed@killerwolves.net wrote:
> Correct the vendor prefix for qnap, which should be the stock ticker
> symbol qnapsz.
No. This is an ABI change which appears to be gratuitous.
Perhaps it's really necessary, and perhaps it's harmless because it
won't *really* break compatibility with existing firmware because these
boxes have *always* shipped with a DTB built into the kernel or
something.
In which case all I'm complaining about is the fact that you didn't
properly address that in the commit comment and *explain* why it was
OK...
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2014-02-19 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 12:49 [PATCH v5 0/5] DT support for kirkwood based Synology NAS boxes klightspeed-aslSrjg9ejhWX4hkXwHRhw
[not found] ` <1392814154-11284-1-git-send-email-klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
2014-02-19 12:49 ` [PATCH v5 1/5] DT: Vendor prefixes: Add ricoh, qnap, sii and synology klightspeed-aslSrjg9ejhWX4hkXwHRhw
2014-02-19 12:49 ` [PATCH v5 2/5] Power: Reset: Generalize qnap-poweroff to work on Synology devices klightspeed-aslSrjg9ejhWX4hkXwHRhw
2014-02-19 12:49 ` [PATCH v5 3/5] DT: i2c: Trivial: Add sii, s35390a, fix ricoh vendor prefix klightspeed-aslSrjg9ejhWX4hkXwHRhw
2014-02-19 12:49 ` [PATCH v5 4/5] ARM: Kirkwood: Fix qnap " klightspeed-aslSrjg9ejhWX4hkXwHRhw
2014-02-19 12:59 ` David Woodhouse [this message]
[not found] ` <1392814154-11284-5-git-send-email-klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
2014-02-19 13:05 ` Andrew Lunn
[not found] ` <20140219130553.GO17984-g2DYL2Zd6BY@public.gmane.org>
2014-02-19 13:14 ` Ben Peddell
2014-02-19 17:10 ` Mark Rutland
2014-02-19 12:49 ` [PATCH v5 5/5] ARM: Kirkwood: Add support for many Synology NAS devices klightspeed-aslSrjg9ejhWX4hkXwHRhw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392814743.9366.306.camel@i7.infradead.org \
--to=dwmw2@infradead.org \
--cc=andrew@lunn.ch \
--cc=anton@enomsg.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=klightspeed@killerwolves.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).