From: Alex Elder <elder@linaro.org>
To: mturquette@linaro.org, bcm@fixthebug.org, mporter@linaro.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk
Cc: devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/12] clk: bcm281xx: warn if ccu_wait_bit() fails
Date: Wed, 19 Feb 2014 18:12:51 -0600 [thread overview]
Message-ID: <1392855182-21155-2-git-send-email-elder@linaro.org> (raw)
In-Reply-To: <1392855182-21155-1-git-send-email-elder@linaro.org>
Don't let a failure of ccu_wait_bit() go unnoticed.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/clk/bcm/clk-kona.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c
index e3d339e..c01d810 100644
--- a/drivers/clk/bcm/clk-kona.c
+++ b/drivers/clk/bcm/clk-kona.c
@@ -207,6 +207,9 @@ __ccu_wait_bit(struct ccu_data *ccu, u32 reg_offset, u32 bit, bool want)
return true;
udelay(1);
}
+ pr_warn("%s: %s/0x%04x bit %u was never %s\n", __func__,
+ ccu->name, reg_offset, bit, want ? "set" : "clear");
+
return false;
}
--
1.7.9.5
next prev parent reply other threads:[~2014-02-20 0:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 0:12 [PATCH 00/12] clk: bcm281xx: updates for 3.14 Alex Elder
2014-02-20 0:12 ` Alex Elder [this message]
2014-02-20 0:12 ` [PATCH 02/12] clk: bcm281xx: use init_data.name for clock name Alex Elder
2014-02-20 0:12 ` [PATCH 03/12] clk: bcm281xx: change some symbol names Alex Elder
2014-02-20 0:12 ` [PATCH 04/12] mach-bcm: bcm281xx: more symbol cleanup Alex Elder
2014-02-20 0:12 ` [PATCH 05/12] clk: bcm281xx: initialize CCU structures statically Alex Elder
2014-02-20 0:12 ` [PATCH 06/12] clk: bcm281xx: define CCU clock data statically Alex Elder
[not found] ` <1392855182-21155-1-git-send-email-elder-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-02-20 0:12 ` [PATCH 07/12] clk: bcm281xx: add clock policy support Alex Elder
2014-02-20 0:12 ` [PATCH 08/12] clk: bcm281xx: add clock hysteresis support Alex Elder
2014-02-20 0:12 ` [PATCH 09/12] clk: bcm281xx: add an initialized flag Alex Elder
2014-02-20 0:13 ` [PATCH 10/12] clk: bcm281xx: implement prerequisite clocks Alex Elder
2014-02-20 0:13 ` [PATCH 11/12] clk: bcm281xx: add bus clock support Alex Elder
2014-02-20 0:13 ` [PATCH 12/12] clk: bcm281xx: define a bus clock Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392855182-21155-2-git-send-email-elder@linaro.org \
--to=elder@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mporter@linaro.org \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).