From: Roger Quadros <rogerq@ti.com>
To: tony@atomide.com, bcousson@baylibre.com, lee.jones@linaro.org
Cc: nm@ti.com, devicetree@vger.kernel.org, khilman@linaro.org,
Samuel Ortiz <sameo@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
balbi@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>
Subject: [PATCH v8 01/14] mfd: omap-usb-host: Get clocks based on hardware revision
Date: Thu, 20 Feb 2014 13:39:56 +0200 [thread overview]
Message-ID: <1392896409-5101-2-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1392896409-5101-1-git-send-email-rogerq@ti.com>
Not all revisions have all the clocks so get the necessary clocks
based on hardware revision.
This should avoid un-necessary clk_get failure messages that were
observed earlier.
CC: Lee Jones <lee.jones@linaro.org>
CC: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/mfd/omap-usb-host.c | 43 ++++++++++++++++++++++++++++++++-----------
1 file changed, 32 insertions(+), 11 deletions(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 0c3c9a0..c63bfdf 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -665,22 +665,43 @@ static int usbhs_omap_probe(struct platform_device *pdev)
goto err_mem;
}
- need_logic_fck = false;
+ /* Set all clocks as invalid to begin with */
+ omap->ehci_logic_fck = ERR_PTR(-ENODEV);
+ omap->init_60m_fclk = ERR_PTR(-ENODEV);
+ omap->utmi_p1_gfclk = ERR_PTR(-ENODEV);
+ omap->utmi_p2_gfclk = ERR_PTR(-ENODEV);
+ omap->xclk60mhsp1_ck = ERR_PTR(-ENODEV);
+ omap->xclk60mhsp2_ck = ERR_PTR(-ENODEV);
+
for (i = 0; i < omap->nports; i++) {
- if (is_ehci_phy_mode(i) || is_ehci_tll_mode(i) ||
- is_ehci_hsic_mode(i))
- need_logic_fck |= true;
+ omap->utmi_clk[i] = ERR_PTR(-ENODEV);
+ omap->hsic480m_clk[i] = ERR_PTR(-ENODEV);
+ omap->hsic60m_clk[i] = ERR_PTR(-ENODEV);
}
- omap->ehci_logic_fck = ERR_PTR(-EINVAL);
- if (need_logic_fck) {
- omap->ehci_logic_fck = devm_clk_get(dev, "ehci_logic_fck");
- if (IS_ERR(omap->ehci_logic_fck)) {
- ret = PTR_ERR(omap->ehci_logic_fck);
- dev_dbg(dev, "ehci_logic_fck failed:%d\n", ret);
+ /* for OMAP3 i.e. USBHS REV1 */
+ if (omap->usbhs_rev == OMAP_USBHS_REV1) {
+ need_logic_fck = false;
+ for (i = 0; i < omap->nports; i++) {
+ if (is_ehci_phy_mode(pdata->port_mode[i]) ||
+ is_ehci_tll_mode(pdata->port_mode[i]) ||
+ is_ehci_hsic_mode(pdata->port_mode[i]))
+
+ need_logic_fck |= true;
+ }
+
+ if (need_logic_fck) {
+ omap->ehci_logic_fck = devm_clk_get(dev,
+ "ehci_logic_fck");
+ if (IS_ERR(omap->ehci_logic_fck)) {
+ ret = PTR_ERR(omap->ehci_logic_fck);
+ dev_dbg(dev, "ehci_logic_fck failed:%d\n", ret);
+ }
}
+ goto initialize;
}
+ /* for OMAP4+ i.e. USBHS REV2+ */
omap->utmi_p1_gfclk = devm_clk_get(dev, "utmi_p1_gfclk");
if (IS_ERR(omap->utmi_p1_gfclk)) {
ret = PTR_ERR(omap->utmi_p1_gfclk);
@@ -748,7 +769,6 @@ static int usbhs_omap_probe(struct platform_device *pdev)
}
if (is_ehci_phy_mode(pdata->port_mode[0])) {
- /* for OMAP3, clk_set_parent fails */
ret = clk_set_parent(omap->utmi_p1_gfclk,
omap->xclk60mhsp1_ck);
if (ret != 0)
@@ -776,6 +796,7 @@ static int usbhs_omap_probe(struct platform_device *pdev)
ret);
}
+initialize:
omap_usbhs_init(dev);
if (dev->of_node) {
--
1.8.3.2
next prev parent reply other threads:[~2014-02-20 11:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 11:39 [PATCH v8 00/14] USB Host support for OMAP5 uEVM Roger Quadros
2014-02-20 11:39 ` Roger Quadros [this message]
2014-02-25 9:37 ` [PATCH v8 01/14] mfd: omap-usb-host: Get clocks based on hardware revision Lee Jones
2014-02-25 9:40 ` Roger Quadros
2014-02-20 11:39 ` [PATCH v8 02/14] mfd: omap-usb-host: Always fail on clk_get() error Roger Quadros
[not found] ` <1392896409-5101-3-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-25 9:59 ` Lee Jones
2014-02-25 10:28 ` Lee Jones
2014-02-20 11:39 ` [PATCH v8 03/14] mfd: omap-usb-host: Use clock names as per function for reference clocks Roger Quadros
2014-02-25 8:52 ` Lee Jones
2014-02-25 9:02 ` Roger Quadros
2014-02-25 9:18 ` Lee Jones
2014-02-25 9:25 ` Roger Quadros
2014-02-20 11:39 ` [PATCH v8 04/14] mfd: omap-usb-host: Update DT clock binding information Roger Quadros
2014-02-20 11:40 ` [PATCH v8 05/14] mfd: omap-usb-tll: " Roger Quadros
2014-02-20 11:40 ` [PATCH v8 06/14] CLK: TI: OMAP3: Get rid of unused USB Host dummy clocks Roger Quadros
2014-02-25 8:43 ` Mike Turquette
2014-02-25 9:32 ` Roger Quadros
2014-02-26 20:56 ` Mike Turquette
2014-02-20 11:40 ` [PATCH v8 07/14] ARM: OMAP3: hwmod data: Remove optional clock from usb_host_hs module Roger Quadros
2014-02-20 11:40 ` [PATCH v8 08/14] ARM: dts: omap4: Update omap-usb-host node Roger Quadros
2014-02-20 11:40 ` [PATCH v8 09/14] ARM: dts: omap5: " Roger Quadros
2014-02-20 11:40 ` [PATCH v8 10/14] ARM: dts: omap4-panda: Provide USB PHY clock Roger Quadros
2014-02-20 11:40 ` [PATCH v8 11/14] ARM: dts: omap5-uevm: " Roger Quadros
2014-02-20 11:40 ` [PATCH v8 12/14] ARM: OMAP2+: Remove legacy_init_ehci_clk() Roger Quadros
[not found] ` <1392896409-5101-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-20 11:40 ` [PATCH v8 13/14] ARM: dts: OMAP2+: Get rid of incompatible ids for USB host nodes Roger Quadros
2014-02-20 11:40 ` [PATCH v8 14/14] usb: omap: dts: Update DT binding example usage Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392896409-5101-2-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).