From: Roger Quadros <rogerq@ti.com>
To: tony@atomide.com, bcousson@baylibre.com, lee.jones@linaro.org
Cc: nm@ti.com, devicetree@vger.kernel.org, khilman@linaro.org,
Samuel Ortiz <sameo@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
balbi@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>
Subject: [PATCH v8 02/14] mfd: omap-usb-host: Always fail on clk_get() error
Date: Thu, 20 Feb 2014 13:39:57 +0200 [thread overview]
Message-ID: <1392896409-5101-3-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1392896409-5101-1-git-send-email-rogerq@ti.com>
Be more strict and always fail on clk_get() error.
For OMAP3 platforms, get the 120MHz EHCI clock by its proper name
'usbhost_120m_fck' instead of its alias 'ehci_logic_fck'.
CC: Lee Jones <lee.jones@linaro.org>
CC: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/mfd/omap-usb-host.c | 65 +++++++++++++++++++++++++++++----------------
1 file changed, 42 insertions(+), 23 deletions(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index c63bfdf..865c276 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -692,10 +692,12 @@ static int usbhs_omap_probe(struct platform_device *pdev)
if (need_logic_fck) {
omap->ehci_logic_fck = devm_clk_get(dev,
- "ehci_logic_fck");
+ "usbhost_120m_fck");
if (IS_ERR(omap->ehci_logic_fck)) {
ret = PTR_ERR(omap->ehci_logic_fck);
- dev_dbg(dev, "ehci_logic_fck failed:%d\n", ret);
+ dev_err(dev, "usbhost_120m_fck failed:%d\n",
+ ret);
+ goto err_mem;
}
}
goto initialize;
@@ -749,51 +751,68 @@ static int usbhs_omap_probe(struct platform_device *pdev)
* them
*/
omap->utmi_clk[i] = devm_clk_get(dev, clkname);
- if (IS_ERR(omap->utmi_clk[i]))
- dev_dbg(dev, "Failed to get clock : %s : %ld\n",
- clkname, PTR_ERR(omap->utmi_clk[i]));
+ if (IS_ERR(omap->utmi_clk[i])) {
+ ret = PTR_ERR(omap->utmi_clk[i]);
+ dev_err(dev, "Failed to get clock : %s : %d\n",
+ clkname, ret);
+ goto err_mem;
+ }
snprintf(clkname, sizeof(clkname),
"usb_host_hs_hsic480m_p%d_clk", i + 1);
omap->hsic480m_clk[i] = devm_clk_get(dev, clkname);
- if (IS_ERR(omap->hsic480m_clk[i]))
- dev_dbg(dev, "Failed to get clock : %s : %ld\n",
- clkname, PTR_ERR(omap->hsic480m_clk[i]));
+ if (IS_ERR(omap->hsic480m_clk[i])) {
+ ret = PTR_ERR(omap->hsic480m_clk[i]);
+ dev_err(dev, "Failed to get clock : %s : %d\n",
+ clkname, ret);
+ goto err_mem;
+ }
snprintf(clkname, sizeof(clkname),
"usb_host_hs_hsic60m_p%d_clk", i + 1);
omap->hsic60m_clk[i] = devm_clk_get(dev, clkname);
- if (IS_ERR(omap->hsic60m_clk[i]))
- dev_dbg(dev, "Failed to get clock : %s : %ld\n",
- clkname, PTR_ERR(omap->hsic60m_clk[i]));
+ if (IS_ERR(omap->hsic60m_clk[i])) {
+ ret = PTR_ERR(omap->hsic60m_clk[i]);
+ dev_err(dev, "Failed to get clock : %s : %d\n",
+ clkname, ret);
+ goto err_mem;
+ }
}
if (is_ehci_phy_mode(pdata->port_mode[0])) {
ret = clk_set_parent(omap->utmi_p1_gfclk,
omap->xclk60mhsp1_ck);
- if (ret != 0)
- dev_dbg(dev, "xclk60mhsp1_ck set parent failed: %d\n",
- ret);
+ if (ret != 0) {
+ dev_err(dev, "xclk60mhsp1_ck set parent failed: %d\n",
+ ret);
+ goto err_mem;
+ }
} else if (is_ehci_tll_mode(pdata->port_mode[0])) {
ret = clk_set_parent(omap->utmi_p1_gfclk,
omap->init_60m_fclk);
- if (ret != 0)
- dev_dbg(dev, "P0 init_60m_fclk set parent failed: %d\n",
- ret);
+ if (ret != 0) {
+ dev_err(dev, "P0 init_60m_fclk set parent failed: %d\n",
+ ret);
+ goto err_mem;
+ }
}
if (is_ehci_phy_mode(pdata->port_mode[1])) {
ret = clk_set_parent(omap->utmi_p2_gfclk,
omap->xclk60mhsp2_ck);
- if (ret != 0)
- dev_dbg(dev, "xclk60mhsp2_ck set parent failed: %d\n",
- ret);
+ if (ret != 0) {
+ dev_err(dev, "xclk60mhsp2_ck set parent failed: %d\n",
+ ret);
+ goto err_mem;
+ }
} else if (is_ehci_tll_mode(pdata->port_mode[1])) {
ret = clk_set_parent(omap->utmi_p2_gfclk,
omap->init_60m_fclk);
- if (ret != 0)
- dev_dbg(dev, "P1 init_60m_fclk set parent failed: %d\n",
- ret);
+ if (ret != 0) {
+ dev_err(dev, "P1 init_60m_fclk set parent failed: %d\n",
+ ret);
+ goto err_mem;
+ }
}
initialize:
--
1.8.3.2
next prev parent reply other threads:[~2014-02-20 11:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 11:39 [PATCH v8 00/14] USB Host support for OMAP5 uEVM Roger Quadros
2014-02-20 11:39 ` [PATCH v8 01/14] mfd: omap-usb-host: Get clocks based on hardware revision Roger Quadros
2014-02-25 9:37 ` Lee Jones
2014-02-25 9:40 ` Roger Quadros
2014-02-20 11:39 ` Roger Quadros [this message]
[not found] ` <1392896409-5101-3-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-25 9:59 ` [PATCH v8 02/14] mfd: omap-usb-host: Always fail on clk_get() error Lee Jones
2014-02-25 10:28 ` Lee Jones
2014-02-20 11:39 ` [PATCH v8 03/14] mfd: omap-usb-host: Use clock names as per function for reference clocks Roger Quadros
2014-02-25 8:52 ` Lee Jones
2014-02-25 9:02 ` Roger Quadros
2014-02-25 9:18 ` Lee Jones
2014-02-25 9:25 ` Roger Quadros
2014-02-20 11:39 ` [PATCH v8 04/14] mfd: omap-usb-host: Update DT clock binding information Roger Quadros
2014-02-20 11:40 ` [PATCH v8 05/14] mfd: omap-usb-tll: " Roger Quadros
2014-02-20 11:40 ` [PATCH v8 06/14] CLK: TI: OMAP3: Get rid of unused USB Host dummy clocks Roger Quadros
2014-02-25 8:43 ` Mike Turquette
2014-02-25 9:32 ` Roger Quadros
2014-02-26 20:56 ` Mike Turquette
2014-02-20 11:40 ` [PATCH v8 07/14] ARM: OMAP3: hwmod data: Remove optional clock from usb_host_hs module Roger Quadros
2014-02-20 11:40 ` [PATCH v8 08/14] ARM: dts: omap4: Update omap-usb-host node Roger Quadros
2014-02-20 11:40 ` [PATCH v8 09/14] ARM: dts: omap5: " Roger Quadros
2014-02-20 11:40 ` [PATCH v8 10/14] ARM: dts: omap4-panda: Provide USB PHY clock Roger Quadros
2014-02-20 11:40 ` [PATCH v8 11/14] ARM: dts: omap5-uevm: " Roger Quadros
2014-02-20 11:40 ` [PATCH v8 12/14] ARM: OMAP2+: Remove legacy_init_ehci_clk() Roger Quadros
[not found] ` <1392896409-5101-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-20 11:40 ` [PATCH v8 13/14] ARM: dts: OMAP2+: Get rid of incompatible ids for USB host nodes Roger Quadros
2014-02-20 11:40 ` [PATCH v8 14/14] usb: omap: dts: Update DT binding example usage Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392896409-5101-3-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).