devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@freescale.com>
To: balbi@ti.com, shawn.guo@linaro.org, robh+dt@kernel.org,
	grant.likely@linaro.org, pawel.moll@arm.com,
	mark.rutland@arm.com
Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	festevam@gmail.com, marex@denx.de, kernel@pengutronix.de,
	m.grzeschik@pengutronix.de, frank.li@freescale.com,
	peter.chen@freescale.com, gregkh@linuxfoundation.org,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: [PATCH v11 12/15] usb: phy-mxs: Add sync time after controller clear phcd
Date: Mon, 24 Feb 2014 10:21:04 +0800	[thread overview]
Message-ID: <1393208467-6355-13-git-send-email-peter.chen@freescale.com> (raw)
In-Reply-To: <1393208467-6355-1-git-send-email-peter.chen@freescale.com>

After clear portsc.phcd, PHY needs 200us stable time for switch
32K clock to AHB clock.

Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
 drivers/usb/phy/phy-mxs-usb.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index 31ef59f..c42bdf0 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -151,6 +151,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy)
 	return mxs_phy->data == &imx6sl_phy_data;
 }
 
+/*
+ * PHY needs some 32K cycles to switch from 32K clock to
+ * bus (such as AHB/AXI, etc) clock.
+ */
+static void mxs_phy_clock_switch_delay(void)
+{
+	usleep_range(300, 400);
+}
+
 static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
 {
 	int ret;
@@ -261,6 +270,7 @@ static int mxs_phy_init(struct usb_phy *phy)
 	int ret;
 	struct mxs_phy *mxs_phy = to_mxs_phy(phy);
 
+	mxs_phy_clock_switch_delay();
 	ret = clk_prepare_enable(mxs_phy->clk);
 	if (ret)
 		return ret;
@@ -289,6 +299,7 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend)
 		       x->io_priv + HW_USBPHY_CTRL_SET);
 		clk_disable_unprepare(mxs_phy->clk);
 	} else {
+		mxs_phy_clock_switch_delay();
 		ret = clk_prepare_enable(mxs_phy->clk);
 		if (ret)
 			return ret;
-- 
1.7.8



  parent reply	other threads:[~2014-02-24  2:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24  2:20 [PATCH v11 00/15] Add power management support for mxs phy Peter Chen
2014-02-24  2:20 ` [PATCH v11 01/15] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2014-02-24  2:20 ` [PATCH v11 02/15] usb: phy-mxs: Add platform judgement code Peter Chen
2014-02-24  2:20 ` [PATCH v11 03/15] usb: phy-mxs: Add auto clock and power setting Peter Chen
2014-02-24  2:20 ` [PATCH v11 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2014-02-24  2:20 ` [PATCH v11 05/15] usb: phy-mxs: Add anatop regmap Peter Chen
2014-02-24  2:20 ` [PATCH v11 07/15] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2014-02-24  2:21 ` [PATCH v11 08/15] usb: phy-mxs: add controller id Peter Chen
2014-02-24  2:21 ` [PATCH v11 09/15] usb: phy: Add set_wakeup API Peter Chen
     [not found]   ` <1393208467-6355-10-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-24 18:41     ` Sergei Shtylyov
2014-02-25  2:03       ` Peter Chen
2014-02-24  2:21 ` [PATCH v11 10/15] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2014-02-24  2:21 ` Peter Chen [this message]
     [not found] ` <1393208467-6355-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-24  2:20   ` [PATCH v11 06/15] usb: phy-mxs: change description of usb device speed Peter Chen
2014-02-24  2:21   ` [PATCH v11 11/15] usb: phy-mxs: Add system suspend/resume API Peter Chen
2014-02-24  2:21   ` [PATCH v11 13/15] ARM: dts: mxs: add mxs phy controller id Peter Chen
2014-02-24  2:21   ` [PATCH v11 14/15] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2014-02-24  2:21   ` [PATCH v11 15/15] ARM: dts: imx6: add mxs phy controller id Peter Chen
2014-02-26  1:59 ` [PATCH v11 00/15] Add power management support for mxs phy Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393208467-6355-13-git-send-email-peter.chen@freescale.com \
    --to=peter.chen@freescale.com \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frank.li@freescale.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).