[PATCH v5 7/9] devicetree: bindings: Document PM8921/8058 keypads

[PATCH v5 7/9] devicetree: bindings: Document PM8921/8058 keypads

[Stephen Boyd]

Document the keypad device found on PM8921 and PM8058 PMICs.

Cc: <devicetree@vger.kernel.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 .../bindings/input/qcom,pm8xxx-keypad.txt          | 89 ++++++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt

diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt b/Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
new file mode 100644
index 000000000000..7d8cb92831d7
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
@@ -0,0 +1,89 @@
+Qualcomm PM8xxx PMIC Keypad
+
+PROPERTIES
+
+- compatible:
+	Usage: required
+	Value type: <string>
+	Definition: must be one of:
+		    "qcom,pm8058-keypad"
+		    "qcom,pm8921-keypad"
+
+- reg:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: address of keypad control register
+
+- interrupts:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: the first interrupt specifies the key sense interrupt
+		    and the second interrupt specifies the key stuck interrupt.
+		    The format of the specifier is defined by the binding
+		    document describing the node's interrupt parent.
+
+- linux,keymap:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: the linux keymap. More information can be found in
+		    input/matrix-keymap.txt.
+
+- linux,keypad-no-autorepeat:
+	Usage: optional
+	Value type: <bool>
+	Definition: don't enable autorepeat feature.
+
+- linux,keypad-wakeup:
+	Usage: optional
+	Value type: <bool>
+	Definition: use any event on keypad as wakeup event.
+
+- keypad,num-rows:
+	Usage: required
+	Value type: <u32>
+	Definition: number of rows in the keymap. More information can be found
+		    in input/matrix-keymap.txt.
+
+- keypad,num-columns:
+	Usage: required
+	Value type: <u32>
+	Definition: number of columns in the keymap. More information can be
+		    found in input/matrix-keymap.txt.
+
+- debounce:
+	Usage: optional
+	Value type: <u32>
+	Definition: time in microseconds that key must be pressed or release
+		    for key sense interrupt to trigger.
+
+- scan-delay:
+	Usage: optional
+	Value type: <u32>
+	Definition: time in microseconds to pause between successive scans
+		    of the matrix array.
+
+- row-hold:
+	Usage: optional
+	Value type: <u32>
+	Definition: time in nanoseconds to pause between scans of each row in
+		    the matrix array.
+
+EXAMPLE
+
+	keypad@148 {
+		compatible = "qcom,pm8921-keypad";
+		reg = <0x148>;
+		interrupt-parent = <&pmicintc>;
+		interrupts = <74 1>, <75 1>;
+		linux,keymap = <
+			MATRIX_KEY(0, 0, KEY_VOLUMEUP)
+			MATRIX_KEY(0, 1, KEY_VOLUMEDOWN)
+			MATRIX_KEY(0, 2, KEY_CAMERA_FOCUS)
+			MATRIX_KEY(0, 3, KEY_CAMERA)
+			>;
+		keypad,num-rows = <1>;
+		keypad,num-columns = <5>;
+		debounce = <15>;
+		scan-delay = <32>;
+		row-hold = <91500>;
+	};
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

[PATCH v5 8/9] devicetree: bindings: Document PM8921/8058 power keys

[Stephen Boyd]

Document the power key found on PM8921 and PM8058 PMICs.

Cc: <devicetree@vger.kernel.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 .../bindings/input/qcom,pm8xxx-pwrkey.txt          | 46 ++++++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt

diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
new file mode 100644
index 000000000000..588536cc96ed
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
@@ -0,0 +1,46 @@
+Qualcomm PM8xxx PMIC Power Key
+
+PROPERTIES
+
+- compatible:
+	Usage: required
+	Value type: <string>
+	Definition: must be one of:
+		    "qcom,pm8058-pwrkey"
+		    "qcom,pm8921-pwrkey"
+
+- reg:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: address of power key control register
+
+- interrupts:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: the first interrupt specifies the key release interrupt
+		    and the second interrupt specifies the key press interrupt.
+		    The format of the specifier is defined by the binding
+		    document describing the node's interrupt parent.
+
+- debounce:
+	Usage: optional
+	Value type: <u32>
+	Definition: time in microseconds that key must be pressed or release
+		    for state change interrupt to trigger.
+
+- pull-up:
+	Usage: optional
+	Value type: <empty>
+	Definition: presence of this property indicates that the KPDPWR_N pin
+		    should be configured for pull up.
+
+EXAMPLE
+
+	pwrkey@1c {
+		compatible = "qcom,pm8921-pwrkey";
+		reg = <0x1c>;
+		interrupt-parent = <&pmicintc>;
+		interrupts = <50 1>, <51 1>;
+		debounce = <15625>;
+		pull-up;
+	};
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

[PATCH v5 9/9] devicetree: bindings: Document PM8921/8058 vibrators

[Stephen Boyd]

Document the vibration device found on PM8921 and PM8058 PMICs.

Cc: <devicetree@vger.kernel.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 .../devicetree/bindings/input/qcom,pm8xxx-vib.txt  | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.txt

diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.txt b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.txt
new file mode 100644
index 000000000000..4ed467b1e402
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.txt
@@ -0,0 +1,22 @@
+Qualcomm PM8xxx PMIC Vibrator
+
+PROPERTIES
+
+- compatible:
+	Usage: required
+	Value type: <string>
+	Definition: must be one of:
+		    "qcom,pm8058-vib"
+		    "qcom,pm8921-vib"
+
+- reg:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: address of vibration control register
+
+EXAMPLE
+
+	vibrator@4a {
+		compatible = "qcom,pm8058-vib";
+		reg = <0x4a>;
+	};
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

Re: [PATCH v5 0/9] Use regmap+devm+DT in pm8xxx input drivers

[Stephen Boyd]

ping?

On 03/04/14 10:34, Stephen Boyd wrote:
> These patches move the pm8xxx input drivers over to use devm_* APIs
> and regmap. This breaks the dependency of these drivers on the pm8xxx
> specific read/write calls and also simplifies the probe code a bit.
> Finally we add devicetree support to these drivers so they can be probed
> on the platforms that are supported upstream.
>
> Changes since v4:
>  * Added reg property to bindings
>  * Added linux,* properties to keypad binding
>
> Changes since v3:
>  * Dropped devm conversion patch for pwrkey
>  * Fixed compilation of keypad
>
> Changes since v2:
>  * Rebased to v3.14-rc3
>
> Changes since v1:
>  * Picked up Dmitry's version of devm for pwrkey
>  * Added DT bindings and parsing patches
>  * Dropped patches picked up by Dmitry
>
> Stephen Boyd (9):
>   Input: pmic8xxx-keypad - Fix build by removing gpio configuration
>   Input: pmic8xxx-keypad - Migrate to devm_* APIs
>   Input: pmic8xxx-keypad - Migrate to regmap APIs
>   Input: pmic8xxx-keypad - Migrate to DT
>   Input: pmic8xxx-pwrkey - Migrate to DT
>   Input: pm8xxx-vibrator - Add DT match table
>   devicetree: bindings: Document PM8921/8058 keypads
>   devicetree: bindings: Document PM8921/8058 power keys
>   devicetree: bindings: Document PM8921/8058 vibrators
>
>  .../bindings/input/qcom,pm8xxx-keypad.txt          |  89 ++++++
>  .../bindings/input/qcom,pm8xxx-pwrkey.txt          |  46 +++
>  .../devicetree/bindings/input/qcom,pm8xxx-vib.txt  |  22 ++
>  drivers/input/keyboard/pmic8xxx-keypad.c           | 348 ++++++++-------------
>  drivers/input/misc/pm8xxx-vibrator.c               |   8 +
>  drivers/input/misc/pmic8xxx-pwrkey.c               |  33 +-
>  include/linux/input/pmic8xxx-keypad.h              |  52 ---
>  include/linux/input/pmic8xxx-pwrkey.h              |  31 --
>  8 files changed, 316 insertions(+), 313 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
>  create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
>  create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.txt
>  delete mode 100644 include/linux/input/pmic8xxx-keypad.h
>  delete mode 100644 include/linux/input/pmic8xxx-pwrkey.h
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

Re: [PATCH v5 0/9] Use regmap+devm+DT in pm8xxx input drivers

[Stephen Boyd]

ping?

On 03/11/14 10:50, Stephen Boyd wrote:
> ping?
>
> On 03/04/14 10:34, Stephen Boyd wrote:
>> These patches move the pm8xxx input drivers over to use devm_* APIs
>> and regmap. This breaks the dependency of these drivers on the pm8xxx
>> specific read/write calls and also simplifies the probe code a bit.
>> Finally we add devicetree support to these drivers so they can be probed
>> on the platforms that are supported upstream.
>>
>> Changes since v4:
>>  * Added reg property to bindings
>>  * Added linux,* properties to keypad binding
>>
>> Changes since v3:
>>  * Dropped devm conversion patch for pwrkey
>>  * Fixed compilation of keypad
>>
>> Changes since v2:
>>  * Rebased to v3.14-rc3
>>
>> Changes since v1:
>>  * Picked up Dmitry's version of devm for pwrkey
>>  * Added DT bindings and parsing patches
>>  * Dropped patches picked up by Dmitry
>>
>> Stephen Boyd (9):
>>   Input: pmic8xxx-keypad - Fix build by removing gpio configuration
>>   Input: pmic8xxx-keypad - Migrate to devm_* APIs
>>   Input: pmic8xxx-keypad - Migrate to regmap APIs
>>   Input: pmic8xxx-keypad - Migrate to DT
>>   Input: pmic8xxx-pwrkey - Migrate to DT
>>   Input: pm8xxx-vibrator - Add DT match table
>>   devicetree: bindings: Document PM8921/8058 keypads
>>   devicetree: bindings: Document PM8921/8058 power keys
>>   devicetree: bindings: Document PM8921/8058 vibrators
>>
>>  .../bindings/input/qcom,pm8xxx-keypad.txt          |  89 ++++++
>>  .../bindings/input/qcom,pm8xxx-pwrkey.txt          |  46 +++
>>  .../devicetree/bindings/input/qcom,pm8xxx-vib.txt  |  22 ++
>>  drivers/input/keyboard/pmic8xxx-keypad.c           | 348 ++++++++-------------
>>  drivers/input/misc/pm8xxx-vibrator.c               |   8 +
>>  drivers/input/misc/pmic8xxx-pwrkey.c               |  33 +-
>>  include/linux/input/pmic8xxx-keypad.h              |  52 ---
>>  include/linux/input/pmic8xxx-pwrkey.h              |  31 --
>>  8 files changed, 316 insertions(+), 313 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
>>  create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
>>  create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.txt
>>  delete mode 100644 include/linux/input/pmic8xxx-keypad.h
>>  delete mode 100644 include/linux/input/pmic8xxx-pwrkey.h
>>
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation