* [PATCH 0/3] pinctrl: mvebu: prepare for single PMU node
@ 2014-03-05 0:03 Sebastian Hesselbarth
2014-03-05 0:03 ` [PATCH 1/3] ARM: dove: drop pinctrl PMU reg property Sebastian Hesselbarth
[not found] ` <1393977790-29110-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 2 replies; 14+ messages in thread
From: Sebastian Hesselbarth @ 2014-03-05 0:03 UTC (permalink / raw)
To: Sebastian Hesselbarth
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Jason Cooper, Andrew Lunn, Gregory Clement,
Linus Walleij, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
This is a small patch set preparing a discussion and rework for the
Power Management Unit (PMU) found on Marvell Dove SoCs. We are planing
to consolidate PMU into a single DT node instead of chopping it into
tiny pieces [1].
As we just have taken in patches for pinctrl driver that grab another
piece of PMU reg space, we rather drop the corresponding reg property
and wait for v3.15 and proper PMU node rework.
Patch 1 drops the reg property added for pinctrl and is based on mvebu/dt.
Patch 2 drops the reg property added for pinctrl from the corresponding
binding documentation and example. It is based on recently pulled
mvebu/pinctrl-dove.
Patch 3 reduces a WARN on missing reg properties to dev_warn with FW_BUG,
as we just enforced this situation. The driver will continue to work
properly without the resource and derive it from other resources. As soon
as PMU binding is worked out, we will update the driver to make use of it.
The last patch is optional and Linus Walleij can reject it, if he is already
done for v3.15.
[1] https://lkml.org/lkml/2014/3/3/326
Sebastian Hesselbarth (3):
ARM: dove: drop pinctrl PMU reg property
devicetree: bindings: drop pinctrl PMU reg property
pinctrl: mvebu: silence WARN to dev_warn
Documentation/devicetree/bindings/pinctrl/marvell,dove-pinctrl.txt | 2 +-
Documentation/devicetree/bindings/pinctrl/marvell,mvebu-pinctrl.txt | 2 +-
arch/arm/boot/dts/dove.dtsi | 3 +--
drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++-
4 files changed, 5 insertions(+), 5 deletions(-)
---
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
--
1.8.5.3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 1/3] ARM: dove: drop pinctrl PMU reg property 2014-03-05 0:03 [PATCH 0/3] pinctrl: mvebu: prepare for single PMU node Sebastian Hesselbarth @ 2014-03-05 0:03 ` Sebastian Hesselbarth [not found] ` <1393977790-29110-2-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [not found] ` <1393977790-29110-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 1 sibling, 1 reply; 14+ messages in thread From: Sebastian Hesselbarth @ 2014-03-05 0:03 UTC (permalink / raw) To: Sebastian Hesselbarth Cc: Mark Rutland, Andrew Lunn, Russell King, Jason Cooper, Pawel Moll, Ian Campbell, Linus Walleij, linux-kernel, devicetree, Rob Herring, Kumar Gala, Gregory Clement, linux-arm-kernel Marvell Dove's pinctrl does require some PMU regs for muxing PMU functions to MPP pins. Recently, a discussion started about consolidating Power Management Unit (PMU) into a single DT node. As we don't want anymore DT ABI in the way, drop the corresponding reg property from pinctrl node now. The driver will derive the registers from existing reg properties. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> --- Cc: Rob Herring <robh+dt@kernel.org> Cc: Pawel Moll <pawel.moll@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> Cc: Kumar Gala <galak@codeaurora.org> Cc: Russell King <linux@arm.linux.org.uk> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory Clement <gregory.clement@free-electrons.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/dove.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi index b6fc27f8ed66..3b891dd20993 100644 --- a/arch/arm/boot/dts/dove.dtsi +++ b/arch/arm/boot/dts/dove.dtsi @@ -395,8 +395,7 @@ pinctrl: pin-ctrl@d0200 { compatible = "marvell,dove-pinctrl"; reg = <0xd0200 0x14>, - <0xd0440 0x04>, - <0xd802c 0x08>; + <0xd0440 0x04>; clocks = <&gate_clk 22>; pmx_gpio_0: pmx-gpio-0 { -- 1.8.5.3 ^ permalink raw reply related [flat|nested] 14+ messages in thread
[parent not found: <1393977790-29110-2-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 1/3] ARM: dove: drop pinctrl PMU reg property [not found] ` <1393977790-29110-2-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-03-06 20:15 ` Jason Cooper 0 siblings, 0 replies; 14+ messages in thread From: Jason Cooper @ 2014-03-06 20:15 UTC (permalink / raw) To: Sebastian Hesselbarth Cc: Mark Rutland, Andrew Lunn, Russell King, Pawel Moll, Ian Campbell, Linus Walleij, linux-kernel-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Kumar Gala, Gregory Clement, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Mar 05, 2014 at 01:03:08AM +0100, Sebastian Hesselbarth wrote: > Marvell Dove's pinctrl does require some PMU regs for muxing PMU > functions to MPP pins. Recently, a discussion started about consolidating > Power Management Unit (PMU) into a single DT node. As we don't want > anymore DT ABI in the way, drop the corresponding reg property from > pinctrl node now. The driver will derive the registers from existing > reg properties. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> > Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> > Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> > Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> > Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> > Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> > Cc: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > arch/arm/boot/dts/dove.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied to mvebu/dt thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <1393977790-29110-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCH 2/3] devicetree: bindings: drop pinctrl PMU reg property [not found] ` <1393977790-29110-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-03-05 0:03 ` Sebastian Hesselbarth 2014-03-06 20:17 ` Jason Cooper 2014-03-05 0:03 ` [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn Sebastian Hesselbarth 2014-03-05 9:12 ` [PATCH 0/3] pinctrl: mvebu: prepare for single PMU node Andrew Lunn 2 siblings, 1 reply; 14+ messages in thread From: Sebastian Hesselbarth @ 2014-03-05 0:03 UTC (permalink / raw) To: Sebastian Hesselbarth Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Jason Cooper, Andrew Lunn, Gregory Clement, Linus Walleij, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA Marvell Dove's pinctrl does require some PMU regs for muxing PMU functions to MPP pins. Recently, a discussion started about consolidating Power Management Unit (PMU) into a single DT node. As we don't want anymore DT ABI in the way, drop the corresponding reg property from pinctrl binding documentation now. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> Cc: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --- Documentation/devicetree/bindings/pinctrl/marvell,dove-pinctrl.txt | 2 +- Documentation/devicetree/bindings/pinctrl/marvell,mvebu-pinctrl.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,dove-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/marvell,dove-pinctrl.txt index cf52477cc7ee..3b3d465cbfd9 100644 --- a/Documentation/devicetree/bindings/pinctrl/marvell,dove-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/marvell,dove-pinctrl.txt @@ -6,7 +6,7 @@ part and usage. Required properties: - compatible: "marvell,dove-pinctrl" - clocks: (optional) phandle of pdma clock -- reg: register specifiers of MPP, MPP4, and PMU MPP registers +- reg: register specifiers of MPP and MPP4 registers Available mpp pins/groups and functions: Note: brackets (x) are not part of the mpp name for marvell,function and given diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,mvebu-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/marvell,mvebu-pinctrl.txt index 0c09f4eb2af0..111b6eea72e8 100644 --- a/Documentation/devicetree/bindings/pinctrl/marvell,mvebu-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/marvell,mvebu-pinctrl.txt @@ -37,7 +37,7 @@ uart1: serial@12100 { pinctrl: pinctrl@d0200 { compatible = "marvell,dove-pinctrl"; - reg = <0xd0200 0x14>, <0xd0440 0x04>, <0xd802c 0x08>; + reg = <0xd0200 0x14>, <0xd0440 0x04>; pmx_uart1_sw: pmx-uart1-sw { marvell,pins = "mpp_uart1"; -- 1.8.5.3 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] devicetree: bindings: drop pinctrl PMU reg property 2014-03-05 0:03 ` [PATCH 2/3] devicetree: bindings: " Sebastian Hesselbarth @ 2014-03-06 20:17 ` Jason Cooper 0 siblings, 0 replies; 14+ messages in thread From: Jason Cooper @ 2014-03-06 20:17 UTC (permalink / raw) To: Sebastian Hesselbarth Cc: Mark Rutland, Andrew Lunn, Russell King, Pawel Moll, Ian Campbell, Linus Walleij, linux-kernel, devicetree, Rob Herring, Kumar Gala, Gregory Clement, linux-arm-kernel On Wed, Mar 05, 2014 at 01:03:09AM +0100, Sebastian Hesselbarth wrote: > Marvell Dove's pinctrl does require some PMU regs for muxing PMU > functions to MPP pins. Recently, a discussion started about consolidating > Power Management Unit (PMU) into a single DT node. As we don't want > anymore DT ABI in the way, drop the corresponding reg property from > pinctrl binding documentation now. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> > Cc: Kumar Gala <galak@codeaurora.org> > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory Clement <gregory.clement@free-electrons.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > Documentation/devicetree/bindings/pinctrl/marvell,dove-pinctrl.txt | 2 +- > Documentation/devicetree/bindings/pinctrl/marvell,mvebu-pinctrl.txt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied to mvebu/pinctrl thx, Jason. ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn [not found] ` <1393977790-29110-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-03-05 0:03 ` [PATCH 2/3] devicetree: bindings: " Sebastian Hesselbarth @ 2014-03-05 0:03 ` Sebastian Hesselbarth [not found] ` <1393977790-29110-4-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-03-05 9:12 ` [PATCH 0/3] pinctrl: mvebu: prepare for single PMU node Andrew Lunn 2 siblings, 1 reply; 14+ messages in thread From: Sebastian Hesselbarth @ 2014-03-05 0:03 UTC (permalink / raw) To: Sebastian Hesselbarth Cc: Russell King, Jason Cooper, Andrew Lunn, Gregory Clement, Linus Walleij, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA Pinctrl will WARN on missing DT resources, which is a little bit too noisy. Use dev_warn with FW_BUG instead. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> Cc: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --- drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c b/drivers/pinctrl/mvebu/pinctrl-dove.c index 9e7ff651c018..3b022178a566 100644 --- a/drivers/pinctrl/mvebu/pinctrl-dove.c +++ b/drivers/pinctrl/mvebu/pinctrl-dove.c @@ -832,7 +832,8 @@ static int dove_pinctrl_probe(struct platform_device *pdev) } /* Warn on any missing DT resource */ - WARN(fb_res.start, FW_BUG "Missing pinctrl regs in DTB. Please update your firmware.\n"); + if (fb_res.start) + dev_warn(&pdev->dev, FW_BUG "Missing pinctrl regs in DTB. Please update your firmware.\n"); return mvebu_pinctrl_probe(pdev); } -- 1.8.5.3 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 14+ messages in thread
[parent not found: <1393977790-29110-4-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn [not found] ` <1393977790-29110-4-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-03-06 20:18 ` Jason Cooper 2014-03-07 3:48 ` Linus Walleij 0 siblings, 1 reply; 14+ messages in thread From: Jason Cooper @ 2014-03-06 20:18 UTC (permalink / raw) To: Sebastian Hesselbarth Cc: Andrew Lunn, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Gregory Clement, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Mar 05, 2014 at 01:03:10AM +0100, Sebastian Hesselbarth wrote: > Pinctrl will WARN on missing DT resources, which is a little bit too > noisy. Use dev_warn with FW_BUG instead. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> > Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> > Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> > Cc: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to mvebu/pinctrl thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn 2014-03-06 20:18 ` Jason Cooper @ 2014-03-07 3:48 ` Linus Walleij 2014-03-07 3:50 ` Jason Cooper 0 siblings, 1 reply; 14+ messages in thread From: Linus Walleij @ 2014-03-07 3:48 UTC (permalink / raw) To: Jason Cooper Cc: Sebastian Hesselbarth, Andrew Lunn, Russell King, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory Clement, linux-arm-kernel@lists.infradead.org On Fri, Mar 7, 2014 at 4:18 AM, Jason Cooper <jason@lakedaemon.net> wrote: > On Wed, Mar 05, 2014 at 01:03:10AM +0100, Sebastian Hesselbarth wrote: >> Pinctrl will WARN on missing DT resources, which is a little bit too >> noisy. Use dev_warn with FW_BUG instead. >> >> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> >> --- >> Cc: Russell King <linux@arm.linux.org.uk> >> Cc: Jason Cooper <jason@lakedaemon.net> >> Cc: Andrew Lunn <andrew@lunn.ch> >> Cc: Gregory Clement <gregory.clement@free-electrons.com> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: devicetree@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> --- >> drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Applied to mvebu/pinctrl So are you carrying this patch, or shall I apply it to my tree? In the former case: Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn 2014-03-07 3:48 ` Linus Walleij @ 2014-03-07 3:50 ` Jason Cooper 2014-03-07 3:56 ` Linus Walleij 0 siblings, 1 reply; 14+ messages in thread From: Jason Cooper @ 2014-03-07 3:50 UTC (permalink / raw) To: Linus Walleij Cc: Sebastian Hesselbarth, Andrew Lunn, Russell King, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory Clement, linux-arm-kernel@lists.infradead.org On Fri, Mar 07, 2014 at 11:48:25AM +0800, Linus Walleij wrote: > On Fri, Mar 7, 2014 at 4:18 AM, Jason Cooper <jason@lakedaemon.net> wrote: > > On Wed, Mar 05, 2014 at 01:03:10AM +0100, Sebastian Hesselbarth wrote: > >> Pinctrl will WARN on missing DT resources, which is a little bit too > >> noisy. Use dev_warn with FW_BUG instead. > >> > >> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > >> --- > >> Cc: Russell King <linux@arm.linux.org.uk> > >> Cc: Jason Cooper <jason@lakedaemon.net> > >> Cc: Andrew Lunn <andrew@lunn.ch> > >> Cc: Gregory Clement <gregory.clement@free-electrons.com> > >> Cc: Linus Walleij <linus.walleij@linaro.org> > >> Cc: devicetree@vger.kernel.org > >> Cc: linux-arm-kernel@lists.infradead.org > >> Cc: linux-kernel@vger.kernel.org > >> --- > >> drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Applied to mvebu/pinctrl > > So are you carrying this patch, or shall I apply it to my tree? > > In the former case: Acked-by: Linus Walleij <linus.walleij@linaro.org> I'll send you a pull tomorrow. thx, Jason. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn 2014-03-07 3:50 ` Jason Cooper @ 2014-03-07 3:56 ` Linus Walleij [not found] ` <CACRpkdbEQSj7jLWT2BFR22m7phwmyKCByhQuFFgHvHoKvQFD5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Linus Walleij @ 2014-03-07 3:56 UTC (permalink / raw) To: Jason Cooper Cc: Sebastian Hesselbarth, Andrew Lunn, Russell King, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory Clement, linux-arm-kernel@lists.infradead.org On Fri, Mar 7, 2014 at 11:50 AM, Jason Cooper <jason@lakedaemon.net> wrote: > On Fri, Mar 07, 2014 at 11:48:25AM +0800, Linus Walleij wrote: >> On Fri, Mar 7, 2014 at 4:18 AM, Jason Cooper <jason@lakedaemon.net> wrote: >> > On Wed, Mar 05, 2014 at 01:03:10AM +0100, Sebastian Hesselbarth wrote: >> >> Pinctrl will WARN on missing DT resources, which is a little bit too >> >> noisy. Use dev_warn with FW_BUG instead. >> >> >> >> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> >> >> --- >> >> Cc: Russell King <linux@arm.linux.org.uk> >> >> Cc: Jason Cooper <jason@lakedaemon.net> >> >> Cc: Andrew Lunn <andrew@lunn.ch> >> >> Cc: Gregory Clement <gregory.clement@free-electrons.com> >> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> >> Cc: devicetree@vger.kernel.org >> >> Cc: linux-arm-kernel@lists.infradead.org >> >> Cc: linux-kernel@vger.kernel.org >> >> --- >> >> drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++- >> >> 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > Applied to mvebu/pinctrl >> >> So are you carrying this patch, or shall I apply it to my tree? >> >> In the former case: Acked-by: Linus Walleij <linus.walleij@linaro.org> > > I'll send you a pull tomorrow. For a single patch? Remember I want the DTS changes to go to ARM SoC on some different pull... Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <CACRpkdbEQSj7jLWT2BFR22m7phwmyKCByhQuFFgHvHoKvQFD5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn [not found] ` <CACRpkdbEQSj7jLWT2BFR22m7phwmyKCByhQuFFgHvHoKvQFD5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-03-07 13:46 ` Jason Cooper 2014-03-12 14:02 ` Linus Walleij 0 siblings, 1 reply; 14+ messages in thread From: Jason Cooper @ 2014-03-07 13:46 UTC (permalink / raw) To: Linus Walleij Cc: Sebastian Hesselbarth, Andrew Lunn, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Gregory Clement, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On Fri, Mar 07, 2014 at 11:56:11AM +0800, Linus Walleij wrote: > On Fri, Mar 7, 2014 at 11:50 AM, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> wrote: > > On Fri, Mar 07, 2014 at 11:48:25AM +0800, Linus Walleij wrote: > >> On Fri, Mar 7, 2014 at 4:18 AM, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> wrote: > >> > On Wed, Mar 05, 2014 at 01:03:10AM +0100, Sebastian Hesselbarth wrote: > >> >> Pinctrl will WARN on missing DT resources, which is a little bit too > >> >> noisy. Use dev_warn with FW_BUG instead. > >> >> > >> >> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> >> --- > >> >> Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> > >> >> Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> > >> >> Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> > >> >> Cc: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > >> >> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > >> >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >> >> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > >> >> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >> >> --- > >> >> drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++- > >> >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > >> > Applied to mvebu/pinctrl > >> > >> So are you carrying this patch, or shall I apply it to my tree? > >> > >> In the former case: Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > > > > I'll send you a pull tomorrow. > > For a single patch? Well, just the doc change and WARN change. I've already taken the dts change into mvebu/dt (for arm-soc). There should be no need for these two to be in mvebu's for-next, so if it's easier for you to pick them, please do so. I'll drop them from mvebu/pinctrl and update mvebu's for-next right now. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn 2014-03-07 13:46 ` Jason Cooper @ 2014-03-12 14:02 ` Linus Walleij 2014-03-12 15:46 ` Jason Cooper 0 siblings, 1 reply; 14+ messages in thread From: Linus Walleij @ 2014-03-12 14:02 UTC (permalink / raw) To: Jason Cooper Cc: Sebastian Hesselbarth, Andrew Lunn, Russell King, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory Clement, linux-arm-kernel@lists.infradead.org On Fri, Mar 7, 2014 at 2:46 PM, Jason Cooper <jason@lakedaemon.net> wrote: > On Fri, Mar 07, 2014 at 11:56:11AM +0800, Linus Walleij wrote: >> For a single patch? > > Well, just the doc change and WARN change. I've already taken the dts > change into mvebu/dt (for arm-soc). I've applied this patch [3/3] to the pinctrl tree. > There should be no need for these two to be in mvebu's for-next, so if > it's easier for you to pick them, please do so. > > I'll drop them from mvebu/pinctrl and update mvebu's for-next right now. No, I mean, please apply patch 1/3 and 2/3 to the mvebu tree. There is no need to sync DTS and pinctrl driver changes. This patch to the pinctrl driver I want to carry however. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn 2014-03-12 14:02 ` Linus Walleij @ 2014-03-12 15:46 ` Jason Cooper 0 siblings, 0 replies; 14+ messages in thread From: Jason Cooper @ 2014-03-12 15:46 UTC (permalink / raw) To: Linus Walleij Cc: Sebastian Hesselbarth, Andrew Lunn, Russell King, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory Clement, linux-arm-kernel@lists.infradead.org On Wed, Mar 12, 2014 at 03:02:02PM +0100, Linus Walleij wrote: > On Fri, Mar 7, 2014 at 2:46 PM, Jason Cooper <jason@lakedaemon.net> wrote: > > On Fri, Mar 07, 2014 at 11:56:11AM +0800, Linus Walleij wrote: > > >> For a single patch? > > > > Well, just the doc change and WARN change. I've already taken the dts > > change into mvebu/dt (for arm-soc). > > I've applied this patch [3/3] to the pinctrl tree. Ok, thanks. > > There should be no need for these two to be in mvebu's for-next, so if > > it's easier for you to pick them, please do so. > > > > I'll drop them from mvebu/pinctrl and update mvebu's for-next right now. > > No, I mean, please apply patch 1/3 and 2/3 to the mvebu tree. > There is no need to sync DTS and pinctrl driver changes. This > patch to the pinctrl driver I want to carry however. Sorry I wasn't clear. patch 2/3 depends on 356ca6ce0aa4 devicetree: bindings: update MVEBU pinctrl binding documentation Which is in the mvebu/pinctrl branch you have merged into your tree. I usually keep the binding documentation changes in the same branch with the code changes so that during a future bisect, the documentation has a better chance of being consistent with the code at the point of failure. It's a detail thing, I know, but I couldn't find a downside to doing it. Well, until now. :-) thx, Jason. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] pinctrl: mvebu: prepare for single PMU node [not found] ` <1393977790-29110-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-03-05 0:03 ` [PATCH 2/3] devicetree: bindings: " Sebastian Hesselbarth 2014-03-05 0:03 ` [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn Sebastian Hesselbarth @ 2014-03-05 9:12 ` Andrew Lunn 2 siblings, 0 replies; 14+ messages in thread From: Andrew Lunn @ 2014-03-05 9:12 UTC (permalink / raw) To: Sebastian Hesselbarth Cc: Mark Rutland, Andrew Lunn, Russell King, Jason Cooper, Pawel Moll, Ian Campbell, Linus Walleij, linux-kernel-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Kumar Gala, Gregory Clement, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Mar 05, 2014 at 01:03:07AM +0100, Sebastian Hesselbarth wrote: > This is a small patch set preparing a discussion and rework for the > Power Management Unit (PMU) found on Marvell Dove SoCs. We are planing > to consolidate PMU into a single DT node instead of chopping it into > tiny pieces [1]. > > As we just have taken in patches for pinctrl driver that grab another > piece of PMU reg space, we rather drop the corresponding reg property > and wait for v3.15 and proper PMU node rework. > > Patch 1 drops the reg property added for pinctrl and is based on mvebu/dt. > > Patch 2 drops the reg property added for pinctrl from the corresponding > binding documentation and example. It is based on recently pulled > mvebu/pinctrl-dove. > > Patch 3 reduces a WARN on missing reg properties to dev_warn with FW_BUG, > as we just enforced this situation. The driver will continue to work > properly without the resource and derive it from other resources. As soon > as PMU binding is worked out, we will update the driver to make use of it. > > The last patch is optional and Linus Walleij can reject it, if he is already > done for v3.15. Hi Sebastian Whole set of three: Acked-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> Thanks Andrew > > [1] https://lkml.org/lkml/2014/3/3/326 > > Sebastian Hesselbarth (3): > ARM: dove: drop pinctrl PMU reg property > devicetree: bindings: drop pinctrl PMU reg property > pinctrl: mvebu: silence WARN to dev_warn > > Documentation/devicetree/bindings/pinctrl/marvell,dove-pinctrl.txt | 2 +- > Documentation/devicetree/bindings/pinctrl/marvell,mvebu-pinctrl.txt | 2 +- > arch/arm/boot/dts/dove.dtsi | 3 +-- > drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++- > 4 files changed, 5 insertions(+), 5 deletions(-) > > --- > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> > Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> > Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> > Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> > Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> > Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> > Cc: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > -- > 1.8.5.3 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-03-12 15:46 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 0:03 [PATCH 0/3] pinctrl: mvebu: prepare for single PMU node Sebastian Hesselbarth
2014-03-05 0:03 ` [PATCH 1/3] ARM: dove: drop pinctrl PMU reg property Sebastian Hesselbarth
[not found] ` <1393977790-29110-2-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-06 20:15 ` Jason Cooper
[not found] ` <1393977790-29110-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-05 0:03 ` [PATCH 2/3] devicetree: bindings: " Sebastian Hesselbarth
2014-03-06 20:17 ` Jason Cooper
2014-03-05 0:03 ` [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn Sebastian Hesselbarth
[not found] ` <1393977790-29110-4-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-06 20:18 ` Jason Cooper
2014-03-07 3:48 ` Linus Walleij
2014-03-07 3:50 ` Jason Cooper
2014-03-07 3:56 ` Linus Walleij
[not found] ` <CACRpkdbEQSj7jLWT2BFR22m7phwmyKCByhQuFFgHvHoKvQFD5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-07 13:46 ` Jason Cooper
2014-03-12 14:02 ` Linus Walleij
2014-03-12 15:46 ` Jason Cooper
2014-03-05 9:12 ` [PATCH 0/3] pinctrl: mvebu: prepare for single PMU node Andrew Lunn
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).