devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-sh@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Simon Horman <horms@verge.net.au>,
	Shawn Guo <shawn.guo@linaro.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ben Dooks <ben-linux@fluff.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	kernel@pengutronix.de
Subject: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible
Date: Wed,  5 Mar 2014 14:25:51 +0100	[thread overview]
Message-ID: <1394025951-32438-7-git-send-email-l.stach@pengutronix.de> (raw)
In-Reply-To: <1394025951-32438-1-git-send-email-l.stach@pengutronix.de>

This is the recommended method of doing the IRQ
mapping. For old devicetrees we fall back to the
previous practice.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
v2: pass in parent dev to relevant functions, to make DT parsing
    work (spotted by Tim Harvey <tharvey@gateworks.com>)
---
 drivers/pci/host/pcie-designware.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 17ce88f79d2b..98c118e04dba 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -17,6 +17,7 @@
 #include <linux/module.h>
 #include <linux/msi.h>
 #include <linux/of_address.h>
+#include <linux/of_pci.h>
 #include <linux/pci.h>
 #include <linux/pci_regs.h>
 #include <linux/types.h>
@@ -492,7 +493,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp)
 	dw_pci.nr_controllers = 1;
 	dw_pci.private_data = (void **)&pp;
 
-	pci_common_init(&dw_pci);
+	pci_common_init_dev(pp->dev, &dw_pci);
 	pci_assign_unassigned_resources();
 #ifdef CONFIG_PCI_DOMAINS
 	dw_pci.domain++;
@@ -725,7 +726,7 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
 
 	if (pp) {
 		pp->root_bus_nr = sys->busnr;
-		bus = pci_scan_root_bus(NULL, sys->busnr, &dw_pcie_ops,
+		bus = pci_scan_root_bus(pp->dev, sys->busnr, &dw_pcie_ops,
 					sys, &sys->resources);
 	} else {
 		bus = NULL;
@@ -738,8 +739,13 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
 static int dw_pcie_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
 {
 	struct pcie_port *pp = sys_to_pcie(dev->bus->sysdata);
+	int irq;
 
-	return pp->irq;
+	irq = of_irq_parse_and_map_pci(dev, slot, pin);
+	if (!irq)
+		irq = pp->irq;
+
+	return irq;
 }
 
 static void dw_pcie_add_bus(struct pci_bus *bus)
-- 
1.9.0


  parent reply	other threads:[~2014-03-05 13:25 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 13:25 [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach
2014-03-05 13:25 ` [PATCH v2 1/6] ARM: dts: tegra: add PCIe interrupt mapping properties Lucas Stach
     [not found]   ` <1394025951-32438-2-git-send-email-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-03-05 21:55     ` Stephen Warren
2014-03-06  9:33       ` Lucas Stach
2014-03-06 17:41   ` Stephen Warren
2014-03-05 13:25 ` [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible Lucas Stach
2014-03-06 17:36   ` Stephen Warren
2014-03-06 17:39     ` Lucas Stach
     [not found]       ` <1394127555.4582.1.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org>
2014-03-07  0:25         ` Arnd Bergmann
2014-03-07  3:31           ` Jingoo Han
2014-04-11 17:40       ` Srikanth Thokala
2014-04-11 20:41         ` Jason Gunthorpe
     [not found]           ` <20140411204140.GA8967-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2014-04-14 10:56             ` Srikanth Thokala
2014-04-04 16:55   ` Bjorn Helgaas
2014-04-15 10:07     ` Lucas Stach
2014-04-15 18:30       ` Bjorn Helgaas
2014-04-16  8:20         ` Lucas Stach
2014-04-16 16:29           ` Bjorn Helgaas
2014-03-05 13:25 ` [PATCH v2 3/6] PCI: rcar: " Lucas Stach
2014-03-06  4:12   ` Simon Horman
     [not found]   ` <1394025951-32438-4-git-send-email-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-04-04 17:01     ` Bjorn Helgaas
2014-03-05 13:25 ` [PATCH v2 4/6] ARM: dts: exynos5440: fix PCIe interrupt mapping Lucas Stach
2014-03-06  2:38   ` Jingoo Han
2014-03-05 13:25 ` [PATCH v2 5/6] ARM: dts: imx6: add PCIe interrupt mapping properties Lucas Stach
2014-03-10  3:09   ` Shawn Guo
2014-03-05 13:25 ` Lucas Stach [this message]
2014-03-05 18:42   ` [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible Jason Gunthorpe
2014-04-04 17:03     ` Bjorn Helgaas
     [not found]       ` <20140404170341.GG9007-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2014-04-04 17:05         ` Bjorn Helgaas
2014-04-07  8:38           ` Lucas Stach
2014-04-07  9:13             ` Jingoo Han
2014-03-06  2:47   ` Jingoo Han
     [not found]     ` <000201cf38e6$5b02d6e0$110884a0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-06 15:33       ` Marek Vasut
     [not found]         ` <201403061633.31260.marex-ynQEQJNshbs@public.gmane.org>
2014-03-13 17:41           ` Tim Harvey
2014-03-28 15:47 ` [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394025951-32438-7-git-send-email-l.stach@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=arnd@arndb.de \
    --cc=ben-linux@fluff.org \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=horms@verge.net.au \
    --cc=jg1.han@samsung.com \
    --cc=kernel@pengutronix.de \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).