[PATCH v3 0/5] Add USB nodes for am43xx epos and gp evm

[PATCH v3 0/5] Add USB nodes for am43xx epos and gp evm

[George Cherian]

The patch series adds USB dt nodes for am43xx epos and gp evm

Boot tested with  Benoit's for_3.15 + following patches

https://patchwork.kernel.org/patch/3600821/
https://patchwork.kernel.org/patch/3600831/
https://patchwork.kernel.org/patch/3600851/
https://patchwork.kernel.org/patch/3600841/


Changes from v1 -> v2
	* Reorder "doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue"
	* Address v1 coments on "ARM: dts: AM4372: Add USB nodes"  

Changes from v2 -> v3
	* Removed unwanted dwc3_1 and dwc3_2 nodes from am437x-gp-evm.dts 
	  and am43x-epos-evm.dts 

George Cherian (5):
  doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue
  ARM: dts: am43xx clock data
  ARM: dts: AM4372: Add USB nodes
  ARM: dts: am437x-gp-evm: Enable USB
  ARM: dts: am43x-epos-evm: Enable USB

 Documentation/devicetree/bindings/usb/omap-usb.txt |  4 +-
 arch/arm/boot/dts/am4372.dtsi                      | 95 ++++++++++++++++++++++
 arch/arm/boot/dts/am437x-gp-evm.dts                | 18 ++++
 arch/arm/boot/dts/am43x-epos-evm.dts               | 18 ++++
 arch/arm/boot/dts/am43xx-clocks.dtsi               | 17 ++++
 5 files changed, 151 insertions(+), 1 deletion(-)

-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[George Cherian]

Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
index 38b2fae..38d9bb8 100644
--- a/Documentation/devicetree/bindings/usb/omap-usb.txt
+++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
@@ -44,7 +44,9 @@ Board specific device node entry
 };
 
 OMAP DWC3 GLUE
- - compatible : Should be "ti,dwc3"
+ - compatible : Should be
+	* "ti,dwc3" for OMAP5 and DRA7
+	* "ti,am437x-dwc3" for AM437x
  - ti,hwmods : Should be "usb_otg_ss"
  - reg : Address and length of the register set for the device.
  - interrupts : The irq number of this device that is used to interrupt the
-- 
1.8.3.1

[PATCH v3 2/5] ARM: dts: am43xx clock data

[George Cherian]

Add USB reference clock data

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am43xx-clocks.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/am43xx-clocks.dtsi b/arch/arm/boot/dts/am43xx-clocks.dtsi
index 142009c..506d036 100644
--- a/arch/arm/boot/dts/am43xx-clocks.dtsi
+++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
@@ -653,4 +653,21 @@
 		clocks = <&clk_32768_ck>, <&clk_32k_tpm_ck>;
 		reg = <0x4260>;
 	};
+
+	usb_otg_ss0_refclk960m: usb_otg_ss0_refclk960m {
+		#clock-cells = <0>;
+	        compatible = "ti,gate-clock";
+		clocks = <&dpll_per_clkdcoldo>;
+	        ti,bit-shift = <8>;
+	        reg = <0x8a60>;
+	};
+
+	usb_otg_ss1_refclk960m: usb_otg_ss1_refclk960m {
+		#clock-cells = <0>;
+	        compatible = "ti,gate-clock";
+		clocks = <&dpll_per_clkdcoldo>;
+	        ti,bit-shift = <8>;
+		reg = <0x8a68>;
+	};
+
 };
-- 
1.8.3.1

[PATCH v3 3/5] ARM: dts: AM4372: Add USB nodes

[George Cherian]

Add nodes for 2 instances each of
	- ocp2scp
	- USB PHY control module
	- USB PHY
	- dwc3_omap
	- USB

for AM43xx.

Signed-off-by: George Cherian <george.cherian@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/am4372.dtsi | 95 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 95 insertions(+)

diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index 5a7cc38..fdcdf1b 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -698,6 +698,101 @@
 			       <&edma 11>;
 			dma-names = "tx", "rx";
 		};
+
+		am43xx_control_usb2phy1: control-phy@44e10620 {
+			compatible = "ti,control-phy-usb2-am437";
+			reg = <0x44e10620 0x4>;
+			reg-names = "power";
+		};
+
+		am43xx_control_usb2phy2: control-phy@0x44e10628 {
+			compatible = "ti,control-phy-usb2-am437";
+			reg = <0x44e10628 0x4>;
+			reg-names = "power";
+		};
+
+		ocp2scp0: ocp2scp@483a8000 {
+			compatible = "ti,omap-ocp2scp";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+			ti,hwmods = "ocp2scp0";
+
+			usb2_phy1: phy@483a8000 {
+				compatible = "ti,am437x-usb2";
+				reg = <0x483a8000 0x8000>;
+				ctrl-module = <&am43xx_control_usb2phy1>;
+				clocks = <&clk_32768_ck>,
+					 <&usb_otg_ss0_refclk960m>;
+				clock-names = "wkupclk", "refclk";
+				#phy-cells = <0>;
+				status = "disabled";
+			};
+		};
+
+		ocp2scp1: ocp2scp@483e8000 {
+			compatible = "ti,omap-ocp2scp";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+			ti,hwmods = "ocp2scp1";
+
+			usb2_phy2: phy@483e8000 {
+				compatible = "ti,am437x-usb2";
+				reg = <0x483e8000 0x8000>;
+				ctrl-module = <&am43xx_control_usb2phy2>;
+				clocks = <&clk_32768_ck>,
+					 <&usb_otg_ss1_refclk960m>;
+				clock-names = "wkupclk", "refclk";
+				#phy-cells = <0>;
+				status = "disabled";
+			};
+		};
+
+		dwc3_1: omap_dwc3@48380000 {
+			compatible = "ti,am437x-dwc3";
+			ti,hwmods = "usb_otg_ss0";
+			reg = <0x48380000 0x10000>;
+			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			utmi-mode = <1>;
+			ranges;
+
+			usb1: usb@48390000 {
+				compatible = "synopsys,dwc3";
+				reg = <0x48390000 0x17000>;
+				interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
+				phys = <&usb2_phy1>;
+				phy-names = "usb2-phy";
+				maximum-speed = "high-speed";
+				dr_mode = "otg";
+				status = "disabled";
+			};
+		};
+
+		dwc3_2: omap_dwc3@483c0000 {
+			compatible = "ti,am437x-dwc3";
+			ti,hwmods = "usb_otg_ss1";
+			reg = <0x483c0000 0x10000>;
+			interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			utmi-mode = <1>;
+			ranges;
+
+			usb2: usb@483d0000 {
+				compatible = "synopsys,dwc3";
+				reg = <0x483d0000 0x17000>;
+				interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+				phys = <&usb2_phy2>;
+				phy-names = "usb2-phy";
+				maximum-speed = "high-speed";
+				dr_mode = "otg";
+				status = "disabled";
+			};
+		};
+
 	};
 };
 
-- 
1.8.3.1

[PATCH v3 4/5] ARM: dts: am437x-gp-evm: Enable USB

[George Cherian]

Enable
	- ocp2scp
	- USB PHY control module
	- USB PHY
	- dwc3_omap
	- USB
for am437x-gp-evm

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 4eb72b8..347d367 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -98,3 +98,21 @@
 &gpio4 {
 	status = "okay";
 };
+
+&usb2_phy1 {
+	status = "okay";
+};
+
+&usb1 {
+	dr_mode = "peripheral";
+	status = "okay";
+};
+
+&usb2_phy2 {
+	status = "okay";
+};
+
+&usb2 {
+	dr_mode = "host";
+	status = "okay";
+};
-- 
1.8.3.1

[PATCH v3 5/5] ARM: dts: am43x-epos-evm: Enable USB

[George Cherian]

Enable
	- ocp2scp
	- USB PHY control module
	- USB PHY
	- dwc3_omap
	- USB

for am43x-epos-evm

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am43x-epos-evm.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index a7d0db1..0ced342 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -251,3 +251,21 @@
 	pinctrl-0 = <&spi1_pins>;
 	status = "okay";
 };
+
+&usb2_phy1 {
+	status = "okay";
+};
+
+&usb1 {
+	dr_mode = "peripheral";
+	status = "okay";
+};
+
+&usb2_phy2 {
+	status = "okay";
+};
+
+&usb2 {
+	dr_mode = "host";
+	status = "okay";
+};
-- 
1.8.3.1

Re: [PATCH v3 0/5] Add USB nodes for am43xx epos and gp evm

[George Cherian]

Hi Tony,

On 3/7/2014 5:26 PM, George Cherian wrote:
> The patch series adds USB dt nodes for am43xx epos and gp evm
>
> Boot tested with  Benoit's for_3.15 + following patches
>
> https://patchwork.kernel.org/patch/3600821/
> https://patchwork.kernel.org/patch/3600831/
> https://patchwork.kernel.org/patch/3600851/
> https://patchwork.kernel.org/patch/3600841/
>
>
> Changes from v1 -> v2
> 	* Reorder "doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue"
> 	* Address v1 coments on "ARM: dts: AM4372: Add USB nodes"
>
> Changes from v2 -> v3
> 	* Removed unwanted dwc3_1 and dwc3_2 nodes from am437x-gp-evm.dts
> 	  and am43x-epos-evm.dts
>
> George Cherian (5):
>    doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue
>    ARM: dts: am43xx clock data
>    ARM: dts: AM4372: Add USB nodes
>    ARM: dts: am437x-gp-evm: Enable USB
>    ARM: dts: am43x-epos-evm: Enable USB
>
>   Documentation/devicetree/bindings/usb/omap-usb.txt |  4 +-
>   arch/arm/boot/dts/am4372.dtsi                      | 95 ++++++++++++++++++++++
>   arch/arm/boot/dts/am437x-gp-evm.dts                | 18 ++++
>   arch/arm/boot/dts/am43x-epos-evm.dts               | 18 ++++
>   arch/arm/boot/dts/am43xx-clocks.dtsi               | 17 ++++
>   5 files changed, 151 insertions(+), 1 deletion(-)
Can you please take this series.
The whole series Reviewed-by: Roger Quadros <rogerq@ti.com>


-- 
-George

Re: [PATCH v3 0/5] Add USB nodes for am43xx epos and gp evm

[Tony Lindgren]

* George Cherian <george.cherian@ti.com> [140311 22:02]:
> Hi Tony,
> 
> On 3/7/2014 5:26 PM, George Cherian wrote:
> >The patch series adds USB dt nodes for am43xx epos and gp evm
> >
> >Boot tested with  Benoit's for_3.15 + following patches
> >
> >https://patchwork.kernel.org/patch/3600821/
> >https://patchwork.kernel.org/patch/3600831/
> >https://patchwork.kernel.org/patch/3600851/
> >https://patchwork.kernel.org/patch/3600841/
> >
> >
> >Changes from v1 -> v2
> >	* Reorder "doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue"
> >	* Address v1 coments on "ARM: dts: AM4372: Add USB nodes"
> >
> >Changes from v2 -> v3
> >	* Removed unwanted dwc3_1 and dwc3_2 nodes from am437x-gp-evm.dts
> >	  and am43x-epos-evm.dts
> >
> >George Cherian (5):
> >   doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue
> >   ARM: dts: am43xx clock data
> >   ARM: dts: AM4372: Add USB nodes
> >   ARM: dts: am437x-gp-evm: Enable USB
> >   ARM: dts: am43x-epos-evm: Enable USB
> >
> >  Documentation/devicetree/bindings/usb/omap-usb.txt |  4 +-
> >  arch/arm/boot/dts/am4372.dtsi                      | 95 ++++++++++++++++++++++
> >  arch/arm/boot/dts/am437x-gp-evm.dts                | 18 ++++
> >  arch/arm/boot/dts/am43x-epos-evm.dts               | 18 ++++
> >  arch/arm/boot/dts/am43xx-clocks.dtsi               | 17 ++++
> >  5 files changed, 151 insertions(+), 1 deletion(-)
> Can you please take this series.
> The whole series Reviewed-by: Roger Quadros <rogerq@ti.com>

Hmm I only see ack from Roger on patch 3? 

Regards,

Tony

Re: [PATCH v3 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[Roger Quadros]

Hi George,

On 03/07/2014 01:56 PM, George Cherian wrote:
> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>
> ---
>  Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
> index 38b2fae..38d9bb8 100644
> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
> @@ -44,7 +44,9 @@ Board specific device node entry
>  };
>  
>  OMAP DWC3 GLUE
> - - compatible : Should be "ti,dwc3"
> + - compatible : Should be
> +	* "ti,dwc3" for OMAP5 and DRA7
> +	* "ti,am437x-dwc3" for AM437x

Why do you need a new compatible for am437x? Isn't "ti,dwc3" sufficient?

>   - ti,hwmods : Should be "usb_otg_ss"
>   - reg : Address and length of the register set for the device.
>   - interrupts : The irq number of this device that is used to interrupt the
> 

cheers,
-roger

Re: [PATCH v3 2/5] ARM: dts: am43xx clock data

[Roger Quadros]

Hi George,

On 03/07/2014 01:56 PM, George Cherian wrote:
> Add USB reference clock data
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>
> ---
>  arch/arm/boot/dts/am43xx-clocks.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am43xx-clocks.dtsi b/arch/arm/boot/dts/am43xx-clocks.dtsi
> index 142009c..506d036 100644
> --- a/arch/arm/boot/dts/am43xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
> @@ -653,4 +653,21 @@
>  		clocks = <&clk_32768_ck>, <&clk_32k_tpm_ck>;
>  		reg = <0x4260>;
>  	};
> +
> +	usb_otg_ss0_refclk960m: usb_otg_ss0_refclk960m {
> +		#clock-cells = <0>;
> +	        compatible = "ti,gate-clock";
> +		clocks = <&dpll_per_clkdcoldo>;
> +	        ti,bit-shift = <8>;
> +	        reg = <0x8a60>;
> +	};
> +
> +	usb_otg_ss1_refclk960m: usb_otg_ss1_refclk960m {
> +		#clock-cells = <0>;
> +	        compatible = "ti,gate-clock";
> +		clocks = <&dpll_per_clkdcoldo>;
> +	        ti,bit-shift = <8>;
> +		reg = <0x8a68>;
> +	};
> +
>  };
> 

I was reviewing am43xx usb clock information recently and found out that
PHY clock is missing here. e.g. usb_phy0_always_on_clk32k and usb_phy1_always_on_clk32k.

Can you please add these clocks?

cheers,
-roger

Re: [PATCH v3 3/5] ARM: dts: AM4372: Add USB nodes

[Roger Quadros]

On 03/07/2014 01:57 PM, George Cherian wrote:
> Add nodes for 2 instances each of
> 	- ocp2scp
> 	- USB PHY control module
> 	- USB PHY
> 	- dwc3_omap
> 	- USB
> 
> for AM43xx.
> 
> Signed-off-by: George Cherian <george.cherian-l0cyMroinI0@public.gmane.org>
> Acked-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
> ---
>  arch/arm/boot/dts/am4372.dtsi | 95 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 95 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index 5a7cc38..fdcdf1b 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -698,6 +698,101 @@
>  			       <&edma 11>;
>  			dma-names = "tx", "rx";
>  		};
> +
> +		am43xx_control_usb2phy1: control-phy@44e10620 {
> +			compatible = "ti,control-phy-usb2-am437";
> +			reg = <0x44e10620 0x4>;
> +			reg-names = "power";
> +		};
> +
> +		am43xx_control_usb2phy2: control-phy@0x44e10628 {
> +			compatible = "ti,control-phy-usb2-am437";
> +			reg = <0x44e10628 0x4>;
> +			reg-names = "power";
> +		};
> +
> +		ocp2scp0: ocp2scp@483a8000 {
> +			compatible = "ti,omap-ocp2scp";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +			ti,hwmods = "ocp2scp0";
> +
> +			usb2_phy1: phy@483a8000 {
> +				compatible = "ti,am437x-usb2";
> +				reg = <0x483a8000 0x8000>;
> +				ctrl-module = <&am43xx_control_usb2phy1>;
> +				clocks = <&clk_32768_ck>,

shouldn't the PHY wakeup clock be "usb_phy0_always_on_clk32k"?

> +					 <&usb_otg_ss0_refclk960m>;
> +				clock-names = "wkupclk", "refclk";
> +				#phy-cells = <0>;
> +				status = "disabled";
> +			};
> +		};
> +
> +		ocp2scp1: ocp2scp@483e8000 {
> +			compatible = "ti,omap-ocp2scp";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +			ti,hwmods = "ocp2scp1";
> +
> +			usb2_phy2: phy@483e8000 {
> +				compatible = "ti,am437x-usb2";
> +				reg = <0x483e8000 0x8000>;
> +				ctrl-module = <&am43xx_control_usb2phy2>;
> +				clocks = <&clk_32768_ck>,

&usb_phy1_always_on_clk32k here?

> +					 <&usb_otg_ss1_refclk960m>;
> +				clock-names = "wkupclk", "refclk";
> +				#phy-cells = <0>;
> +				status = "disabled";
> +			};
> +		};
> +
> +		dwc3_1: omap_dwc3@48380000 {
> +			compatible = "ti,am437x-dwc3";
> +			ti,hwmods = "usb_otg_ss0";
> +			reg = <0x48380000 0x10000>;
> +			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			utmi-mode = <1>;
> +			ranges;
> +
> +			usb1: usb@48390000 {
> +				compatible = "synopsys,dwc3";
> +				reg = <0x48390000 0x17000>;
> +				interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
> +				phys = <&usb2_phy1>;
> +				phy-names = "usb2-phy";
> +				maximum-speed = "high-speed";
> +				dr_mode = "otg";
> +				status = "disabled";
> +			};
> +		};
> +
> +		dwc3_2: omap_dwc3@483c0000 {
> +			compatible = "ti,am437x-dwc3";
> +			ti,hwmods = "usb_otg_ss1";
> +			reg = <0x483c0000 0x10000>;
> +			interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			utmi-mode = <1>;
> +			ranges;
> +
> +			usb2: usb@483d0000 {
> +				compatible = "synopsys,dwc3";
> +				reg = <0x483d0000 0x17000>;
> +				interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> +				phys = <&usb2_phy2>;
> +				phy-names = "usb2-phy";
> +				maximum-speed = "high-speed";
> +				dr_mode = "otg";
> +				status = "disabled";
> +			};
> +		};
> +
>  	};
>  };
>  
> 

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 4/5] ARM: dts: am437x-gp-evm: Enable USB

[Roger Quadros]

On 03/07/2014 01:57 PM, George Cherian wrote:
> Enable
> 	- ocp2scp
> 	- USB PHY control module
> 	- USB PHY
> 	- dwc3_omap
> 	- USB
> for am437x-gp-evm
> 
> Signed-off-by: George Cherian <george.cherian-l0cyMroinI0@public.gmane.org>

Acked-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>

> ---
>  arch/arm/boot/dts/am437x-gp-evm.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
> index 4eb72b8..347d367 100644
> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
> @@ -98,3 +98,21 @@
>  &gpio4 {
>  	status = "okay";
>  };
> +
> +&usb2_phy1 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	dr_mode = "peripheral";
> +	status = "okay";
> +};
> +
> +&usb2_phy2 {
> +	status = "okay";
> +};
> +
> +&usb2 {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 5/5] ARM: dts: am43x-epos-evm: Enable USB

[Roger Quadros]

On 03/07/2014 01:57 PM, George Cherian wrote:
> Enable
> 	- ocp2scp
> 	- USB PHY control module
> 	- USB PHY
> 	- dwc3_omap
> 	- USB

we are not enabling "PHY control module" here.

> 
> for am43x-epos-evm
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>

With the description change.

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger

> ---
>  arch/arm/boot/dts/am43x-epos-evm.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
> index a7d0db1..0ced342 100644
> --- a/arch/arm/boot/dts/am43x-epos-evm.dts
> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts
> @@ -251,3 +251,21 @@
>  	pinctrl-0 = <&spi1_pins>;
>  	status = "okay";
>  };
> +
> +&usb2_phy1 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	dr_mode = "peripheral";
> +	status = "okay";
> +};
> +
> +&usb2_phy2 {
> +	status = "okay";
> +};
> +
> +&usb2 {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> 

Re: [PATCH v3 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[George Cherian]

On 3/13/2014 4:02 PM, Roger Quadros wrote:
> Hi George,
>
> On 03/07/2014 01:56 PM, George Cherian wrote:
>> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
>>
>> Signed-off-by: George Cherian <george.cherian-l0cyMroinI0@public.gmane.org>
>> ---
>>   Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
>> index 38b2fae..38d9bb8 100644
>> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
>> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
>> @@ -44,7 +44,9 @@ Board specific device node entry
>>   };
>>   
>>   OMAP DWC3 GLUE
>> - - compatible : Should be "ti,dwc3"
>> + - compatible : Should be
>> +	* "ti,dwc3" for OMAP5 and DRA7
>> +	* "ti,am437x-dwc3" for AM437x
> Why do you need a new compatible for am437x? Isn't "ti,dwc3" sufficient?

There is change in register offsets for AM437x as comapred to Omap5 and 
dra7x.
The compatible is already added in dwc3-omap.c  This patch just updates 
the Documentation.
>
>>    - ti,hwmods : Should be "usb_otg_ss"
>>    - reg : Address and length of the register set for the device.
>>    - interrupts : The irq number of this device that is used to interrupt the
>>
> cheers,
> -roger


-- 
-George

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/5] ARM: dts: am43xx clock data

[George Cherian]

On 3/13/2014 4:05 PM, Roger Quadros wrote:
> Hi George,
>
> On 03/07/2014 01:56 PM, George Cherian wrote:
>> Add USB reference clock data
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>>   arch/arm/boot/dts/am43xx-clocks.dtsi | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am43xx-clocks.dtsi b/arch/arm/boot/dts/am43xx-clocks.dtsi
>> index 142009c..506d036 100644
>> --- a/arch/arm/boot/dts/am43xx-clocks.dtsi
>> +++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
>> @@ -653,4 +653,21 @@
>>   		clocks = <&clk_32768_ck>, <&clk_32k_tpm_ck>;
>>   		reg = <0x4260>;
>>   	};
>> +
>> +	usb_otg_ss0_refclk960m: usb_otg_ss0_refclk960m {
>> +		#clock-cells = <0>;
>> +	        compatible = "ti,gate-clock";
>> +		clocks = <&dpll_per_clkdcoldo>;
>> +	        ti,bit-shift = <8>;
>> +	        reg = <0x8a60>;
>> +	};
>> +
>> +	usb_otg_ss1_refclk960m: usb_otg_ss1_refclk960m {
>> +		#clock-cells = <0>;
>> +	        compatible = "ti,gate-clock";
>> +		clocks = <&dpll_per_clkdcoldo>;
>> +	        ti,bit-shift = <8>;
>> +		reg = <0x8a68>;
>> +	};
>> +
>>   };
>>
> I was reviewing am43xx usb clock information recently and found out that
> PHY clock is missing here. e.g. usb_phy0_always_on_clk32k and usb_phy1_always_on_clk32k.
>
> Can you please add these clocks?

okay I will add those and resend the series.
>
> cheers,
> -roger


-- 
-George

Re: [PATCH v3 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[Roger Quadros]

On 03/13/2014 01:41 PM, George Cherian wrote:
> On 3/13/2014 4:02 PM, Roger Quadros wrote:
>> Hi George,
>>
>> On 03/07/2014 01:56 PM, George Cherian wrote:
>>> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
>>>
>>> Signed-off-by: George Cherian <george.cherian-l0cyMroinI0@public.gmane.org>
>>> ---
>>>   Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> index 38b2fae..38d9bb8 100644
>>> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> @@ -44,7 +44,9 @@ Board specific device node entry
>>>   };
>>>     OMAP DWC3 GLUE
>>> - - compatible : Should be "ti,dwc3"
>>> + - compatible : Should be
>>> +    * "ti,dwc3" for OMAP5 and DRA7
>>> +    * "ti,am437x-dwc3" for AM437x
>> Why do you need a new compatible for am437x? Isn't "ti,dwc3" sufficient?
> 
> There is change in register offsets for AM437x as comapred to Omap5 and dra7x.
> The compatible is already added in dwc3-omap.c  This patch just updates the Documentation.

Oh ok. Then it is fine. You can add my.

Acked-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>

cheers,
-roger
>>
>>>    - ti,hwmods : Should be "usb_otg_ss"
>>>    - reg : Address and length of the register set for the device.
>>>    - interrupts : The irq number of this device that is used to interrupt the
>>>
>> cheers,
>> -roger
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html