From: Soren Brinkmann <soren.brinkmann@xilinx.com>
To: Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Michal Simek <michal.simek@xilinx.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Soren Brinkmann <soren.brinkmann@xilinx.com>
Subject: [PATCH v2 2/7] tty: xuartps: Print warning in clock notifier
Date: Mon, 10 Mar 2014 14:40:05 -0700 [thread overview]
Message-ID: <1394487610-2419-3-git-send-email-soren.brinkmann@xilinx.com> (raw)
In-Reply-To: <1394487610-2419-1-git-send-email-soren.brinkmann@xilinx.com>
Print a warning if the clock notifier rejects a clock frequency change
to facilitate debugging (see:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/304329/focus=304379)
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
drivers/tty/serial/xilinx_uartps.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 1c6e1a68ae95..b00060052316 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -429,8 +429,10 @@ static int xuartps_clk_notifier_cb(struct notifier_block *nb,
* frequency.
*/
if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud,
- &bdiv, &cd, &div8))
+ &bdiv, &cd, &div8)) {
+ dev_warn(port->dev, "clock rate change rejected\n");
return NOTIFY_BAD;
+ }
spin_lock_irqsave(&xuartps->port->lock, flags);
--
1.9.0.1.g4196000
next prev parent reply other threads:[~2014-03-10 21:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 21:40 [PATCH v2 0/7] tty: xuartps: Rebranding + DT documentation Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 1/7] tty: xuartps: Clean up Soren Brinkmann
2014-03-10 21:40 ` Soren Brinkmann [this message]
2014-03-10 21:40 ` [PATCH v2 3/7] tty: xuartps: Refactor read-modify-writes Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 4/7] tty: xuartps: Don't write IRQ disable register to enable interrupts Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 5/7] tty: xuartps: Rebrand driver as Cadence UART Soren Brinkmann
2014-03-11 8:50 ` Michal Simek
2014-03-11 15:47 ` Sören Brinkmann
[not found] ` <1394487610-2419-1-git-send-email-soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2014-03-10 21:40 ` [PATCH v2 6/7] tty: cadence: Document DT binding Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 7/7] ARM: zynq: DT: Migrate UART to Cadence binding Soren Brinkmann
2014-03-11 8:52 ` Michal Simek
2014-03-11 15:48 ` Sören Brinkmann
[not found] ` <20140311154847.GI13293@xsjandreislx>
2014-03-12 6:01 ` Michal Simek
2014-03-11 10:46 ` [PATCH v2 0/7] tty: xuartps: Rebranding + DT documentation Michal Simek
2014-03-11 18:29 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394487610-2419-3-git-send-email-soren.brinkmann@xilinx.com \
--to=soren.brinkmann@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).