From: Joe Perches <joe@perches.com>
To: Vince Bridgers <vbridgers2013@gmail.com>
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net
Subject: Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver
Date: Tue, 11 Mar 2014 15:59:07 -0700 [thread overview]
Message-ID: <1394578747.28839.4.camel@joe-AO722> (raw)
In-Reply-To: <1394577791-6547-6-git-send-email-vbridgers2013@gmail.com>
On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:
> This patch adds miscellaneous files for the Altera Ethernet Driver,
> including ethtool support.
trivial notes:
> diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c b/drivers/net/ethernet/altera/altera_tse_ethtool.c
[]
> +static char const stat_gstrings[][ETH_GSTRING_LEN] = {
static const char
> + "aFramesTransmittedOK",
Why the prefix with a?
> + "aFramesReceivedOK",
"rx_packets" is typically used
> + "aFramesCheckSequenceErrors",
> + "aAlignmentErrors",
> + "aOctetsTransmittedOK",
> + "aOctetsReceivedOK",
> + "aTxPAUSEMACCtrlFrames",
> + "aRxPAUSEMACCtrlFrames",
> + "ifInErrors",
> + "ifOutErrors",
> + "ifInUcastPkts",
> + "ifInMulticastPkts",
> + "ifInBroadcastPkts",
> + "ifOutDiscards",
> + "ifOutUcastPkts",
> + "ifOutMulticastPkts",
> + "ifOutBroadcastPkts",
> + "etherStatsDropEvents",
> + "etherStatsOctets",
> + "etherStatsPkts",
> + "etherStatsUndersizePkts",
> + "etherStatsOversizePkts",
> + "etherStatsPkts64Octets",
> + "etherStatsPkts65to127Octets",
> + "etherStatsPkts128to255Octets",
> + "etherStatsPkts256to511Octets",
> + "etherStatsPkts512to1023Octets",
> + "etherStatsPkts1024to1518Octets",
> + "etherStatsPkts1519toXOctets",
> + "etherStatsJabbers",
> + "etherStatsFragments",
Perhaps review all of these strings for
unusual naming.
> +static void tse_get_regs(struct net_device *dev, struct ethtool_regs *regs,
> + void *regbuf)
> +{
> + int i;
> + struct altera_tse_private *priv = netdev_priv(dev);
> + u32 *tse_mac_regs = (u32 *)priv->mac_dev;
> + u32 *buf = (u32 *)regbuf;
void * doesn't need a cast
u32 *buf = regbuf
is just fine.
next prev parent reply other threads:[~2014-03-11 22:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 22:43 [PATCH net-next v3 0/9] Altera Triple Speed Ethernet (TSE) Driver Vince Bridgers
2014-03-11 22:43 ` [PATCH net-next v3 2/9] Documentation: networking: Add Altera Ethernet (TSE) Documentation Vince Bridgers
2014-03-11 22:43 ` [PATCH net-next v3 3/9] Altera TSE: Add Altera Ethernet Driver MSGDMA File Components Vince Bridgers
2014-03-11 22:43 ` [PATCH net-next v3 4/9] Altera TSE: Add Altera Ethernet Driver SGDMA file components Vince Bridgers
2014-03-11 22:43 ` [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver Vince Bridgers
2014-03-11 22:59 ` Joe Perches [this message]
2014-03-12 0:28 ` Vince Bridgers
2014-03-12 21:14 ` Ben Hutchings
2014-03-12 21:27 ` Joe Perches
2014-03-12 22:26 ` Joe Perches
2014-03-13 0:28 ` Ben Hutchings
2014-03-13 0:42 ` Vince Bridgers
[not found] ` <CAOwfj2M6p55s6exrW1y55tddzHd1PvBOW6RpWfFK2hTjmYi=hA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-13 3:46 ` Joe Perches
2014-03-11 22:43 ` [PATCH net-next v3 6/9] Altera TSE: Add main and header file " Vince Bridgers
2014-03-12 0:45 ` Joe Perches
2014-03-12 15:25 ` Vince Bridgers
2014-03-11 22:43 ` [PATCH net-next v3 7/9] Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig Vince Bridgers
[not found] ` <1394577791-6547-1-git-send-email-vbridgers2013-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-11 22:43 ` [PATCH net-next v3 1/9] dts: Add bindings for the Altera Triple Speed Ethernet driver Vince Bridgers
2014-03-11 22:43 ` [PATCH net-next v3 8/9] MAINTAINERS: Add entry for Altera Triple Speed Ethernet Driver Vince Bridgers
2014-03-11 22:43 ` [PATCH net-next v3 9/9] net: ethernet: Change Ethernet Makefile and Kconfig for Altera TSE driver Vince Bridgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394578747.28839.4.camel@joe-AO722 \
--to=joe@perches.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).