From: Joe Perches <joe@perches.com>
To: Vince Bridgers <vbridgers2013@gmail.com>
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net
Subject: Re: [PATCH net-next V4 3/9] Altera TSE: Add Altera Ethernet Driver MSGDMA File Components
Date: Wed, 12 Mar 2014 13:31:15 -0700 [thread overview]
Message-ID: <1394656275.3915.32.camel@joe-AO722> (raw)
In-Reply-To: <1394655334-29547-4-git-send-email-vbridgers2013@gmail.com>
On Wed, 2014-03-12 at 15:15 -0500, Vince Bridgers wrote:
> This patch adds the MSGDMA soft IP support for the Altera Triple
> Speed Ethernet driver.
[]
> Signed-off-by: Vince Bridgers <vbridgers2013@gmail.com>
> ---
> V4: - Modify use of dev_* to netdev_* where possible
Hi again Vince.
trivia:
It'd be better to also use the netif_<foo> forms too.
This can be done later in a follow-on patch if desired.
> diff --git a/drivers/net/ethernet/altera/altera_msgdma.c b/drivers/net/ethernet/altera/altera_msgdma.c
[]
> +void msgdma_reset(struct altera_tse_private *priv)
> +{
[]
> + if ((counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR) &&
> + (netif_msg_drv(priv)))
> + netdev_warn(priv->dev,
> + "TSE Rx mSGDMA resetting bit never cleared!\n");
if (counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR)
netif_warn(priv, drv, priv->dev,
"TSE Rx mSGDMA resetting bit never cleared!\n");
[]
> + if ((counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR) &&
> + (netif_msg_drv(priv)))
> + netdev_warn(priv->dev,
> + "TSE Tx mSGDMA resetting bit never cleared!\n");
if (counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR)
netif_warn(priv, drv, priv->dev,
"TSE Tx mSGDMA resetting bit never cleared!\n");
cheers, Joe
next prev parent reply other threads:[~2014-03-12 20:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 20:15 [PATCH net-next V4 0/9] Altera Triple Speed Ethernet (TSE) Driver Vince Bridgers
2014-03-12 20:15 ` [PATCH net-next V4 1/9] dts: Add bindings for the Altera Triple Speed Ethernet driver Vince Bridgers
2014-03-12 20:15 ` [PATCH net-next V4 2/9] Documentation: networking: Add Altera Ethernet (TSE) Documentation Vince Bridgers
2014-03-12 20:15 ` [PATCH net-next V4 3/9] Altera TSE: Add Altera Ethernet Driver MSGDMA File Components Vince Bridgers
2014-03-12 20:31 ` Joe Perches [this message]
2014-03-13 0:48 ` Vince Bridgers
2014-03-12 20:15 ` [PATCH net-next V4 4/9] Altera TSE: Add Altera Ethernet Driver SGDMA file components Vince Bridgers
2014-03-12 20:15 ` [PATCH net-next V4 5/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver Vince Bridgers
2014-03-12 20:34 ` Joe Perches
2014-03-12 20:15 ` [PATCH net-next V4 6/9] Altera TSE: Add main and header file " Vince Bridgers
2014-03-12 20:42 ` Joe Perches
2014-03-13 0:45 ` Vince Bridgers
2014-03-12 20:15 ` [PATCH net-next V4 7/9] Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig Vince Bridgers
2014-03-12 20:15 ` [PATCH net-next V4 8/9] MAINTAINERS: Add entry for Altera Triple Speed Ethernet Driver Vince Bridgers
[not found] ` <1394655334-29547-1-git-send-email-vbridgers2013-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-12 20:15 ` [PATCH net-next V4 9/9] net: ethernet: Change Ethernet Makefile and Kconfig for Altera TSE driver Vince Bridgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394656275.3915.32.camel@joe-AO722 \
--to=joe@perches.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox