From: <dinguyen@altera.com>
To: dinh.linux@gmail.com, arnd@arndb.de, davem@davemloft.net,
peppe.cavallaro@st.com
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
pawel.moll@arm.com, srinivas.kandagatla@st.com,
netdev@vger.kernel.org, ijc+devicetree@hellion.org.uk,
robh+dt@kernel.org, arm@kernel.org,
Dinh Nguyen <dinguyen@altera.com>,
galak@codeaurora.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] dts: documentation: Update documentation for the stmmac ethernet controller
Date: Tue, 25 Mar 2014 18:34:42 -0500 [thread overview]
Message-ID: <1395790482-3957-4-git-send-email-dinguyen@altera.com> (raw)
In-Reply-To: <1395790482-3957-1-git-send-email-dinguyen@altera.com>
From: Dinh Nguyen <dinguyen@altera.com>
* Add optional clocks and clock-names property into the base stmmac document.
* Update socfpga-dwmac.txt with new compatible string and example binding.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
---
.../devicetree/bindings/net/socfpga-dwmac.txt | 38 ++++++++------------
Documentation/devicetree/bindings/net/stmmac.txt | 6 ++++
2 files changed, 21 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
index d53d376..1ef6db7 100644
--- a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
+++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
@@ -1,35 +1,27 @@
Altera SOCFPGA SoC DWMAC controller
-The device node has following properties.
+This is a variant of the dwmac/stmmac driver an inherits all descriptions
+present in Documentation/devicetree/bindings/net/stmmac.txt.
+
+The device node has additional properties:
Required properties:
- - compatible : Should contain "altr,socfpga-stmmac"
+ - compatible : Should contain "altr,socfpga-stmmac" along with
+ "snps,dwmac" and any applicable more detailed
+ designware version numbers documented in stmmac.txt
- altr,sysmgr-syscon : Should be the phandle to the system manager node that
encompasses the glue register, and the register offset.
-Sub-nodes:
-The dwmac core should be added as subnode to SOCFPGA dwmac glue.
-- dwmac : The binding details of dwmac can be found in
- Documentation/devicetree/bindings/net/stmmac.txt
-
Example:
-ethernet0: ethernet0 {
- #address-cells = <1>;
- #size-cells = <1>;
-
- compatible = "altr,socfpga-stmmac";
+gmac0: ethernet@ff700000 {
+ compatible = "altr,socfpga-stmmac", "snps,dwmac-3.70a", "snps,dwmac";
altr,sysmgr-syscon = <&sysmgr 0x60>;
status = "disabled";
- ranges;
-
- gmac0: gmac0@ff700000 {
- compatible = "snps,dwmac-3.70a", "snps,dwmac";
- reg = <0xff700000 0x2000>;
- interrupts = <0 115 4>;
- interrupt-names = "macirq";
- mac-address = [00 00 00 00 00 00];/* Filled in by U-Boot */
- clocks = <&emac0_clk>;
- clock-names = "stmmaceth";
- };
+ reg = <0xff700000 0x2000>;
+ interrupts = <0 115 4>;
+ interrupt-names = "macirq";
+ mac-address = [00 00 00 00 00 00];/* Filled in by U-Boot */
+ clocks = <&emac0_clk>;
+ clocks-names = "stmmaceth";
};
diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
index 9d92d42..9a0c1b7 100644
--- a/Documentation/devicetree/bindings/net/stmmac.txt
+++ b/Documentation/devicetree/bindings/net/stmmac.txt
@@ -34,6 +34,10 @@ Optional properties:
reset phandle is given
- max-frame-size: Maximum Transfer Unit (IEEE defined MTU), rather
than the maximum frame size.
+- clocks: If present, the first clock should be the GMAC main clock,
+ further clocks may be specified in derived bindings.
+- clocks-names: One name for each entry in the clocks property, the
+ first one should be "stmmaceth".
Examples:
@@ -46,4 +50,6 @@ Examples:
mac-address = [000000000000]; /* Filled in by U-Boot */
max-frame-size = <3800>;
phy-mode = "gmii";
+ clocks = <&clock>;
+ clock-names = "stmmaceth">;
};
--
1.7.9.5
next prev parent reply other threads:[~2014-03-25 23:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 23:34 [PATCH 0/3] Fix stmmac-socfpga allmodconfig breakage in arm-soc dinguyen-EIB2kfCEclfQT0dZR+AlfA
[not found] ` <1395790482-3957-1-git-send-email-dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
2014-03-25 23:34 ` [PATCH 1/3] net: stmmac: improve binding and fix build dinguyen-EIB2kfCEclfQT0dZR+AlfA
2014-03-25 23:34 ` [PATCH 2/3] dts: socfpga: Fix ethernet entries for the stmmac dinguyen
2014-03-26 22:12 ` Gerhard Sittig
2014-03-27 0:05 ` Dinh Nguyen
2014-03-25 23:34 ` dinguyen [this message]
2014-03-26 21:54 ` [PATCH 0/3] Fix stmmac-socfpga allmodconfig breakage in arm-soc Arnd Bergmann
2014-03-27 0:05 ` Dinh Nguyen
[not found] ` <53336B39.3080209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-27 0:29 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395790482-3957-4-git-send-email-dinguyen@altera.com \
--to=dinguyen@altera.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinh.linux@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).