From: Joe Perches <joe@perches.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com,
grant.likely@linaro.org, robh+dt@kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Kedareswara rao Appana <appanad@xilinx.com>
Subject: Re: [PATCH v6] can: xilinx CAN controller support
Date: Tue, 25 Mar 2014 22:39:17 -0700 [thread overview]
Message-ID: <1395812357.3726.14.camel@joe-AO722> (raw)
In-Reply-To: <5ff46a21-3047-40ff-9221-f08e476f9ce6@VA3EHSMHS030.ehs.local>
On Wed, 2014-03-26 at 10:56 +0530, Kedareswara rao Appana wrote:
> This patch adds xilinx CAN controller support.
> This driver supports both ZYNQ CANPS and Soft IP
> AXI CAN controller.
Just trivial notes about dmesg logging output.
> diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
[]
> +static int set_reset_mode(struct net_device *ndev)
> +{
[]
> + netdev_warn(ndev, "timedout waiting for config mode\n");
timed out
> +static int xcan_set_bittiming(struct net_device *ndev)
> +{
[]
> + if (!is_config_mode) {
> + netdev_alert(ndev,
> + "BUG! Cannot set bittiming can is notin config mode\n");
"Cannot set bit timing - CAN is not in config mode\n"
> +static int xcan_chip_start(struct net_device *ndev)
> +{
> + netdev_warn(ndev,
> + "time out waiting for correct mode\n");
Please be consistent. Maybe
"timed out waiting for correct mode\n"
> +static int xcan_open(struct net_device *ndev)
> +{
> + struct xcan_priv *priv = netdev_priv(ndev);
> + int ret;
> +
> + ret = request_irq(ndev->irq, xcan_interrupt, priv->irq_flags,
> + ndev->name, ndev);
> + if (ret < 0) {
> + netdev_err(ndev, "Irq allocation for CAN failed\n");
irq is almost always lower case.
next prev parent reply other threads:[~2014-03-26 5:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 5:26 [PATCH v6] can: xilinx CAN controller support Kedareswara rao Appana
2014-03-26 5:39 ` Joe Perches [this message]
2014-03-27 14:20 ` Appana Durga Kedareswara Rao
2014-03-27 14:14 ` Michal Simek
2014-03-27 14:21 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395812357.3726.14.camel@joe-AO722 \
--to=joe@perches.com \
--cc=appana.durga.rao@xilinx.com \
--cc=appanad@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).