From: Grant Likely <grant.likely@linaro.org>
To: devicetree@vger.kernel.org, christoffer.dall@linaro.org,
linux-kernel@vger.kernel.org, olof@lixom.net,
benh@kernel.crashing.org, rob.herring@linaro.org
Cc: Grant Likely <grant.likely@linaro.org>
Subject: [RFC 3/5] of: Enable console on serial ports specified by /chosen/stdout-path
Date: Fri, 28 Mar 2014 09:08:03 -0700 [thread overview]
Message-ID: <1396022885-6102-4-git-send-email-grant.likely@linaro.org> (raw)
In-Reply-To: <1396022885-6102-1-git-send-email-grant.likely@linaro.org>
If the devicetree specifies a serial port as a stdout device, then the
kernel can use it as the default console if nothing else was selected on
the command line. For any serial port that uses the uart_add_one_port()
feature, the uart_add_one_port() has all the information needed to
automatically enable the console device, which is what this patch does.
With this change applied, a device tree platform can be booted without
any console= parameters on the command line and the kernel will still be
able to determine its console.
Signed-off-by: Grant Likely <grant.likely@linaro.org>
---
drivers/tty/serial/serial_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index ece2049bd270..2fac7593d7b2 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -26,6 +26,7 @@
#include <linux/slab.h>
#include <linux/init.h>
#include <linux/console.h>
+#include <linux/of.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
#include <linux/device.h>
@@ -2604,6 +2605,8 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
spin_lock_init(&uport->lock);
lockdep_set_class(&uport->lock, &port_lock_key);
}
+ if (uport->cons && uport->dev)
+ of_console_check(uport->dev->of_node, uport->cons->name, uport->line);
uart_configure_port(drv, state, uport);
--
1.8.3.2
next prev parent reply other threads:[~2014-03-28 16:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 16:08 [RFC 0/5] of: Automatic console registration cleanups Grant Likely
[not found] ` < 20140328185653.GB26433@quad.lixom.net>
[not found] ` < CAL_JsqKFO+OSz83f=XdyKgCqByUvHe7qLzgn5QLU1x1V1A5Fng@mail.gmail.com>
[not found] ` < 20140331071014.GN17250@pengutronix.de>
2014-03-28 16:08 ` [RFC 1/5] of: Add support for ePAPR "stdout-path" property Grant Likely
[not found] ` <1396022885-6102-2-git-send-email-grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-03-28 21:33 ` Benjamin Herrenschmidt
2014-03-28 21:56 ` Rob Herring
2014-03-29 21:16 ` Benjamin Herrenschmidt
2014-03-29 0:30 ` Grant Likely
2014-03-28 16:08 ` [RFC 2/5] of: Create of_console_check() for selecting a console specified in /chosen Grant Likely
[not found] ` <1396022885-6102-3-git-send-email-grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-03-28 18:38 ` Olof Johansson
2014-03-28 16:08 ` Grant Likely [this message]
[not found] ` <1396022885-6102-1-git-send-email-grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-03-28 16:08 ` [RFC 4/5] arm/versatile: Add the uart as the stdout device Grant Likely
2014-03-28 18:56 ` [RFC 0/5] of: Automatic console registration cleanups Olof Johansson
[not found] ` <20140328185653.GB26433-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2014-03-28 19:19 ` Rob Herring
[not found] ` <CAL_JsqKFO+OSz83f=XdyKgCqByUvHe7qLzgn5QLU1x1V1A5Fng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-28 20:58 ` Christoffer Dall
2014-03-28 23:50 ` Grant Likely
2014-03-28 23:53 ` Grant Likely
2014-06-12 1:28 ` Rob Herring
2014-06-12 10:12 ` Grant Likely
2014-03-28 16:08 ` [RFC 5/5] tty: Update hypervisor tty drivers to use core stdout parsing code Grant Likely
2014-03-28 18:54 ` Olof Johansson
[not found] ` < 1396022885-6102-6-git-send-email-grant.likely@linaro.org>
[not found] ` <20140328185443. GA26433@quad.lixom.net>
[not found] ` <20140328185443.GA26433-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2014-03-28 21:41 ` Grant Likely
[not found] ` < 1396022885-6102-2-git-send-email-grant.likely@linaro.org>
[not found] ` <1396042396.11529 .27.camel@pasglop>
[not found] ` <CAL_Jsq+xTeocLtS9GFWLCkoV+USACma+w0=O_ysekvTGhYVhZg@ mail.gmail.com>
[not found] ` <CAL_Jsq+xTeocLtS9GFWLCkoV+USACma+w0=O_ysekvTGhYVhZg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-29 0:32 ` [RFC 1/5] of: Add support for ePAPR "stdout-path" property Grant Likely
2014-03-31 7:10 ` [RFC 0/5] of: Automatic console registration cleanups Sascha Hauer
2014-03-31 9:41 ` Grant Likely
2014-04-01 6:12 ` Sascha Hauer
2014-04-01 9:08 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396022885-6102-4-git-send-email-grant.likely@linaro.org \
--to=grant.likely@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=christoffer.dall@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rob.herring@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).