From: Thor Thayer - Sendmail <tthayer@altera.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: dinguyen@altera.com, rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, devicetree@hellion.org.uk,
galak@codeaurora.org, rob@landley.net, linux@arm.linux.org.uk,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] arm: socfpga: Add support for Altera SoC SDRAM controller
Date: Tue, 1 Apr 2014 15:05:12 -0500 [thread overview]
Message-ID: <1396382712.20336.2.camel@dinh-ubuntu> (raw)
In-Reply-To: <20140401053343.GO5052@pengutronix.de>
On Tue, 2014-04-01 at 07:33 +0200, Steffen Trumtrar wrote:
> On Mon, Mar 31, 2014 at 05:07:07PM -0500, tthayer@altera.com wrote:
> > From: Thor Thayer <tthayer@altera.com>
> >
<snip>
> >
>
> Can't we get rid of all these global pointers instead of adding to them?
Yes. I will remove this file from the patch. Thanks.
>
> > @@ -150,6 +151,15 @@ void __init socfpga_sysmgr_init(void)
> >
> > np = of_find_compatible_node(NULL, NULL, "altr,clk-mgr");
> > clk_mgr_base_addr = of_iomap(np, 0);
> > +
> > + np = of_find_compatible_node(NULL, NULL, "altr,sdr-ctl");
> > + if (!np) {
> > + pr_err("SOCFPGA: Unable to find sdr-ctl\n");
> > + return;
> > + }
> > +
> > + sdr_ctl_base_addr = of_iomap(np, 0);
> > + WARN_ON(!sdr_ctl_base_addr);
> > }
> >
> > static void __init socfpga_init_irq(void)
> > --
> > 1.7.9.5
> >
>
prev parent reply other threads:[~2014-04-01 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1396303627-29198-1-git-send-email-tthayer@altera.com>
2014-03-31 22:07 ` [PATCH 1/2] dts: socfpga: Add bindings for Altera SoC SDRAM controller tthayer
2014-04-01 5:28 ` Steffen Trumtrar
2014-04-01 20:11 ` Thor Thayer - Sendmail
2014-04-01 22:19 ` Steffen Trumtrar
[not found] ` <20140401221913.GR5052-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-04-02 18:17 ` Thor Thayer - Sendmail
2014-03-31 22:07 ` [PATCH 2/2] arm: socfpga: Add support " tthayer
2014-04-01 5:33 ` Steffen Trumtrar
2014-04-01 20:05 ` Thor Thayer - Sendmail [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396382712.20336.2.camel@dinh-ubuntu \
--to=tthayer@altera.com \
--cc=devicetree@hellion.org.uk \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).