devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] ARM: dts: keystone: i2c updates
@ 2014-04-08 11:46 Grygorii Strashko
       [not found] ` <1396957567-14540-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Grygorii Strashko @ 2014-04-08 11:46 UTC (permalink / raw)
  To: santosh.shilimkar-l0cyMroinI0
  Cc: ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Grygorii Strashko

Hi Santosh,

There are two small non critical fixes for Keystone 2 I2C DT definitions.

Changes in v2;
- added additional patch to move i2c0 device node from SoC to board files
- updated commits messages

Grygorii Strashko (2):
  ARM: dts: keystone: add cell's information to i2c nodes
  ARM: dts: keystone: move i2c0 device node from SoC to board files

 arch/arm/boot/dts/k2e-evm.dts   |    7 +++++++
 arch/arm/boot/dts/k2hk-evm.dts  |    7 +++++++
 arch/arm/boot/dts/k2l-evm.dts   |    7 +++++++
 arch/arm/boot/dts/keystone.dtsi |    9 ++++-----
 4 files changed, 25 insertions(+), 5 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] ARM: dts: keystone: add cell's information to i2c nodes
       [not found] ` <1396957567-14540-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
@ 2014-04-08 11:46   ` Grygorii Strashko
  2014-04-08 11:46   ` [PATCH v2 2/2] ARM: dts: keystone: move i2c0 device node from SoC to board files Grygorii Strashko
  2014-04-08 13:16   ` [PATCH v2 0/2] ARM: dts: keystone: i2c updates Santosh Shilimkar
  2 siblings, 0 replies; 4+ messages in thread
From: Grygorii Strashko @ 2014-04-08 11:46 UTC (permalink / raw)
  To: santosh.shilimkar-l0cyMroinI0
  Cc: ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Grygorii Strashko

I2C nodes should always have #address-cells and #size-cells defined,
otherwise warnings will be produced in case of adding child
nodes to the I2C bus in DT:
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/i2c@2530800/pca@20
Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/i2c@2530800/pca@20

Hence, ensure that all i2cX nodes have #address-cells and #size-cells
properties defined.

Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
---
 arch/arm/boot/dts/keystone.dtsi |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 90823eb..f730392 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -115,6 +115,8 @@
 			clock-frequency = <100000>;
 			clocks = <&clki2c>;
 			interrupts = <GIC_SPI 286 IRQ_TYPE_EDGE_RISING>;
+			#address-cells = <1>;
+			#size-cells = <0>;
 		};
 
 		i2c2: i2c@2530800 {
@@ -123,6 +125,8 @@
 			clock-frequency = <100000>;
 			clocks = <&clki2c>;
 			interrupts = <GIC_SPI 289 IRQ_TYPE_EDGE_RISING>;
+			#address-cells = <1>;
+			#size-cells = <0>;
 		};
 
 		spi0: spi@21000400 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] ARM: dts: keystone: move i2c0 device node from SoC to board files
       [not found] ` <1396957567-14540-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
  2014-04-08 11:46   ` [PATCH v2 1/2] ARM: dts: keystone: add cell's information to i2c nodes Grygorii Strashko
@ 2014-04-08 11:46   ` Grygorii Strashko
  2014-04-08 13:16   ` [PATCH v2 0/2] ARM: dts: keystone: i2c updates Santosh Shilimkar
  2 siblings, 0 replies; 4+ messages in thread
From: Grygorii Strashko @ 2014-04-08 11:46 UTC (permalink / raw)
  To: santosh.shilimkar-l0cyMroinI0
  Cc: ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Grygorii Strashko

I2C devices are not the part of Keystone SoC and have to be
defined in board DTS files.
Hence, move i2c0 EEPROM device node from Keystone SoC to
k2hk, k2e, k2l EVM files as they all have similar EEPROM SoCs
installed.

Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
---
 arch/arm/boot/dts/k2e-evm.dts   |    7 +++++++
 arch/arm/boot/dts/k2hk-evm.dts  |    7 +++++++
 arch/arm/boot/dts/k2l-evm.dts   |    7 +++++++
 arch/arm/boot/dts/keystone.dtsi |    5 -----
 4 files changed, 21 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/k2e-evm.dts b/arch/arm/boot/dts/k2e-evm.dts
index 74b3b63..d60ce34 100644
--- a/arch/arm/boot/dts/k2e-evm.dts
+++ b/arch/arm/boot/dts/k2e-evm.dts
@@ -58,3 +58,10 @@
 &usb1 {
 	status = "okay";
 };
+
+&i2c0 {
+	dtt@50 {
+		compatible = "at,24c1024";
+		reg = <0x50>;
+	};
+};
diff --git a/arch/arm/boot/dts/k2hk-evm.dts b/arch/arm/boot/dts/k2hk-evm.dts
index c93d06f..d2aa102 100644
--- a/arch/arm/boot/dts/k2hk-evm.dts
+++ b/arch/arm/boot/dts/k2hk-evm.dts
@@ -138,3 +138,10 @@
 		};
 	};
 };
+
+&i2c0 {
+	dtt@50 {
+		compatible = "at,24c1024";
+		reg = <0x50>;
+	};
+};
diff --git a/arch/arm/boot/dts/k2l-evm.dts b/arch/arm/boot/dts/k2l-evm.dts
index 50a7013..bdc94a0 100644
--- a/arch/arm/boot/dts/k2l-evm.dts
+++ b/arch/arm/boot/dts/k2l-evm.dts
@@ -35,3 +35,10 @@
 &usb {
 	status = "okay";
 };
+
+&i2c0 {
+	dtt@50 {
+		compatible = "at,24c1024";
+		reg = <0x50>;
+	};
+};
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index f730392..7563934 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -102,11 +102,6 @@
 			interrupts = <GIC_SPI 283 IRQ_TYPE_EDGE_RISING>;
 			#address-cells = <1>;
 			#size-cells = <0>;
-
-			dtt@50 {
-				compatible = "at,24c1024";
-				reg = <0x50>;
-			};
 		};
 
 		i2c1: i2c@2530400 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/2] ARM: dts: keystone: i2c updates
       [not found] ` <1396957567-14540-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
  2014-04-08 11:46   ` [PATCH v2 1/2] ARM: dts: keystone: add cell's information to i2c nodes Grygorii Strashko
  2014-04-08 11:46   ` [PATCH v2 2/2] ARM: dts: keystone: move i2c0 device node from SoC to board files Grygorii Strashko
@ 2014-04-08 13:16   ` Santosh Shilimkar
  2 siblings, 0 replies; 4+ messages in thread
From: Santosh Shilimkar @ 2014-04-08 13:16 UTC (permalink / raw)
  To: Strashko, Grygorii
  Cc: ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org

On Tuesday 08 April 2014 07:46 AM, Strashko, Grygorii wrote:
> Hi Santosh,
> 
> There are two small non critical fixes for Keystone 2 I2C DT definitions.
> 
> Changes in v2;
> - added additional patch to move i2c0 device node from SoC to board files
> - updated commits messages
> 
Thanks. I shall pick these up for 3.16.

Regards,
Santosh

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-04-08 13:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-08 11:46 [PATCH v2 0/2] ARM: dts: keystone: i2c updates Grygorii Strashko
     [not found] ` <1396957567-14540-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-04-08 11:46   ` [PATCH v2 1/2] ARM: dts: keystone: add cell's information to i2c nodes Grygorii Strashko
2014-04-08 11:46   ` [PATCH v2 2/2] ARM: dts: keystone: move i2c0 device node from SoC to board files Grygorii Strashko
2014-04-08 13:16   ` [PATCH v2 0/2] ARM: dts: keystone: i2c updates Santosh Shilimkar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).