Re: [PATCH 4/4] pinctrl: msm: Add definitions for the APQ8064 platform

["Ivan T. Ivanov" <iivanov@mm-sol.com>]

Hi,

On Mon, 2014-03-31 at 14:49 -0700, Bjorn Andersson wrote:
> This adds pinctrl definitions for the GPIO pins of the TLMM v2 block in the
> Qualcomm APQ8064 platform.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
>  drivers/pinctrl/Kconfig           |   8 +
>  drivers/pinctrl/Makefile          |   1 +
>  drivers/pinctrl/pinctrl-apq8064.c | 567 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 576 insertions(+)
>  create mode 100644 drivers/pinctrl/pinctrl-apq8064.c
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 32b6b49..526f1c6 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -222,6 +222,14 @@ config PINCTRL_MSM
>  	select PINCONF
>  	select GENERIC_PINCONF
>  
> +config PINCTRL_APQ8064
> +	tristate "Qualcomm APQ8064 pin controller driver"
> +	depends on GPIOLIB && OF
> +	select PINCTRL_MSM
> +	help
> +	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> +	  Qualcomm TLMM block found in the Qualcomm APQ8064 platform.

The comment is not directly related to this patch, but..
Should we start adding select PINCTRL in Qualcomm arches 
which support PINCTRL, otherwise there is no way to select 
desired implementation.

Regards,
Ivan