devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: [PATCH V3 19/19] mmc: mmci: Enforce max frequency configuration through DT
Date: Thu, 10 Apr 2014 14:21:02 +0200	[thread overview]
Message-ID: <1397132462-8005-20-git-send-email-ulf.hansson@linaro.org> (raw)
In-Reply-To: <1397132462-8005-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Remove the option to provide a maximum frequency as platform data,
enforce it through DT.

Signed-off-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 drivers/mmc/host/mmci.c   |    5 +----
 include/linux/amba/mmci.h |    4 ----
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 04cff5e..83f5e56 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -1478,13 +1478,10 @@ static int mmci_probe(struct amba_device *dev,
 	 * If no maximum operating frequency is supplied, fall back to use
 	 * the module parameter, which has a (low) default value in case it
 	 * is not specified. Either value must not exceed the clock rate into
-	 * the block, of course. Also note that DT takes precedence over
-	 * platform data.
+	 * the block, of course.
 	 */
 	if (mmc->f_max)
 		mmc->f_max = min(host->mclk, mmc->f_max);
-	else if (plat->f_max)
-		mmc->f_max = min(host->mclk, plat->f_max);
 	else
 		mmc->f_max = min(host->mclk, fmax);
 	dev_dbg(mmc_dev(mmc), "clocking block at %u Hz\n", mmc->f_max);
diff --git a/include/linux/amba/mmci.h b/include/linux/amba/mmci.h
index bf339ff..8c98113 100644
--- a/include/linux/amba/mmci.h
+++ b/include/linux/amba/mmci.h
@@ -9,9 +9,6 @@
 /**
  * struct mmci_platform_data - platform configuration for the MMCI
  * (also known as PL180) block.
- * @f_max: the maximum operational frequency for this host in this
- * platform configuration. When this is specified it takes precedence
- * over the module parameter for the same frequency.
  * @ocr_mask: available voltages on the 4 pins from the block, this
  * is ignored if a regulator is used, see the MMC_VDD_* masks in
  * mmc/host.h
@@ -28,7 +25,6 @@
  * @cd_invert: true if the gpio_cd pin value is active low
  */
 struct mmci_platform_data {
-	unsigned int f_max;
 	unsigned int ocr_mask;
 	int (*ios_handler)(struct device *, struct mmc_ios *);
 	unsigned int (*status)(struct device *);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-04-10 12:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 12:20 [PATCH V3 00/19] mmc: mmci: Improve DT support Ulf Hansson
     [not found] ` <1397132462-8005-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-04-10 12:20   ` [PATCH V3 01/19] mmc: mmci: Convert to the mmc gpio API Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 02/19] mmc: mmci: Convert to devm functions Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 03/19] mmc: mmci: Update DT documentation Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 04/19] mmc: mmci: Add DT bindings for signal direction Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 05/19] mmc: mmci: Add DT bindings for feedback clock pin Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 06/19] mmc: mmci: Use the common mmc DT parser Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 07/19] ARM: ux500: Add mmci signal directions and feeback clock in DT for href Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 08/19] ARM: ux500: Convert to the common mmc DT bindings for highspeed mode Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 09/19] ARM: nomadik: " Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 10/19] ARM: u300: " Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 11/19] mmc: mmci: Mark the DT bindings for highspeed mode as deprecated Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 12/19] mmc: mmci: Enable MMC_CAP_CMD23 Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 13/19] ARM: ux500: Add the mmc capabilities flags to DT Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 14/19] ARM: ux500: Add a vmmc regulator through DT for the poped eMMC for href Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 15/19] ARM: ux500: Remove redundant board file for mmci platform data Ulf Hansson
2014-04-10 12:20   ` [PATCH V3 16/19] mmc: mmci: Enforce DT for signal direction and feedback clock Ulf Hansson
2014-04-10 12:21   ` [PATCH V3 17/19] mmc: mmci: Enforce mmc capabilities through DT Ulf Hansson
2014-04-10 12:21   ` [PATCH V3 18/19] mmc: mmci: Enforce DMA configuration " Ulf Hansson
     [not found]     ` <1397132462-8005-19-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-05-20  4:24       ` Ulf Hansson
2014-04-10 12:21   ` Ulf Hansson [this message]
2014-04-10 12:26   ` [PATCH V3 00/19] mmc: mmci: Improve DT support Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397132462-8005-20-git-send-email-ulf.hansson@linaro.org \
    --to=ulf.hansson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).