From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH 1/2] ARM: dt-binding: fix GIC example Date: Fri, 11 Apr 2014 15:23:49 +0200 Message-ID: <1397222629.4577.7.camel@weser.hi.pengutronix.de> References: <1396023951-32383-1-git-send-email-l.stach@pengutronix.de> <1397211012.4577.5.camel@weser.hi.pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ian Campbell , Tim Harvey , Rob Herring , "kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , Shawn Guo , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring: > On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach wrote: > > Hi Rob, > > > > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring: > >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach wrote: > >> > From: Tim Harvey > >> > > >> > When using interrupt-maps, the size of a map entry is #address-cells + > >> > >> Plus what? You mean ", and "? > >> > > Urgh, I obviously messed this up while editing the commit message in the > > last minute. It should have been something along the lines of: > > > > When using interrupt-maps, the size of a map entry is #address-cells + > > #interrupt-cells. address-cells should be 0 as this offset is not used > > in the GIC. > > > > As #address-cells = <0> is the same as not specifying the > > property, simply remove it. > > > > Can you edit this while applying, or should I send a new patch? > > I'll fix it up and apply. > Thanks. > > > >> > address-cells should be 0 as this is not used. > >> > > >> > As #address-cells = <0> is the same as not specifying the > >> > property, simply remove it. > >> > > >> > Signed-off-by: Tim Harvey > >> > Signed-off-by: Lucas Stach > >> > >> Did this get applied? I can't seem to find patch 2. > >> > > As Shawn pointed out patch 2 got applied through the imx tree as it > > fixes a real bug there. > > It was highlighted that other instances beyond iMX were wrong. Please > fix those as well. Oh, I wasn't aware of that. Will send patches. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html