[PATCH 1/2] ARM: dt-binding: fix GIC example

[PATCH 1/2] ARM: dt-binding: fix GIC example

[Lucas Stach]

From: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>

When using interrupt-maps, the size of a map entry is #address-cells +
address-cells should be 0 as this is not used.

As #address-cells = <0> is the same as not specifying the
property, simply remove it.

Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
v2 lst:
- completely remove the property
---
 Documentation/devicetree/bindings/arm/gic.txt | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/gic.txt b/Documentation/devicetree/bindings/arm/gic.txt
index bae0d87a38b2..42ab3b28a266 100644
--- a/Documentation/devicetree/bindings/arm/gic.txt
+++ b/Documentation/devicetree/bindings/arm/gic.txt
@@ -55,7 +55,6 @@ Example:
 	intc: interrupt-controller@fff11000 {
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
-		#address-cells = <1>;
 		interrupt-controller;
 		reg = <0xfff11000 0x1000>,
 		      <0xfff10100 0x100>;
-- 
1.9.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: dts: imx: drop invalid size and address cells properties

[Lucas Stach]

Those two properties should have been set to zero, which
is the same as not specifying them.

Having address-cells set to 1 causes OF interrupt
mapping routines to add 1 to the interrupt-cells
property and as result fail because all calculations
are off by one.

Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 2 --
 arch/arm/boot/dts/imx6sl.dtsi  | 2 --
 2 files changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index fb28b2ecb1db..31bd844798a7 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -38,8 +38,6 @@
 	intc: interrupt-controller@00a01000 {
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 		interrupt-controller;
 		reg = <0x00a01000 0x1000>,
 		      <0x00a00100 0x100>;
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 28558f1aaf2d..276425089ea0 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -44,8 +44,6 @@
 	intc: interrupt-controller@00a01000 {
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 		interrupt-controller;
 		reg = <0x00a01000 0x1000>,
 		      <0x00a00100 0x100>;
-- 
1.9.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ARM: dts: imx: drop invalid size and address cells properties

[Shawn Guo]

On Fri, Mar 28, 2014 at 05:25:51PM +0100, Lucas Stach wrote:
> Those two properties should have been set to zero, which
> is the same as not specifying them.
> 
> Having address-cells set to 1 causes OF interrupt
> mapping routines to add 1 to the interrupt-cells
> property and as result fail because all calculations
> are off by one.
> 
> Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dt-binding: fix GIC example

[Rob Herring]

On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> From: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
>
> When using interrupt-maps, the size of a map entry is #address-cells +

Plus what? You mean ", and "?

> address-cells should be 0 as this is not used.
>
> As #address-cells = <0> is the same as not specifying the
> property, simply remove it.
>
> Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
> Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Did this get applied? I can't seem to find patch 2.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dt-binding: fix GIC example

[Shawn Guo]

On Thu, Apr 10, 2014 at 10:21:35AM -0500, Rob Herring wrote:
> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> > From: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
> >
> > When using interrupt-maps, the size of a map entry is #address-cells +
> 
> Plus what? You mean ", and "?
> 
> > address-cells should be 0 as this is not used.
> >
> > As #address-cells = <0> is the same as not specifying the
> > property, simply remove it.
> >
> > Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
> > Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> 
> Did this get applied? I can't seem to find patch 2.

No.  We expect this patch to be applied on DT tree, while the
patch #2 [1] is going through IMX tree.

Shawn

[1] http://www.spinics.net/lists/arm-kernel/msg318810.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dt-binding: fix GIC example

[Lucas Stach]

Hi Rob,

Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring:
> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> > From: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
> >
> > When using interrupt-maps, the size of a map entry is #address-cells +
> 
> Plus what? You mean ", and "?
> 
Urgh, I obviously messed this up while editing the commit message in the
last minute. It should have been something along the lines of:

When using interrupt-maps, the size of a map entry is #address-cells +
#interrupt-cells. address-cells should be 0 as this offset is not used
in the GIC.

As #address-cells = <0> is the same as not specifying the
property, simply remove it.

Can you edit this while applying, or should I send a new patch?

> > address-cells should be 0 as this is not used.
> >
> > As #address-cells = <0> is the same as not specifying the
> > property, simply remove it.
> >
> > Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
> > Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> 
> Did this get applied? I can't seem to find patch 2.
> 
As Shawn pointed out patch 2 got applied through the imx tree as it
fixes a real bug there.

Regards,
Lucas
-- 
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dt-binding: fix GIC example

[Rob Herring]

On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> Hi Rob,
>
> Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring:
>> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
>> > From: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
>> >
>> > When using interrupt-maps, the size of a map entry is #address-cells +
>>
>> Plus what? You mean ", and "?
>>
> Urgh, I obviously messed this up while editing the commit message in the
> last minute. It should have been something along the lines of:
>
> When using interrupt-maps, the size of a map entry is #address-cells +
> #interrupt-cells. address-cells should be 0 as this offset is not used
> in the GIC.
>
> As #address-cells = <0> is the same as not specifying the
> property, simply remove it.
>
> Can you edit this while applying, or should I send a new patch?

I'll fix it up and apply.

>
>> > address-cells should be 0 as this is not used.
>> >
>> > As #address-cells = <0> is the same as not specifying the
>> > property, simply remove it.
>> >
>> > Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
>> > Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>>
>> Did this get applied? I can't seem to find patch 2.
>>
> As Shawn pointed out patch 2 got applied through the imx tree as it
> fixes a real bug there.

It was highlighted that other instances beyond iMX were wrong. Please
fix those as well.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dt-binding: fix GIC example

[Lucas Stach]

Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring:
> On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> > Hi Rob,
> >
> > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring:
> >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> >> > From: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
> >> >
> >> > When using interrupt-maps, the size of a map entry is #address-cells +
> >>
> >> Plus what? You mean ", and "?
> >>
> > Urgh, I obviously messed this up while editing the commit message in the
> > last minute. It should have been something along the lines of:
> >
> > When using interrupt-maps, the size of a map entry is #address-cells +
> > #interrupt-cells. address-cells should be 0 as this offset is not used
> > in the GIC.
> >
> > As #address-cells = <0> is the same as not specifying the
> > property, simply remove it.
> >
> > Can you edit this while applying, or should I send a new patch?
> 
> I'll fix it up and apply.
> 
Thanks.

> >
> >> > address-cells should be 0 as this is not used.
> >> >
> >> > As #address-cells = <0> is the same as not specifying the
> >> > property, simply remove it.
> >> >
> >> > Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
> >> > Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> >>
> >> Did this get applied? I can't seem to find patch 2.
> >>
> > As Shawn pointed out patch 2 got applied through the imx tree as it
> > fixes a real bug there.
> 
> It was highlighted that other instances beyond iMX were wrong. Please
> fix those as well.

Oh, I wasn't aware of that. Will send patches.

Regards,
Lucas

-- 
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dt-binding: fix GIC example

[Rob Herring]

On Fri, Apr 11, 2014 at 8:23 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring:
>> On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
>> > Hi Rob,
>> >
>> > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring:
>> >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
>> >> > From: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
>> >> >
>> >> > When using interrupt-maps, the size of a map entry is #address-cells +
>> >>
>> >> Plus what? You mean ", and "?
>> >>
>> > Urgh, I obviously messed this up while editing the commit message in the
>> > last minute. It should have been something along the lines of:
>> >
>> > When using interrupt-maps, the size of a map entry is #address-cells +
>> > #interrupt-cells. address-cells should be 0 as this offset is not used
>> > in the GIC.
>> >
>> > As #address-cells = <0> is the same as not specifying the
>> > property, simply remove it.
>> >
>> > Can you edit this while applying, or should I send a new patch?
>>
>> I'll fix it up and apply.
>>
> Thanks.
>
>> >
>> >> > address-cells should be 0 as this is not used.
>> >> >
>> >> > As #address-cells = <0> is the same as not specifying the
>> >> > property, simply remove it.
>> >> >
>> >> > Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
>> >> > Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> >>
>> >> Did this get applied? I can't seem to find patch 2.
>> >>
>> > As Shawn pointed out patch 2 got applied through the imx tree as it
>> > fixes a real bug there.
>>
>> It was highlighted that other instances beyond iMX were wrong. Please
>> fix those as well.
>
> Oh, I wasn't aware of that. Will send patches.

It was raised here: http://www.spinics.net/lists/linux-pci/msg29768.html

Here's a somewhat accurate list:

$ git grep -A8 'arm,.*gic' origin/master  -- arch/arm/boot/dts | grep
'address.*1'
origin/master:arch/arm/boot/dts/ecx-2000.dts-
#address-cells = <1>;
origin/master:arch/arm/boot/dts/highbank.dts-
#address-cells = <1>;
origin/master:arch/arm/boot/dts/imx6qdl.dtsi-           #address-cells = <1>;
origin/master:arch/arm/boot/dts/imx6sl.dtsi-            #address-cells = <1>;
origin/master:arch/arm/boot/dts/keystone.dtsi-          #address-cells = <1>;
origin/master:arch/arm/boot/dts/r8a7740.dtsi-           #address-cells = <1>;
origin/master:arch/arm/boot/dts/sh73a0.dtsi-            #address-cells = <1>;
origin/master:arch/arm/boot/dts/socfpga.dtsi-           #address-cells = <1>;
origin/master:arch/arm/boot/dts/ste-dbx5x0.dtsi-
 #address-cells = <1>;
origin/master:arch/arm/boot/dts/vf610.dtsi-
 #address-cells = <1>;
origin/master:arch/arm/boot/dts/zynq-7000.dtsi-
#address-cells = <1>;

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html