From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tomasz Figa <t.figa@samsung.com>
Subject: Re: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11
Date: Tue, 15 Apr 2014 10:55:45 +0200 [thread overview]
Message-ID: <1397552145.29169.17.camel@AMDC1943> (raw)
In-Reply-To: <CAK9yfHwUwjMEXisi5Jf+nAkS7CLnAUt-REkekns9JrRTAGQ=WQ@mail.gmail.com>
On wto, 2014-04-15 at 14:02 +0530, Sachin Kamat wrote:
> On 15 April 2014 13:42, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> > On wto, 2014-04-15 at 13:26 +0530, Sachin Kamat wrote:
> >> On 15 April 2014 02:41, Mark Brown <broonie@kernel.org> wrote:
> >> > On Mon, Apr 14, 2014 at 10:09:09AM +0200, Krzysztof Kozlowski wrote:
> >> >
> >> >> - - s5m8767,pmic-ext-control-gpios: (optional) GPIO specifier for one
> >> >> + - samsung,ext-control-gpios: (optional) GPIO specifier for one
> >> >> GPIO controlling this regulator (enable/disable); This is
> >> >> valid only for buck9.
> >> >
> >> > This is an incompatible change. It's OK to deprecate the old property
> >> > but it's bad form to just remove it.
> >>
> >> I agree with Mark. Also, there is no need to make it generic.
> >
> > I thought it would be good to make it consistent and to reduce the
> > number of bindings with same meaning on similar drivers.
>
> How about making the other one use "s5m8767,pmic-ext-control-gpios"
> compatible instead of introducing a new one?
But then we would introduce semi-generic binding with a driver-specific
name.
Anyway more drivers seem to use this kind of binding (tps65090, max8952,
da9055, arizona) so maybe there is a point in making this generic?
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-04-15 8:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 8:09 [PATCH 0/4] regulator: s2mps11: Add external GPIO control for S2MPS14 Krzysztof Kozlowski
2014-04-14 8:09 ` [PATCH 1/4] regulator: s2mps11: Move DTS parsing code to separate function Krzysztof Kozlowski
2014-04-14 21:13 ` Mark Brown
2014-04-14 8:09 ` [PATCH 2/4] regulator: s2mps11: Add external GPIO control for S2MPS14 Krzysztof Kozlowski
2014-04-14 21:13 ` Mark Brown
2014-04-14 8:09 ` [PATCH 3/4] Documentation: regulator: s2mps11: Document external GPIO control Krzysztof Kozlowski
2014-04-14 21:13 ` Mark Brown
2014-04-14 8:09 ` [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11 Krzysztof Kozlowski
2014-04-14 21:11 ` Mark Brown
2014-04-15 7:56 ` Sachin Kamat
2014-04-15 8:12 ` Krzysztof Kozlowski
2014-04-15 8:32 ` Sachin Kamat
2014-04-15 8:55 ` Krzysztof Kozlowski [this message]
2014-04-15 9:51 ` Sachin Kamat
2014-04-18 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397552145.29169.17.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).