* [PATCH] arm/dts: am335x-evmsk enable display and lcd panel support
@ 2014-04-22 20:37 Darren Etheridge
2014-05-06 16:10 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Darren Etheridge @ 2014-04-22 20:37 UTC (permalink / raw)
To: bcousson, tony; +Cc: linux-omap, devicetree, Darren Etheridge
Add the necessary nodes to enable the LCD controller and the
LCD panel that is attached to the Texas Instruments AM335x
EVMSK platform. Also setup the necessary pin mux within the
DT file to drive the LCD connector and add the correct
pinmux settings for the lcd pins to be configured to when
the SoC goes into sleep state for the minimum power
consumption.
For the sleep mode LCD pin settings, MUX_MODE7 is chosen as
this corresponds to switching the pins into input GPIO's with
an internal pulldown. Which has been determined to offer the
lowest power solution vs leaving the pins configured in LCD
mode.
Signed-off-by: Darren Etheridge <detheridge@ti.com>
---
arch/arm/boot/dts/am335x-evmsk.dts | 105 +++++++++++++++++++++++++++++++++++++
1 file changed, 105 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index ec08f6f..a5e1ab8 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -138,12 +138,113 @@
"Headphone Jack", "HPLOUT",
"Headphone Jack", "HPROUT";
};
+
+ panel {
+ compatible = "ti,tilcdc,panel";
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&lcd_pins_default>;
+ pinctrl-1 = <&lcd_pins_sleep>;
+ status = "okay";
+ panel-info {
+ ac-bias = <255>;
+ ac-bias-intrpt = <0>;
+ dma-burst-sz = <16>;
+ bpp = <32>;
+ fdd = <0x80>;
+ sync-edge = <0>;
+ sync-ctrl = <1>;
+ raster-order = <0>;
+ fifo-th = <0>;
+ };
+ display-timings {
+ 480x272 {
+ hactive = <480>;
+ vactive = <272>;
+ hback-porch = <43>;
+ hfront-porch = <8>;
+ hsync-len = <4>;
+ vback-porch = <12>;
+ vfront-porch = <4>;
+ vsync-len = <10>;
+ clock-frequency = <9000000>;
+ hsync-active = <0>;
+ vsync-active = <0>;
+ };
+ };
+ };
};
&am33xx_pinmux {
pinctrl-names = "default";
pinctrl-0 = <&gpio_keys_s0 &clkout2_pin>;
+ lcd_pins_default: lcd_pins_default {
+ pinctrl-single,pins = <
+ 0x20 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad8.lcd_data16 */
+ 0x24 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad9.lcd_data17 */
+ 0x28 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad10.lcd_data18 */
+ 0x2c (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad11.lcd_data19 */
+ 0x30 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad12.lcd_data20 */
+ 0x34 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad13.lcd_data21 */
+ 0x38 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad14.lcd_data22 */
+ 0x3c (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad15.lcd_data23 */
+ 0xa0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data0.lcd_data0 */
+ 0xa4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data1.lcd_data1 */
+ 0xa8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data2.lcd_data2 */
+ 0xac (PIN_OUTPUT | MUX_MODE0) /* lcd_data3.lcd_data3 */
+ 0xb0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data4.lcd_data4 */
+ 0xb4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data5.lcd_data5 */
+ 0xb8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data6.lcd_data6 */
+ 0xbc (PIN_OUTPUT | MUX_MODE0) /* lcd_data7.lcd_data7 */
+ 0xc0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data8.lcd_data8 */
+ 0xc4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data9.lcd_data9 */
+ 0xc8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data10.lcd_data10 */
+ 0xcc (PIN_OUTPUT | MUX_MODE0) /* lcd_data11.lcd_data11 */
+ 0xd0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data12.lcd_data12 */
+ 0xd4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data13.lcd_data13 */
+ 0xd8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data14.lcd_data14 */
+ 0xdc (PIN_OUTPUT | MUX_MODE0) /* lcd_data15.lcd_data15 */
+ 0xe0 (PIN_OUTPUT | MUX_MODE0) /* lcd_vsync.lcd_vsync */
+ 0xe4 (PIN_OUTPUT | MUX_MODE0) /* lcd_hsync.lcd_hsync */
+ 0xe8 (PIN_OUTPUT | MUX_MODE0) /* lcd_pclk.lcd_pclk */
+ 0xec (PIN_OUTPUT | MUX_MODE0) /* lcd_ac_bias_en.lcd_ac_bias_en */
+ >;
+ };
+
+ lcd_pins_sleep: lcd_pins_sleep {
+ pinctrl-single,pins = <
+ 0x20 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad8.lcd_data16 */
+ 0x24 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad9.lcd_data17 */
+ 0x28 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad10.lcd_data18 */
+ 0x2c (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad11.lcd_data19 */
+ 0x30 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad12.lcd_data20 */
+ 0x34 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad13.lcd_data21 */
+ 0x38 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad14.lcd_data22 */
+ 0x3c (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad15.lcd_data23 */
+ 0xa0 (PULL_DISABLE | MUX_MODE7) /* lcd_data0.lcd_data0 */
+ 0xa4 (PULL_DISABLE | MUX_MODE7) /* lcd_data1.lcd_data1 */
+ 0xa8 (PULL_DISABLE | MUX_MODE7) /* lcd_data2.lcd_data2 */
+ 0xac (PULL_DISABLE | MUX_MODE7) /* lcd_data3.lcd_data3 */
+ 0xb0 (PULL_DISABLE | MUX_MODE7) /* lcd_data4.lcd_data4 */
+ 0xb4 (PULL_DISABLE | MUX_MODE7) /* lcd_data5.lcd_data5 */
+ 0xb8 (PULL_DISABLE | MUX_MODE7) /* lcd_data6.lcd_data6 */
+ 0xbc (PULL_DISABLE | MUX_MODE7) /* lcd_data7.lcd_data7 */
+ 0xc0 (PULL_DISABLE | MUX_MODE7) /* lcd_data8.lcd_data8 */
+ 0xc4 (PULL_DISABLE | MUX_MODE7) /* lcd_data9.lcd_data9 */
+ 0xc8 (PULL_DISABLE | MUX_MODE7) /* lcd_data10.lcd_data10 */
+ 0xcc (PULL_DISABLE | MUX_MODE7) /* lcd_data11.lcd_data11 */
+ 0xd0 (PULL_DISABLE | MUX_MODE7) /* lcd_data12.lcd_data12 */
+ 0xd4 (PULL_DISABLE | MUX_MODE7) /* lcd_data13.lcd_data13 */
+ 0xd8 (PULL_DISABLE | MUX_MODE7) /* lcd_data14.lcd_data14 */
+ 0xdc (PULL_DISABLE | MUX_MODE7) /* lcd_data15.lcd_data15 */
+ 0xe0 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* lcd_vsync.lcd_vsync */
+ 0xe4 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* lcd_hsync.lcd_hsync */
+ 0xe8 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* lcd_pclk.lcd_pclk */
+ 0xec (PIN_INPUT_PULLDOWN | MUX_MODE7) /* lcd_ac_bias_en.lcd_ac_bias_en */
+ >;
+ };
+
+
user_leds_s0: user_leds_s0 {
pinctrl-single,pins = <
0x10 (PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad4.gpio1_4 */
@@ -560,3 +661,7 @@
ti,wire-config = <0x00 0x11 0x22 0x33>;
};
};
+
+&lcdc {
+ status = "okay";
+};
--
1.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm/dts: am335x-evmsk enable display and lcd panel support
2014-04-22 20:37 [PATCH] arm/dts: am335x-evmsk enable display and lcd panel support Darren Etheridge
@ 2014-05-06 16:10 ` Tony Lindgren
2014-05-09 11:29 ` Tomi Valkeinen
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2014-05-06 16:10 UTC (permalink / raw)
To: Darren Etheridge; +Cc: bcousson, linux-omap, devicetree, Tomi Valkeinen
* Darren Etheridge <detheridge@ti.com> [140422 13:39]:
> Add the necessary nodes to enable the LCD controller and the
> LCD panel that is attached to the Texas Instruments AM335x
> EVMSK platform. Also setup the necessary pin mux within the
> DT file to drive the LCD connector and add the correct
> pinmux settings for the lcd pins to be configured to when
> the SoC goes into sleep state for the minimum power
> consumption.
>
> For the sleep mode LCD pin settings, MUX_MODE7 is chosen as
> this corresponds to switching the pins into input GPIO's with
> an internal pulldown. Which has been determined to offer the
> lowest power solution vs leaving the pins configured in LCD
> mode.
Probably best that Tomi queues all the panel .dts changes into
a separate immutable branch that I can merge too.
Tony
> Signed-off-by: Darren Etheridge <detheridge@ti.com>
> ---
> arch/arm/boot/dts/am335x-evmsk.dts | 105 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 105 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
> index ec08f6f..a5e1ab8 100644
> --- a/arch/arm/boot/dts/am335x-evmsk.dts
> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
> @@ -138,12 +138,113 @@
> "Headphone Jack", "HPLOUT",
> "Headphone Jack", "HPROUT";
> };
> +
> + panel {
> + compatible = "ti,tilcdc,panel";
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&lcd_pins_default>;
> + pinctrl-1 = <&lcd_pins_sleep>;
> + status = "okay";
> + panel-info {
> + ac-bias = <255>;
> + ac-bias-intrpt = <0>;
> + dma-burst-sz = <16>;
> + bpp = <32>;
> + fdd = <0x80>;
> + sync-edge = <0>;
> + sync-ctrl = <1>;
> + raster-order = <0>;
> + fifo-th = <0>;
> + };
> + display-timings {
> + 480x272 {
> + hactive = <480>;
> + vactive = <272>;
> + hback-porch = <43>;
> + hfront-porch = <8>;
> + hsync-len = <4>;
> + vback-porch = <12>;
> + vfront-porch = <4>;
> + vsync-len = <10>;
> + clock-frequency = <9000000>;
> + hsync-active = <0>;
> + vsync-active = <0>;
> + };
> + };
> + };
> };
>
> &am33xx_pinmux {
> pinctrl-names = "default";
> pinctrl-0 = <&gpio_keys_s0 &clkout2_pin>;
>
> + lcd_pins_default: lcd_pins_default {
> + pinctrl-single,pins = <
> + 0x20 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad8.lcd_data16 */
> + 0x24 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad9.lcd_data17 */
> + 0x28 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad10.lcd_data18 */
> + 0x2c (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad11.lcd_data19 */
> + 0x30 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad12.lcd_data20 */
> + 0x34 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad13.lcd_data21 */
> + 0x38 (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad14.lcd_data22 */
> + 0x3c (PIN_OUTPUT | MUX_MODE1) /* gpmc_ad15.lcd_data23 */
> + 0xa0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data0.lcd_data0 */
> + 0xa4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data1.lcd_data1 */
> + 0xa8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data2.lcd_data2 */
> + 0xac (PIN_OUTPUT | MUX_MODE0) /* lcd_data3.lcd_data3 */
> + 0xb0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data4.lcd_data4 */
> + 0xb4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data5.lcd_data5 */
> + 0xb8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data6.lcd_data6 */
> + 0xbc (PIN_OUTPUT | MUX_MODE0) /* lcd_data7.lcd_data7 */
> + 0xc0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data8.lcd_data8 */
> + 0xc4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data9.lcd_data9 */
> + 0xc8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data10.lcd_data10 */
> + 0xcc (PIN_OUTPUT | MUX_MODE0) /* lcd_data11.lcd_data11 */
> + 0xd0 (PIN_OUTPUT | MUX_MODE0) /* lcd_data12.lcd_data12 */
> + 0xd4 (PIN_OUTPUT | MUX_MODE0) /* lcd_data13.lcd_data13 */
> + 0xd8 (PIN_OUTPUT | MUX_MODE0) /* lcd_data14.lcd_data14 */
> + 0xdc (PIN_OUTPUT | MUX_MODE0) /* lcd_data15.lcd_data15 */
> + 0xe0 (PIN_OUTPUT | MUX_MODE0) /* lcd_vsync.lcd_vsync */
> + 0xe4 (PIN_OUTPUT | MUX_MODE0) /* lcd_hsync.lcd_hsync */
> + 0xe8 (PIN_OUTPUT | MUX_MODE0) /* lcd_pclk.lcd_pclk */
> + 0xec (PIN_OUTPUT | MUX_MODE0) /* lcd_ac_bias_en.lcd_ac_bias_en */
> + >;
> + };
> +
> + lcd_pins_sleep: lcd_pins_sleep {
> + pinctrl-single,pins = <
> + 0x20 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad8.lcd_data16 */
> + 0x24 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad9.lcd_data17 */
> + 0x28 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad10.lcd_data18 */
> + 0x2c (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad11.lcd_data19 */
> + 0x30 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad12.lcd_data20 */
> + 0x34 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad13.lcd_data21 */
> + 0x38 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad14.lcd_data22 */
> + 0x3c (PIN_INPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad15.lcd_data23 */
> + 0xa0 (PULL_DISABLE | MUX_MODE7) /* lcd_data0.lcd_data0 */
> + 0xa4 (PULL_DISABLE | MUX_MODE7) /* lcd_data1.lcd_data1 */
> + 0xa8 (PULL_DISABLE | MUX_MODE7) /* lcd_data2.lcd_data2 */
> + 0xac (PULL_DISABLE | MUX_MODE7) /* lcd_data3.lcd_data3 */
> + 0xb0 (PULL_DISABLE | MUX_MODE7) /* lcd_data4.lcd_data4 */
> + 0xb4 (PULL_DISABLE | MUX_MODE7) /* lcd_data5.lcd_data5 */
> + 0xb8 (PULL_DISABLE | MUX_MODE7) /* lcd_data6.lcd_data6 */
> + 0xbc (PULL_DISABLE | MUX_MODE7) /* lcd_data7.lcd_data7 */
> + 0xc0 (PULL_DISABLE | MUX_MODE7) /* lcd_data8.lcd_data8 */
> + 0xc4 (PULL_DISABLE | MUX_MODE7) /* lcd_data9.lcd_data9 */
> + 0xc8 (PULL_DISABLE | MUX_MODE7) /* lcd_data10.lcd_data10 */
> + 0xcc (PULL_DISABLE | MUX_MODE7) /* lcd_data11.lcd_data11 */
> + 0xd0 (PULL_DISABLE | MUX_MODE7) /* lcd_data12.lcd_data12 */
> + 0xd4 (PULL_DISABLE | MUX_MODE7) /* lcd_data13.lcd_data13 */
> + 0xd8 (PULL_DISABLE | MUX_MODE7) /* lcd_data14.lcd_data14 */
> + 0xdc (PULL_DISABLE | MUX_MODE7) /* lcd_data15.lcd_data15 */
> + 0xe0 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* lcd_vsync.lcd_vsync */
> + 0xe4 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* lcd_hsync.lcd_hsync */
> + 0xe8 (PIN_INPUT_PULLDOWN | MUX_MODE7) /* lcd_pclk.lcd_pclk */
> + 0xec (PIN_INPUT_PULLDOWN | MUX_MODE7) /* lcd_ac_bias_en.lcd_ac_bias_en */
> + >;
> + };
> +
> +
> user_leds_s0: user_leds_s0 {
> pinctrl-single,pins = <
> 0x10 (PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* gpmc_ad4.gpio1_4 */
> @@ -560,3 +661,7 @@
> ti,wire-config = <0x00 0x11 0x22 0x33>;
> };
> };
> +
> +&lcdc {
> + status = "okay";
> +};
> --
> 1.8.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm/dts: am335x-evmsk enable display and lcd panel support
2014-05-06 16:10 ` Tony Lindgren
@ 2014-05-09 11:29 ` Tomi Valkeinen
2014-05-09 14:47 ` Darren Etheridge
0 siblings, 1 reply; 5+ messages in thread
From: Tomi Valkeinen @ 2014-05-09 11:29 UTC (permalink / raw)
To: Tony Lindgren, Darren Etheridge; +Cc: bcousson, linux-omap, devicetree
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On 06/05/14 19:10, Tony Lindgren wrote:
> * Darren Etheridge <detheridge@ti.com> [140422 13:39]:
>> Add the necessary nodes to enable the LCD controller and the
>> LCD panel that is attached to the Texas Instruments AM335x
>> EVMSK platform. Also setup the necessary pin mux within the
>> DT file to drive the LCD connector and add the correct
>> pinmux settings for the lcd pins to be configured to when
>> the SoC goes into sleep state for the minimum power
>> consumption.
>>
>> For the sleep mode LCD pin settings, MUX_MODE7 is chosen as
>> this corresponds to switching the pins into input GPIO's with
>> an internal pulldown. Which has been determined to offer the
>> lowest power solution vs leaving the pins configured in LCD
>> mode.
>
> Probably best that Tomi queues all the panel .dts changes into
> a separate immutable branch that I can merge too.
This is not for OMAP DSS, but for the LCDC used in beaglebone, so there
are no dependencies to any of my work.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm/dts: am335x-evmsk enable display and lcd panel support
2014-05-09 11:29 ` Tomi Valkeinen
@ 2014-05-09 14:47 ` Darren Etheridge
2014-05-09 16:27 ` Darren Etheridge
0 siblings, 1 reply; 5+ messages in thread
From: Darren Etheridge @ 2014-05-09 14:47 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: Tony Lindgren, bcousson, linux-omap, devicetree
Tomi Valkeinen <tomi.valkeinen@ti.com> wrote on Fri [2014-May-09 14:29:02 +0300]:
> On 06/05/14 19:10, Tony Lindgren wrote:
> > * Darren Etheridge <detheridge@ti.com> [140422 13:39]:
> >> Add the necessary nodes to enable the LCD controller and the
> >> LCD panel that is attached to the Texas Instruments AM335x
> >> EVMSK platform. Also setup the necessary pin mux within the
> >> DT file to drive the LCD connector and add the correct
> >> pinmux settings for the lcd pins to be configured to when
> >> the SoC goes into sleep state for the minimum power
> >> consumption.
> >>
> >> For the sleep mode LCD pin settings, MUX_MODE7 is chosen as
> >> this corresponds to switching the pins into input GPIO's with
> >> an internal pulldown. Which has been determined to offer the
> >> lowest power solution vs leaving the pins configured in LCD
> >> mode.
> >
> > Probably best that Tomi queues all the panel .dts changes into
> > a separate immutable branch that I can merge too.
>
> This is not for OMAP DSS, but for the LCDC used in beaglebone, so there
> are no dependencies to any of my work.
>
Benoit had always queued these LCDC dts patches in the past. This is
exactly the same as what had been done for AM335x-EVM and
AM335x-BeagleBone both of which are already in the mainline kernel. I
had just missed the EVMSK previously.
Darren
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm/dts: am335x-evmsk enable display and lcd panel support
2014-05-09 14:47 ` Darren Etheridge
@ 2014-05-09 16:27 ` Darren Etheridge
0 siblings, 0 replies; 5+ messages in thread
From: Darren Etheridge @ 2014-05-09 16:27 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: Tony Lindgren, bcousson, linux-omap, devicetree
Darren Etheridge <detheridge@ti.com> wrote on Fri [2014-May-09 09:47:49 -0500]:
> Tomi Valkeinen <tomi.valkeinen@ti.com> wrote on Fri [2014-May-09 14:29:02 +0300]:
> > On 06/05/14 19:10, Tony Lindgren wrote:
> > > * Darren Etheridge <detheridge@ti.com> [140422 13:39]:
> > >> Add the necessary nodes to enable the LCD controller and the
> > >> LCD panel that is attached to the Texas Instruments AM335x
> > >> EVMSK platform. Also setup the necessary pin mux within the
> > >> DT file to drive the LCD connector and add the correct
> > >> pinmux settings for the lcd pins to be configured to when
> > >> the SoC goes into sleep state for the minimum power
> > >> consumption.
> > >>
> > >> For the sleep mode LCD pin settings, MUX_MODE7 is chosen as
> > >> this corresponds to switching the pins into input GPIO's with
> > >> an internal pulldown. Which has been determined to offer the
> > >> lowest power solution vs leaving the pins configured in LCD
> > >> mode.
> > >
> > > Probably best that Tomi queues all the panel .dts changes into
> > > a separate immutable branch that I can merge too.
> >
> > This is not for OMAP DSS, but for the LCDC used in beaglebone, so there
> > are no dependencies to any of my work.
> >
>
> Benoit had always queued these LCDC dts patches in the past. This is
> exactly the same as what had been done for AM335x-EVM and
> AM335x-BeagleBone both of which are already in the mainline kernel. I
> had just missed the EVMSK previously.
>
> Darren
>
There is a labeling mistake in this patch with the comments for LCD pins
16 through 23. I will correct it and send a V2.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-09 16:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-22 20:37 [PATCH] arm/dts: am335x-evmsk enable display and lcd panel support Darren Etheridge
2014-05-06 16:10 ` Tony Lindgren
2014-05-09 11:29 ` Tomi Valkeinen
2014-05-09 14:47 ` Darren Etheridge
2014-05-09 16:27 ` Darren Etheridge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).