devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt: bindings: dwc2: fix required value for the phy-names property
@ 2014-04-24 17:12 Matt Porter
  2014-05-28 16:17 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Porter @ 2014-04-24 17:12 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Pawel Moll, Ian Campbell, Kumar Gala
  Cc: Felipe Balbi, Greg Kroah-Hartman, Tomasz Figa, Paul Zimmerman,
	Devicetree List, Linux USB List, Linux Kernel Mailing List

"7408484 usb: gadget: s3c-hsotg: enable generic phy support" introduces
generic phy support to the dwc2.txt binding and the s3c-hsotg driver
which implements support for the binding. The binding documentation
incorrectly states that the phy-names property will be "device". The
binding example, driver, and one dts user all implement the phy-names
property as requiring "usb2-phy".

Fix the dwc2.txt binding documentation to correctly specify "usb2-phy"
as the appropriate value for phy-names.

Reported-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 Documentation/devicetree/bindings/usb/dwc2.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
index b8b6871..467ddd1 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.txt
+++ b/Documentation/devicetree/bindings/usb/dwc2.txt
@@ -13,7 +13,7 @@ Refer to clk/clock-bindings.txt for generic clock consumer properties
 
 Optional properties:
 - phys: phy provider specifier
-- phy-names: shall be "device"
+- phy-names: shall be "usb2-phy"
 Refer to phy/phy-bindings.txt for generic phy consumer properties
 
 Example:
-- 
1.8.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt: bindings: dwc2: fix required value for the phy-names property
  2014-04-24 17:12 [PATCH] dt: bindings: dwc2: fix required value for the phy-names property Matt Porter
@ 2014-05-28 16:17 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2014-05-28 16:17 UTC (permalink / raw)
  To: Matt Porter
  Cc: Rob Herring, Mark Rutland, Pawel Moll, Ian Campbell, Kumar Gala,
	Felipe Balbi, Greg Kroah-Hartman, Tomasz Figa, Paul Zimmerman,
	Devicetree List, Linux USB List, Linux Kernel Mailing List

On Thu, Apr 24, 2014 at 12:12 PM, Matt Porter <mporter@linaro.org> wrote:
> "7408484 usb: gadget: s3c-hsotg: enable generic phy support" introduces
> generic phy support to the dwc2.txt binding and the s3c-hsotg driver
> which implements support for the binding. The binding documentation
> incorrectly states that the phy-names property will be "device". The
> binding example, driver, and one dts user all implement the phy-names
> property as requiring "usb2-phy".
>
> Fix the dwc2.txt binding documentation to correctly specify "usb2-phy"
> as the appropriate value for phy-names.
>
> Reported-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Matt Porter <mporter@linaro.org>

Applied for 3.16.

Rob

> ---
>  Documentation/devicetree/bindings/usb/dwc2.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
> index b8b6871..467ddd1 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc2.txt
> @@ -13,7 +13,7 @@ Refer to clk/clock-bindings.txt for generic clock consumer properties
>
>  Optional properties:
>  - phys: phy provider specifier
> -- phy-names: shall be "device"
> +- phy-names: shall be "usb2-phy"
>  Refer to phy/phy-bindings.txt for generic phy consumer properties
>
>  Example:
> --
> 1.8.4
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-28 16:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-24 17:12 [PATCH] dt: bindings: dwc2: fix required value for the phy-names property Matt Porter
2014-05-28 16:17 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).