Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support

[Lucas Stach <l.stach@pengutronix.de>]

Am Donnerstag, den 24.04.2014, 11:58 -0600 schrieb Bjorn Helgaas:
> On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote:
> > While working on MSI support for the i.MX6 PCIe host driver
> > it has been discovered that the binding for this host controller
> > is broken in many ways (refer to the patch descriptions for more
> > info) and was introduced without proper discussion about what
> > should/should not be in the binding.
> > 
> > This series fixes this and minimizes the difference of the
> > i.MX6 binding to the common designware PCIe binding. I'm aware
> > that this is a quite radical change, but I think it's justified
> > to do this as long as there aren't many user of the old binding
> > (most of the optional properties in the binding aren't even
> > implemented).
> > 
> > Looking forward to your feedback.
> > 
> > Lucas Stach (8):
> >   ARM: imx6q-clk: parent lvds_gate from lvds_sel
This one is already applied.

> >   PCI: designware: split Exynos and i.MX bindings
> >   ARM: dts: imx6: update pcie to bring in line with new binding
> >   PCI: imx6: use new clock names
> >   PCI: imx6: drop old irq mapping
> >   PCI: imx6: rip out optional (and unused) irqs
> >   PCI: designware: make MSI isr shared irq aware
> >   PCI: imx6: add support for MSI
> 
> What's the status of all these?  I would normally apply patches 4-8 of this
> series through my tree, given the appropriate acks, but I haven't seen
> those yet.  And I'm not sure what dependencies there are between the
> non-PCI patches and the PCI ones.
> 
It's a complete binding change, so applying one part without the other
is going to horribly break things.

So I would at least want to see an ack for the binding change on the
i.MX side from Shawn and Richard. This will need some follow on patches,
as some boards adding PCIe using the old binding have cropped up in
linux-next, but I can do the patches on short notice if everyone agrees
to merge this patchset.

The designware part is pretty simple and doesn't change anything for
other users than i.MX. Though I would like to see an ack from Jingoo for
those.

I have some more stuff in the pipes regarding multiple MSI irqs, that
depend on this series and also the Keystone people are waiting for this
to be applied in order to consolidate the clock handling of the
designware core driver, so it would be nice to get this moving again.

Regards,
Lucas
-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |