From: Pawel Moll <pawel.moll@arm.com>
To: Christopher Covington <cov@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
lm-sensors@lm-sensors.org, arm@kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Jean Delvare <jdelvare@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] driver core & of: Mark of_nodes of added device as populated
Date: Mon, 28 Apr 2014 18:40:54 +0100 [thread overview]
Message-ID: <1398706854.20390.8.camel@hornet> (raw)
In-Reply-To: <52FA5EB4.7080008@codeaurora.org>
On Tue, 2014-02-11 at 12:32 -0500, Christopher Covington wrote:
> Hi Pawel,
>
> On 02/11/2014 11:53 AM, Pawel Moll wrote:
> > This patch tries to solve that issue in a generic way,
> > adding a "populated" flag which is set in the device_node
> > structure when a device is being created in the core.
> > Later, of_platform_populate() skips such nodes (and
> > its children) in a similar way to the non-available ones.
>
> Will there never be a case where it is useful for a parent node to be created
> early, but not necessarily the child nodes? Might only skipping nodes
> explicitly marked as populated be a more universal solution?
That's a good point. I've assumed one would either use
of_platform_device_create() on leaf nodes only (or
of_platform_populate() on subtree), and kept this approach in the
refreshed patch I'm about to post, but I'm happy to do what you
suggested.
Thanks!
Pawel
next prev parent reply other threads:[~2014-04-28 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 16:53 [PATCH 0/3] Versatile Express sysregs rework Pawel Moll
2014-02-11 16:53 ` [PATCH 1/3] driver core & of: Mark of_nodes of added device as populated Pawel Moll
2014-02-11 17:32 ` Christopher Covington
2014-04-28 17:40 ` Pawel Moll [this message]
[not found] ` <1392137610-27842-2-git-send-email-pawel.moll-5wv7dgnIgG8@public.gmane.org>
2014-02-13 19:15 ` Rob Herring
2014-04-28 17:37 ` Pawel Moll
2014-04-28 17:50 ` Pawel Moll
2014-02-11 16:53 ` [PATCH 2/3] mfd: vexpress: Convert custom func API to regmap Pawel Moll
2014-02-11 16:53 ` [PATCH 3/3] mfd: vexpress: Define the device as MFD cells Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398706854.20390.8.camel@hornet \
--to=pawel.moll@arm.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=cov@codeaurora.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jdelvare@suse.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).