devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Mike Turquette <mturquette@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Kumar Gala <galak@codeaurora.org>,
	Grant Likely <grant.likely@linaro.org>,
	Lee Jones <lee.jones@linaro.org>,
	lm-sensors@lm-sensors.org, "arm@kernel.org" <arm@kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Jean Delvare <jdelvare@suse.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] driver core & of: Mark of_nodes of added device as populated
Date: Mon, 28 Apr 2014 18:50:51 +0100	[thread overview]
Message-ID: <1398707451.20390.14.camel@hornet> (raw)
In-Reply-To: <1398706660.20390.5.camel@hornet>

On Mon, 2014-04-28 at 18:37 +0100, Pawel Moll wrote:
> On Thu, 2014-02-13 at 13:15 -0600, Rob Herring wrote:
> > On Tue, Feb 11, 2014 at 10:53 AM, Pawel Moll <pawel.moll@arm.com> wrote:
> > > In "Device Tree powered" systems, platform devices are usually
> > > massively populated with of_platform_populate() call, executed
> > > at some level of initcalls, either by generic architecture
> > > or by platform-specific code.
> >
> > Go read Grant's and my comments from your last posting.
> 
> Right, I can't explain why I missed those. Will do right now.

Actually I can't seem to find it in my mail archive, but I remember you
were saying that it shouldn't spoil into the driver base code. You're
probably right, so the updated patch will be limited to of_platform_*
API.

Grant was suggesting that I shouldn't be using the device model if I
have to initialize some early stuff. The thing is that my stuff is not
that early at all. The device model works for me perfectly, as long as I
can initialize 3 crucial devices in a correct order (and *then* do mass
population). And the init levels are perfect for this job. The only
thing I need is a small refinement in the way DT-based devices are
populated and this is exactly what I propose. Hope it makes more sense
now.

Cheers!

Pawel

  reply	other threads:[~2014-04-28 17:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 16:53 [PATCH 0/3] Versatile Express sysregs rework Pawel Moll
2014-02-11 16:53 ` [PATCH 1/3] driver core & of: Mark of_nodes of added device as populated Pawel Moll
2014-02-11 17:32   ` Christopher Covington
2014-04-28 17:40     ` Pawel Moll
     [not found]   ` <1392137610-27842-2-git-send-email-pawel.moll-5wv7dgnIgG8@public.gmane.org>
2014-02-13 19:15     ` Rob Herring
2014-04-28 17:37       ` Pawel Moll
2014-04-28 17:50         ` Pawel Moll [this message]
2014-02-11 16:53 ` [PATCH 2/3] mfd: vexpress: Convert custom func API to regmap Pawel Moll
2014-02-11 16:53 ` [PATCH 3/3] mfd: vexpress: Define the device as MFD cells Pawel Moll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398707451.20390.14.camel@hornet \
    --to=pawel.moll@arm.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jdelvare@suse.de \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).