devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org
Cc: tomi.valkeinen@ti.com
Subject: [PATCH 3/4] OMAPDSS: panel-sharp-ls037v7dw01: add device tree support
Date: Tue, 29 Apr 2014 16:52:41 -0700	[thread overview]
Message-ID: <1398815562-24113-4-git-send-email-tony@atomide.com> (raw)
In-Reply-To: <1398815562-24113-1-git-send-email-tony@atomide.com>

We can pass the GPIO configuration for ls037v7dw01 in a standard
gpios property.

Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 .../bindings/panel/sharp,ls037v7dw01.txt           | 53 ++++++++++++++
 .../omap2/displays-new/panel-sharp-ls037v7dw01.c   | 84 ++++++++++++++++++++--
 2 files changed, 133 insertions(+), 4 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/panel/sharp,ls037v7dw01.txt

diff --git a/Documentation/devicetree/bindings/panel/sharp,ls037v7dw01.txt b/Documentation/devicetree/bindings/panel/sharp,ls037v7dw01.txt
new file mode 100644
index 0000000..7f6f5e1
--- /dev/null
+++ b/Documentation/devicetree/bindings/panel/sharp,ls037v7dw01.txt
@@ -0,0 +1,53 @@
+SHARP LS037V7DW01 TFT-LCD panel
+
+Required properties:
+- compatible: should be "sharp,ls037v7dw01"
+
+Optional properties:
+- reset-gpios: a GPIO spec for the optional reset pin
+- enable-gpios: a GPIO array for the optional configuration GPIOs
+  ordered MO, LR, UD, INI as specified in the LS037V7DW01.pdf file.
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
+
+This panel can have zero to five GPIOs to configure
+to change configuration between QVGA and VGA mode
+and the scan direction. As these pins can be also
+configured with external pulls, all the GPIOs are
+considered optional with holes in the array.
+
+Example when connected to a omap2+ based device:
+
+	lcd0: display {
+		compatible = "sharp,ls037v7dw01";
+		power-supply = <&lcd_3v3>;
+		reset-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;	/* gpio155, lcd RESB */
+		enable-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH	/* gpio154, lcd MO */
+				&gpio1 2 GPIO_ACTIVE_HIGH	/* gpio2, lcd LR */
+				&gpio1 3 GPIO_ACTIVE_HIGH	/* gpio3, lcd UD */
+				&gpio5 24 GPIO_ACTIVE_HIGH>;	/* gpio152, lcd INI */
+
+		panel-timing {
+			clock-frequency = <19200000>;
+			hback-porch = <28>;
+			hactive = <480>;
+			hfront-porch = <1>;
+			hsync-len = <2>;
+			vback-porch = <1>;
+			vactive = <640>;
+			vfront-porch = <1>;
+			vsync-len = <1>;
+			hsync-active = <0>;
+			vsync-active = <0>;
+			de-active = <1>;
+			pixelclk-active = <1>;
+		};
+
+		port {
+			lcd_in: endpoint {
+				remote-endpoint = <&dpi_out>;
+			};
+		};
+	};
+
diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c b/drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c
index de8473a..3a04fb0 100644
--- a/drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c
+++ b/drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c
@@ -12,15 +12,19 @@
 #include <linux/delay.h>
 #include <linux/gpio.h>
 #include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_gpio.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
-
+#include <linux/regulator/consumer.h>
+#include <video/of_display_timing.h>
 #include <video/omapdss.h>
 #include <video/omap-panel-data.h>
 
 struct panel_drv_data {
 	struct omap_dss_device dssdev;
 	struct omap_dss_device *in;
+	struct regulator *vcc;
 
 	int data_lines;
 
@@ -95,7 +99,8 @@ static int sharp_ls_enable(struct omap_dss_device *dssdev)
 	if (omapdss_device_is_enabled(dssdev))
 		return 0;
 
-	in->ops.dpi->set_data_lines(in, ddata->data_lines);
+	if (ddata->data_lines)
+		in->ops.dpi->set_data_lines(in, ddata->data_lines);
 	in->ops.dpi->set_timings(in, &ddata->videomode);
 
 	r = in->ops.dpi->enable(in);
@@ -230,6 +235,67 @@ static int sharp_ls_probe_pdata(struct platform_device *pdev)
 	ddata->ini_gpio = sharp_ls_get_gpio(&pdev->dev, pdata->ini_gpio,
 					    GPIOF_OUT_INIT_LOW, "lcd INI");
 
+	ddata->videomode = sharp_ls_timings;
+
+	return 0;
+}
+
+static struct gpio_desc *
+sharp_ls_get_gpio_of(struct device *dev, int index, int val, char *desc)
+{
+	struct gpio_desc *gpio;
+
+	gpio = devm_gpiod_get_index(dev, desc, index);
+	if (!IS_ERR(gpio))
+		gpiod_direction_output(gpio, val);
+
+	return gpio;
+}
+
+static int sharp_ls_probe_of(struct platform_device *pdev)
+{
+	struct panel_drv_data *ddata = platform_get_drvdata(pdev);
+	struct device_node *node = pdev->dev.of_node;
+	struct omap_dss_device *in;
+	struct display_timing timing;
+	struct videomode vm;
+	int r;
+
+	ddata->vcc = devm_regulator_get(&pdev->dev, "envdd");
+	if (IS_ERR(ddata->vcc)) {
+		dev_err(&pdev->dev, "failed to get regulator\n");
+		return PTR_ERR(ddata->vcc);
+	}
+
+	r = regulator_enable(ddata->vcc);
+	if (r != 0) {
+		dev_err(&pdev->dev, "failed to enable regulator\n");
+		return r;
+	}
+
+	ddata->resb_gpio = sharp_ls_get_gpio_of(&pdev->dev, 0, 0, "reset");	/* lcd RESB */
+	ddata->mo_gpio = sharp_ls_get_gpio_of(&pdev->dev, 0, 0, "enable");	/* lcd MO */
+	ddata->lr_gpio = sharp_ls_get_gpio_of(&pdev->dev, 1, 1, "enable");	/* lcd LR */
+	ddata->ud_gpio = sharp_ls_get_gpio_of(&pdev->dev, 2, 1, "enable");	/* lcd UD */
+	ddata->ini_gpio = sharp_ls_get_gpio_of(&pdev->dev, 3, 0, "enable");	/* lcd INI */
+
+	r = of_get_display_timing(node, "panel-timing", &timing);
+	if (r) {
+		dev_err(&pdev->dev, "failed to get video timing\n");
+		return r;
+	}
+
+	videomode_from_timing(&timing, &vm);
+	videomode_to_omap_video_timings(&vm, &ddata->videomode);
+
+	in = omapdss_of_find_source_for_first_ep(node);
+	if (IS_ERR(in)) {
+		dev_err(&pdev->dev, "failed to find video source\n");
+		return PTR_ERR(in);
+	}
+
+	ddata->in = in;
+
 	return 0;
 }
 
@@ -249,12 +315,14 @@ static int sharp_ls_probe(struct platform_device *pdev)
 		r = sharp_ls_probe_pdata(pdev);
 		if (r)
 			return r;
+	} else if (pdev->dev.of_node) {
+		r = sharp_ls_probe_of(pdev);
+		if (r)
+			return r;
 	} else {
 		return -ENODEV;
 	}
 
-	ddata->videomode = sharp_ls_timings;
-
 	dssdev = &ddata->dssdev;
 	dssdev->dev = &pdev->dev;
 	dssdev->driver = &sharp_ls_ops;
@@ -292,12 +360,20 @@ static int __exit sharp_ls_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id sharp_ls_of_match[] = {
+	{ .compatible = "sharp,ls037v7dw01", },
+	{},
+};
+
+MODULE_DEVICE_TABLE(of, sharp_ls_of_match);
+
 static struct platform_driver sharp_ls_driver = {
 	.probe = sharp_ls_probe,
 	.remove = __exit_p(sharp_ls_remove),
 	.driver = {
 		.name = "panel-sharp-ls037v7dw01",
 		.owner = THIS_MODULE,
+		.of_match_table = sharp_ls_of_match,
 	},
 };
 
-- 
1.8.1.1


  parent reply	other threads:[~2014-04-29 23:52 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29 23:52 [PATCH 0/4] OMAPDSS: Add support for panel ls037v7dw01 Tony Lindgren
2014-04-29 23:52 ` [PATCH 1/4] OMAPDSS: Fix DSS clock multiplier issue on 3703 and probably 3630 Tony Lindgren
2014-05-08 23:20   ` Tony Lindgren
     [not found]     ` <20140508232006.GG2198-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-05-09  8:01       ` Tomi Valkeinen
2014-05-09 14:37         ` Tony Lindgren
2014-05-12 11:38           ` Tomi Valkeinen
2014-05-09  7:38   ` Tomi Valkeinen
2014-05-09 14:37     ` Tony Lindgren
2014-05-12 11:36       ` Tomi Valkeinen
2014-05-12 14:39         ` Tony Lindgren
2014-05-12 14:44           ` Tomi Valkeinen
2014-05-13 15:26             ` Tony Lindgren
2014-05-14  6:41               ` Tomi Valkeinen
2014-05-09 21:06     ` Andreas Müller
2014-05-11 14:42       ` Tony Lindgren
2014-05-12  8:20         ` Andreas Müller
2014-05-12 14:40           ` Tony Lindgren
2014-04-29 23:52 ` [PATCH 2/4] OMAPDSS: panel-sharp-ls037v7dw01: update to use gpiod Tony Lindgren
2014-05-07  8:15   ` Tomi Valkeinen
2014-05-08 23:25     ` Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren [this message]
2014-05-07  8:12   ` [PATCH 3/4] OMAPDSS: panel-sharp-ls037v7dw01: add device tree support Tomi Valkeinen
2014-05-07 15:03     ` Tony Lindgren
2014-05-07 16:02       ` Tomi Valkeinen
2014-05-07 17:59         ` Tony Lindgren
2014-05-08 23:33           ` Tony Lindgren
2014-05-09  7:24             ` Tomi Valkeinen
2014-05-09 15:55               ` Tony Lindgren
2014-05-12  7:38                 ` Tomi Valkeinen
2014-05-12  9:34                   ` Javier Martinez Canillas
2014-05-12  9:40                     ` Tomi Valkeinen
2014-05-12 10:00                       ` Javier Martinez Canillas
2014-05-12 14:26                         ` Tony Lindgren
2014-05-12 14:55                           ` Tomi Valkeinen
2014-05-12 15:51                             ` Tony Lindgren
2014-05-13 10:51                               ` Tomi Valkeinen
2014-05-13 11:39                                 ` Javier Martinez Canillas
2014-05-13 15:25                                   ` Tony Lindgren
2014-05-14  6:19                                     ` Tomi Valkeinen
2014-05-14 16:02                                       ` Tony Lindgren
2014-05-15  9:23                                         ` Tomi Valkeinen
2014-05-15 18:21                                           ` Tony Lindgren
2014-05-16  5:56                                             ` Tomi Valkeinen
2014-05-16 16:07                                               ` Tony Lindgren
2014-05-16 17:41                                                 ` Sebastian Reichel
2014-05-16 18:01                                                   ` Tony Lindgren
2014-05-16 21:39                                                     ` Tony Lindgren
2014-05-19  9:48                                                       ` Tomi Valkeinen
2014-05-19 15:57                                                         ` Tony Lindgren
2014-05-19 16:43                                                           ` Arnd Bergmann
2014-05-19 18:57                                                           ` Tomi Valkeinen
2014-05-19 19:51                                                             ` Tony Lindgren
2014-05-21 13:05                                                               ` Tomi Valkeinen
2014-05-21 14:24                                                                 ` Sebastian Reichel
     [not found]                                                             ` <537A540E.8070302-l0cyMroinI0@public.gmane.org>
2014-05-20  4:57                                                               ` Sebastian Reichel
2014-05-20  5:21                                                                 ` Tomi Valkeinen
     [not found]                                                     ` <20140516180154.GG22031-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-05-19  9:21                                                       ` Tomi Valkeinen
2014-05-19 16:04                                                         ` Tony Lindgren
2014-05-19 19:05                                                           ` Tomi Valkeinen
2014-05-20  5:12                                                             ` Sebastian Reichel
     [not found]                                                               ` <20140520051203.GB28812-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2014-05-20  5:48                                                                 ` Tony Lindgren
2014-05-20 21:10                                                                   ` Sebastian Reichel
2014-05-09  8:31             ` Tomi Valkeinen
2014-05-09 15:30               ` Tony Lindgren
2014-05-13 21:26                 ` Tony Lindgren
2014-05-15  8:41                   ` Tomi Valkeinen
2014-05-15 18:25                     ` Tony Lindgren
2014-05-16  5:50                       ` Tomi Valkeinen
2014-05-16 15:59                         ` Tony Lindgren
2014-05-15 13:07                   ` Tomi Valkeinen
2014-05-15 18:27                     ` Tony Lindgren
2014-04-29 23:52 ` [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp Tony Lindgren
2014-04-30  1:07   ` Joachim Eastwood
2014-04-30 17:47     ` Tony Lindgren
     [not found]       ` <20140430174751.GA12362-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-05-05 18:39         ` Tony Lindgren
2014-05-08 23:36           ` Tony Lindgren
2014-05-09  7:07             ` Tomi Valkeinen
2014-05-09 15:37               ` Tony Lindgren
2014-05-13 21:32                 ` Tony Lindgren
2014-05-15  8:57                   ` Tomi Valkeinen
2014-05-21 12:44                   ` Tomi Valkeinen
2014-05-21 14:50                     ` Tony Lindgren
2014-05-27 20:59                       ` Tony Lindgren
2014-05-27 21:14                         ` Tony Lindgren
2014-05-28  6:31                           ` Tomi Valkeinen
2014-05-28  6:34                         ` Tomi Valkeinen
     [not found] ` <1398815562-24113-1-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-05-05 18:41   ` [PATCH 0/4] OMAPDSS: Add support for panel ls037v7dw01 Tony Lindgren
2014-05-09  9:34     ` Tomi Valkeinen
2014-05-09 15:55       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398815562-24113-4-git-send-email-tony@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).