From: Philipp Zabel <p.zabel@pengutronix.de>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-kernel@vger.kernel.org,
Arnd Bergmann Arnd Bergmann <arnd@arndb.de>,
Mark Rutland <mark.rutland@arm.com>,
Roger Quadros <rogerq@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH v4 1/2] Documentation: Add GPIO reset binding to reset binding documentation
Date: Wed, 30 Apr 2014 10:54:22 +0200 [thread overview]
Message-ID: <1398848062.19894.38.camel@paszta.hi.pengutronix.de> (raw)
In-Reply-To: <20140417115820.GD4132@lukather>
Hi Maxime,
Am Donnerstag, den 17.04.2014, 13:58 +0200 schrieb Maxime Ripard:
> I still feel like we should really treat gpios like just another reset
> controller, ie. using the resets property.
I now feel like we really shouldn't. If we do anything but use the
generic gpio bindings for reset gpios, we might force every OS or
bootloader using the device tree to implement some kind of reset
controller framework, even for hardware that only has gpio resets.
> I understand that you chose this pattern to be pretty much compatible
> with what have been done so fare, bu I don't see how to fulfill that
> goal completely, since most of the devices are actually using
> reset-gpios, but some are using other names too (including
> reset-gpio).
Yes, that is a problem that applies to all gpios, not only to reset
gpios, though.
> So if we can't be fully backward compatible, I don't see the benefit
> of being inconsistent with how reset controllers are used in general,
See above.
> and more globally on how gpios are tied for regulators for example.
Reset controllers are rather more similar to gpio or interrupt
controllers. Those also have a number of entities per device node,
as opposed to regulators.
> That would also make reset-gpio a regular reset driver, instead of
> adding logic to the core itself to handle this special case.
Which is what I initially tried and moved away from.
regards
Philipp
next prev parent reply other threads:[~2014-04-30 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 8:21 [PATCH v4 1/2] Documentation: Add GPIO reset binding to reset binding documentation Philipp Zabel
2014-04-14 8:21 ` [PATCH v4 2/2] reset: Add GPIO support to reset controller framework Philipp Zabel
2014-04-14 10:57 ` One Thousand Gnomes
2014-04-15 8:35 ` Philipp Zabel
[not found] ` <1397463709-19405-1-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-04-17 11:58 ` [PATCH v4 1/2] Documentation: Add GPIO reset binding to reset binding documentation Maxime Ripard
2014-04-30 8:54 ` Philipp Zabel [this message]
[not found] ` <1398848062.19894.38.camel-+qGW7pzALmz7o/J7KWpOmN53zsg1cpMQ@public.gmane.org>
2014-04-30 18:29 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398848062.19894.38.camel@paszta.hi.pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=rogerq@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).