devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
To: kishon-l0cyMroinI0@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org
Cc: george.cherian-l0cyMroinI0@public.gmane.org,
	sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org,
	nm-l0cyMroinI0@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
Subject: [PATCH v3 1/7] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk"
Date: Mon, 5 May 2014 12:54:40 +0300	[thread overview]
Message-ID: <1399283686-6127-2-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1399283686-6127-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>

As clocks might be named differently on multiple platforms, use a generic
name in the driver and allow device tree node to specify the platform
specific clock name.

Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
---
 drivers/phy/phy-omap-usb2.c | 30 +++++++++++++++++++++++-------
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c
index a2205a8..7007c11 100644
--- a/drivers/phy/phy-omap-usb2.c
+++ b/drivers/phy/phy-omap-usb2.c
@@ -275,18 +275,34 @@ static int omap_usb2_probe(struct platform_device *pdev)
 	if (IS_ERR(phy_provider))
 		return PTR_ERR(phy_provider);
 
-	phy->wkupclk = devm_clk_get(phy->dev, "usb_phy_cm_clk32k");
+	phy->wkupclk = devm_clk_get(phy->dev, "wkupclk");
 	if (IS_ERR(phy->wkupclk)) {
-		dev_err(&pdev->dev, "unable to get usb_phy_cm_clk32k\n");
-		return PTR_ERR(phy->wkupclk);
+		dev_warn(&pdev->dev, "unable to get wkupclk, trying old name\n");
+		phy->wkupclk = devm_clk_get(phy->dev, "usb_phy_cm_clk32k");
+		if (IS_ERR(phy->wkupclk)) {
+			dev_err(&pdev->dev, "unable to get usb_phy_cm_clk32k\n");
+			return PTR_ERR(phy->wkupclk);
+		} else {
+			dev_warn(&pdev->dev,
+				 "found usb_phy_cm_clk32k, please fix DTS\n");
+		}
 	}
 	clk_prepare(phy->wkupclk);
 
-	phy->optclk = devm_clk_get(phy->dev, "usb_otg_ss_refclk960m");
-	if (IS_ERR(phy->optclk))
-		dev_vdbg(&pdev->dev, "unable to get refclk960m\n");
-	else
+	phy->optclk = devm_clk_get(phy->dev, "refclk");
+	if (IS_ERR(phy->optclk)) {
+		dev_dbg(&pdev->dev, "unable to get refclk, trying old name\n");
+		phy->optclk = devm_clk_get(phy->dev, "usb_otg_ss_refclk960m");
+		if (IS_ERR(phy->optclk)) {
+			dev_dbg(&pdev->dev,
+				"unable to get usb_otg_ss_refclk960m\n");
+		} else {
+			dev_warn(&pdev->dev,
+				 "found usb_otg_ss_refclk960m, please fix DTS\n");
+		}
+	} else {
 		clk_prepare(phy->optclk);
+	}
 
 	usb_add_phy_dev(&phy->phy);
 
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-05-05  9:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05  9:54 [PATCH v3 0/7] USB support for DRA7-evm Roger Quadros
2014-05-05  9:54 ` [PATCH v3 2/7] phy: omap-usb2: Add clock names to Documentation binding Roger Quadros
     [not found] ` <1399283686-6127-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-05  9:54   ` Roger Quadros [this message]
     [not found]     ` <1399283686-6127-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-05 18:14       ` [PATCH v3 1/7] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk" Felipe Balbi
2014-05-05  9:54   ` [PATCH v3 3/7] ARM: dts: omap4+: Add clocks to USB2 PHY node Roger Quadros
2014-05-05  9:54   ` [PATCH v3 5/7] ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss Roger Quadros
2014-06-13 19:08     ` Paul Walmsley
2014-06-18 11:10     ` Roger Quadros
2014-06-18 11:19       ` Rajendra Nayak
     [not found]         ` <53A175DC.8080709-l0cyMroinI0@public.gmane.org>
2014-06-18 11:24           ` Roger Quadros
2014-07-02 11:26         ` Roger Quadros
2014-07-03 10:42           ` Sekhar Nori
2014-05-05  9:54   ` [PATCH v3 6/7] ARM: dts: dra7: Add USB related nodes Roger Quadros
     [not found]     ` <1399283686-6127-7-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-07  8:45       ` Roger Quadros
2014-05-07 11:55       ` [PATCH v4 " Roger Quadros
2014-05-06  7:19   ` [PATCH v3 0/7] USB support for DRA7-evm Roger Quadros
2014-05-06  8:19     ` Kishon Vijay Abraham I
2014-05-05  9:54 ` [PATCH v3 4/7] ARM: dts: dra7-clock: Add "l3init_960m_gfclk" clock gate Roger Quadros
2014-05-06 10:10   ` Tero Kristo
2014-05-05  9:54 ` [PATCH v3 7/7] dts: dra7-evm: add USB support Roger Quadros
2014-05-13 17:18   ` Tony Lindgren
     [not found]     ` <20140513171802.GG16837-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-05-14  7:53       ` Roger Quadros
     [not found]   ` <1399283686-6127-8-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-14  7:58     ` [PATCH v4 " Roger Quadros
     [not found]       ` <53732215.8050608-l0cyMroinI0@public.gmane.org>
2014-05-14 21:27         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399283686-6127-2-git-send-email-rogerq@ti.com \
    --to=rogerq-l0cymroini0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=george.cherian-l0cyMroinI0@public.gmane.org \
    --cc=kishon-l0cyMroinI0@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nm-l0cyMroinI0@public.gmane.org \
    --cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).