From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: [PATCH 2/5] net: mdio-gpio: warn about missing bus alias id Date: Thu, 8 May 2014 09:37:16 +0200 Message-ID: <1399534639-4947-3-git-send-email-jhovold@gmail.com> References: <1399534639-4947-1-git-send-email-jhovold@gmail.com> Return-path: In-Reply-To: <1399534639-4947-1-git-send-email-jhovold@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: "David S. Miller" , Florian Fainelli Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Mugunthan V N , Johan Hovold List-Id: devicetree@vger.kernel.org Use a sane default bus id (rather than -ENODEV) and print a warning when the bus alias id is missing. Signed-off-by: Johan Hovold --- drivers/net/phy/mdio-gpio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c index 9c4defdec67b..5f1a2250018f 100644 --- a/drivers/net/phy/mdio-gpio.c +++ b/drivers/net/phy/mdio-gpio.c @@ -215,6 +215,10 @@ static int mdio_gpio_probe(struct platform_device *pdev) if (pdev->dev.of_node) { pdata = mdio_gpio_of_get_data(pdev); bus_id = of_alias_get_id(pdev->dev.of_node, "mdio-gpio"); + if (bus_id < 0) { + dev_warn(&pdev->dev, "failed to get alias id\n"); + bus_id = 0; + } } else { pdata = dev_get_platdata(&pdev->dev); bus_id = pdev->id; -- 1.8.3.2