From: Johan Hovold <jhovold@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>,
Johan Hovold <jhovold@gmail.com>
Subject: [PATCH RESEND 2/5] net: mdio-gpio: warn about missing bus alias id
Date: Thu, 8 May 2014 10:09:21 +0200 [thread overview]
Message-ID: <1399536564-7626-3-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <1399536564-7626-1-git-send-email-jhovold@gmail.com>
Use a sane default bus id (rather than -ENODEV) and print a warning when
the bus alias id is missing.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
drivers/net/phy/mdio-gpio.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index 9c4defdec67b..5f1a2250018f 100644
--- a/drivers/net/phy/mdio-gpio.c
+++ b/drivers/net/phy/mdio-gpio.c
@@ -215,6 +215,10 @@ static int mdio_gpio_probe(struct platform_device *pdev)
if (pdev->dev.of_node) {
pdata = mdio_gpio_of_get_data(pdev);
bus_id = of_alias_get_id(pdev->dev.of_node, "mdio-gpio");
+ if (bus_id < 0) {
+ dev_warn(&pdev->dev, "failed to get alias id\n");
+ bus_id = 0;
+ }
} else {
pdata = dev_get_platdata(&pdev->dev);
bus_id = pdev->id;
--
1.8.3.2
next prev parent reply other threads:[~2014-05-08 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 7:37 [PATCH 0/5] net: cpsw and mdio-gpio fixes for v3.15-final Johan Hovold
[not found] ` <1399534639-4947-1-git-send-email-jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-08 7:37 ` [PATCH 1/5] net: mdio-gpio: fix device-tree binding documentation Johan Hovold
2014-05-08 7:37 ` [PATCH 2/5] net: mdio-gpio: warn about missing bus alias id Johan Hovold
2014-05-08 7:37 ` [PATCH 5/5] net: cpsw: add missing of_node_put Johan Hovold
2014-05-08 8:09 ` [PATCH RESEND 0/5] net: cpsw and mdio-gpio fixes for v3.15-final Johan Hovold
2014-05-08 8:09 ` [PATCH RESEND 1/5] net: mdio-gpio: fix device-tree binding documentation Johan Hovold
2014-05-08 8:09 ` Johan Hovold [this message]
2014-05-08 8:09 ` [PATCH RESEND 3/5] Revert "net: eth: cpsw: Correctly attach to GPIO bitbang MDIO driver" Johan Hovold
[not found] ` <1399536564-7626-1-git-send-email-jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-08 8:09 ` [PATCH RESEND 4/5] net: cpsw: fix null dereference at probe Johan Hovold
2014-05-08 8:09 ` [PATCH RESEND 5/5] net: cpsw: add missing of_node_put Johan Hovold
2014-05-09 19:51 ` [PATCH RESEND 0/5] net: cpsw and mdio-gpio fixes for v3.15-final David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399536564-7626-3-git-send-email-jhovold@gmail.com \
--to=jhovold@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).