From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH 3/4] of/platform: fix device naming for non-translatable addresses Date: Thu, 08 May 2014 14:47:34 +0300 Message-ID: <1399549654.8165.1.camel@iivanov-dev> References: <1399499298-8830-1-git-send-email-robherring2@gmail.com> <1399499298-8830-4-git-send-email-robherring2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1399499298-8830-4-git-send-email-robherring2@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Grant Likely , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Josh Cartwright , Courtney Cavin , Bjorn Andersson , Frank Rowand , Rob Herring List-Id: devicetree@vger.kernel.org On Wed, 2014-05-07 at 16:48 -0500, Rob Herring wrote: > From: Rob Herring > > Using non-translatable addresses in platform device names is wrong > because they may not be globally unique. Just use the default naming with > a global index if the address cannot be translated instead. > > of_can_translate_address has the same checks as of_translate_address, so > we can remove it here as well. > > Reported-by: "Ivan T. Ivanov" > Cc: Josh Cartwright > Cc: Courtney Cavin > Cc: Bjorn Andersson > Cc: Frank Rowand > Cc: Grant Likely > Signed-off-by: Rob Herring Thanks. It works for me. Tested-by: Ivan T. Ivanov Regards.