* [PATCH/RFC] ARM: shmobile: armadillo-reference dts: Add matching LED labels
@ 2014-05-08 12:06 Geert Uytterhoeven
2014-05-13 1:31 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2014-05-08 12:06 UTC (permalink / raw)
To: linux-sh, devicetree; +Cc: Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Should the node names be changed from "led[1-4]" to "led[3-6]", too?
.../boot/dts/r8a7740-armadillo800eva-reference.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
index 486007d7ffe4..8c7255438292 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
@@ -106,15 +106,19 @@
compatible = "gpio-leds";
led1 {
gpios = <&pfc 102 GPIO_ACTIVE_HIGH>;
+ label = "LED3";
};
led2 {
gpios = <&pfc 111 GPIO_ACTIVE_HIGH>;
+ label = "LED4";
};
led3 {
gpios = <&pfc 110 GPIO_ACTIVE_HIGH>;
+ label = "LED5";
};
led4 {
gpios = <&pfc 177 GPIO_ACTIVE_HIGH>;
+ label = "LED6";
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH/RFC] ARM: shmobile: armadillo-reference dts: Add matching LED labels
2014-05-08 12:06 [PATCH/RFC] ARM: shmobile: armadillo-reference dts: Add matching LED labels Geert Uytterhoeven
@ 2014-05-13 1:31 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2014-05-13 1:31 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-sh, devicetree
On Thu, May 08, 2014 at 02:06:40PM +0200, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Should the node names be changed from "led[1-4]" to "led[3-6]", too?
Yes, I think so. At the very least that would seem to be
the way it has been done for newer renesas SoCs.
>
> .../boot/dts/r8a7740-armadillo800eva-reference.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index 486007d7ffe4..8c7255438292 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -106,15 +106,19 @@
> compatible = "gpio-leds";
> led1 {
> gpios = <&pfc 102 GPIO_ACTIVE_HIGH>;
> + label = "LED3";
> };
> led2 {
> gpios = <&pfc 111 GPIO_ACTIVE_HIGH>;
> + label = "LED4";
> };
> led3 {
> gpios = <&pfc 110 GPIO_ACTIVE_HIGH>;
> + label = "LED5";
> };
> led4 {
> gpios = <&pfc 177 GPIO_ACTIVE_HIGH>;
> + label = "LED6";
> };
> };
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-13 1:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 12:06 [PATCH/RFC] ARM: shmobile: armadillo-reference dts: Add matching LED labels Geert Uytterhoeven
2014-05-13 1:31 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).