* [PATCH] ARM: dts: am335x-bone-common: Add i2c2 definition
@ 2014-05-09 5:56 Matt Ranostay
[not found] ` <1399614983-552-1-git-send-email-mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2014-05-09 5:56 UTC (permalink / raw)
To: robh+dt, mark.rutland, linux
Cc: linux-omap, devicetree, linux-kernel, pantelis.antoniou,
matt.porter, Matt Ranostay
Add missing i2c2 bus define to access various cape and
prototype/breakout board devices.
Signed-off-by: Matt Ranostay <mranostay@gmail.com>
---
arch/arm/boot/dts/am335x-bone-common.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 2e7d932..2aedfee 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -84,6 +84,13 @@
>;
};
+ i2c2_pins: pinmux_i2c2_pins {
+ pinctrl-single,pins = <
+ 0x178 (PIN_INPUT_PULLUP | MUX_MODE3) /* i2c2_sda.uart1_ctsn */
+ 0x17c (PIN_INPUT_PULLUP | MUX_MODE3) /* i2c2_scl.uart1_rtsn */
+ >;
+ };
+
uart0_pins: pinmux_uart0_pins {
pinctrl-single,pins = <
0x170 (PIN_INPUT_PULLUP | MUX_MODE0) /* uart0_rxd.uart0_rxd */
@@ -222,6 +229,15 @@
};
+
+&i2c2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c2_pins>;
+
+ status = "okay";
+ clock-frequency = <400000>;
+};
+
/include/ "tps65217.dtsi"
&tps {
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1399614983-552-1-git-send-email-mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] ARM: dts: am335x-bone-common: Add i2c2 definition [not found] ` <1399614983-552-1-git-send-email-mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-05-09 12:57 ` Nishanth Menon [not found] ` <536CD0D1.4080903-l0cyMroinI0@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Nishanth Menon @ 2014-05-09 12:57 UTC (permalink / raw) To: Matt Ranostay Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, pantelis.antoniou-Re5JQEeQqe8AvxtiuMwx3w, matt.porter-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, linux-lFZ/pmaqli7XmaaqVzeoHQ On Fri 09 May 2014 12:56:23 AM CDT, Matt Ranostay wrote: > Add missing i2c2 bus define to access various cape and > prototype/breakout board devices. > > Signed-off-by: Matt Ranostay <mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > arch/arm/boot/dts/am335x-bone-common.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi > index 2e7d932..2aedfee 100644 > --- a/arch/arm/boot/dts/am335x-bone-common.dtsi > +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi > @@ -84,6 +84,13 @@ > >; > }; > > + i2c2_pins: pinmux_i2c2_pins { > + pinctrl-single,pins = < > + 0x178 (PIN_INPUT_PULLUP | MUX_MODE3) /* i2c2_sda.uart1_ctsn */ > + 0x17c (PIN_INPUT_PULLUP | MUX_MODE3) /* i2c2_scl.uart1_rtsn */ I dont understand the comment -> i2c2_sda is being muxed to uart1_cstsn? > + >; > + }; > + > uart0_pins: pinmux_uart0_pins { > pinctrl-single,pins = < > 0x170 (PIN_INPUT_PULLUP | MUX_MODE0) /* uart0_rxd.uart0_rxd */ > @@ -222,6 +229,15 @@ > > }; > > + > +&i2c2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c2_pins>; > + > + status = "okay"; > + clock-frequency = <400000>; How did we decide on 400KHz -> do all all i2c2 devices on ALL capes work in full speed? OR should we consider a conservative 100KHz? > +}; > + > /include/ "tps65217.dtsi" > > &tps { -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <536CD0D1.4080903-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH] ARM: dts: am335x-bone-common: Add i2c2 definition [not found] ` <536CD0D1.4080903-l0cyMroinI0@public.gmane.org> @ 2014-05-09 16:24 ` Matt Ranostay 0 siblings, 0 replies; 3+ messages in thread From: Matt Ranostay @ 2014-05-09 16:24 UTC (permalink / raw) To: Nishanth Menon Cc: Linux OMAP List, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pantelis Antoniou, Matt Porter, Rob Herring, Mark Rutland, linux-lFZ/pmaqli7XmaaqVzeoHQ On Fri, May 9, 2014 at 5:57 AM, Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> wrote: > On Fri 09 May 2014 12:56:23 AM CDT, Matt Ranostay wrote: >> Add missing i2c2 bus define to access various cape and >> prototype/breakout board devices. >> >> Signed-off-by: Matt Ranostay <mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> --- >> arch/arm/boot/dts/am335x-bone-common.dtsi | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi >> index 2e7d932..2aedfee 100644 >> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi >> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi >> @@ -84,6 +84,13 @@ >> >; >> }; >> >> + i2c2_pins: pinmux_i2c2_pins { >> + pinctrl-single,pins = < >> + 0x178 (PIN_INPUT_PULLUP | MUX_MODE3) /* i2c2_sda.uart1_ctsn */ >> + 0x17c (PIN_INPUT_PULLUP | MUX_MODE3) /* i2c2_scl.uart1_rtsn */ > > I dont understand the comment -> i2c2_sda is being muxed to uart1_cstsn? > Good catch I mixed up the ordering of the comment. >> + >; >> + }; >> + >> uart0_pins: pinmux_uart0_pins { >> pinctrl-single,pins = < >> 0x170 (PIN_INPUT_PULLUP | MUX_MODE0) /* uart0_rxd.uart0_rxd */ >> @@ -222,6 +229,15 @@ >> >> }; >> >> + >> +&i2c2 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c2_pins>; >> + >> + status = "okay"; >> + clock-frequency = <400000>; > > How did we decide on 400KHz -> do all all i2c2 devices on ALL capes > work in full speed? OR should we consider a conservative 100KHz? > Probably a better plan. Will submit v2 this weekend. >> +}; >> + >> /include/ "tps65217.dtsi" >> >> &tps { > > > -- > Regards, > Nishanth Menon > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-09 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-09 5:56 [PATCH] ARM: dts: am335x-bone-common: Add i2c2 definition Matt Ranostay
[not found] ` <1399614983-552-1-git-send-email-mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-09 12:57 ` Nishanth Menon
[not found] ` <536CD0D1.4080903-l0cyMroinI0@public.gmane.org>
2014-05-09 16:24 ` Matt Ranostay
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).