From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sriranjani P <sriranjani.p@samsung.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
lee@kernel.org, devicetree@vger.kernel.org,
alim.akhtar@samsung.com, pankaj.dubey@samsung.com,
ravi.patel@samsung.com,
Sam Protsenko <semen.protsenko@linaro.org>,
Chanho Park <chanho61.park@samsung.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC
Date: Fri, 25 Nov 2022 12:29:44 +0100 [thread overview]
Message-ID: <13a33962-ac55-e3f1-933a-a9addf9bc10d@linaro.org> (raw)
In-Reply-To: <20221125070657.28335-2-sriranjani.p@samsung.com>
On 25/11/2022 08:06, Sriranjani P wrote:
> Add compatible for Tesla SYSREG controllers found on FSD SoC.
>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
Thank you for your patch. There is something to discuss/improve.
> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 4e4baf53796d..8c3334999bec 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -69,6 +69,7 @@ properties:
> - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> + - tesla,fsd-sysreg
I think we made mistake starting from 5433. Before (Exynos3/4/5) there
was only one block called actually SYSREG. For example on Exynos5433 we
have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we
should have dedicated compatibles. The same for Tesla - please provide
dedicated compatibles per each block.
I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-25 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221125070706epcas5p4a0a136ac916f69381817197c88ad9ad8@epcas5p4.samsung.com>
2022-11-25 7:06 ` [PATCH v2 0/2] arm64: dts: Add SYSREG nodes for FSD SoC Sriranjani P
[not found] ` <CGME20221125070709epcas5p329c4a6d9caf4e9903b60f2e6624fb7b3@epcas5p3.samsung.com>
2022-11-25 7:06 ` [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on " Sriranjani P
2022-11-25 11:29 ` Krzysztof Kozlowski [this message]
2022-11-25 11:39 ` Krzysztof Kozlowski
2022-11-25 12:04 ` Sriranjani P
[not found] ` <CGME20221125070713epcas5p1cd9041af82e153cd2dc88ee18e041af9@epcas5p1.samsung.com>
2022-11-25 7:06 ` [PATCH v2 2/2] arm64: dts: fsd: add sysreg device node Sriranjani P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a33962-ac55-e3f1-933a-a9addf9bc10d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=ravi.patel@samsung.com \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sriranjani.p@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).