From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51BAEC4332F for ; Fri, 25 Nov 2022 11:29:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbiKYL3t (ORCPT ); Fri, 25 Nov 2022 06:29:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbiKYL3s (ORCPT ); Fri, 25 Nov 2022 06:29:48 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B91C86555 for ; Fri, 25 Nov 2022 03:29:47 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id j16so6405689lfe.12 for ; Fri, 25 Nov 2022 03:29:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AlAaAFE6C5OWWwdg+ZapGy1tLZGrCpnjydf36VbXlug=; b=jJUw+czORzXYz3tJ1rpIjyElMLsUPzx4CSNPXLW8GuItlyqJ8fVyezeHlThWJVHzeu fY7YqvzVtEkAU5AQ6AadoxXStN8VpZFAxItzbGyA8r108llFZBvtMGMaYz00GlINkSj3 VgYczWIw+IN1zCqdqycVZYQ1JNzI5SQKLJ/q6pJ8jE7eN59YEQnnzVd6vXesp00DUdLa AG5oxd+ESLI8O37/AmIZy28pPIB9y3EQjlR9ih1v4aloaOWiLVX9/ZsMf/FrAs28dOoX PHsfupgpi/BJE8bmB/iKwvvonYTGlOdEOzqiaCfz92Wz72TTYxlEY4POqPTJjXAkTv0j oNbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AlAaAFE6C5OWWwdg+ZapGy1tLZGrCpnjydf36VbXlug=; b=bOmVQpxI1Lb0ammcmKAQmcz9iUzaHocZRGcs4RHfA0c1rHK1IHSCa/Mt0C2kjb7dRu 8kO+l3V7yR55r1hPB+H4qecFO73YRaiYTW9qnJlB1DEAxrzhWYcFaBSf6dL0VMAylFau aQbwVYNuUWlpkkR5Hc1kPJWlSYfbjpmu33Nk8lFQ2rz23+Y4TMq/c35qUDXkxWdlJwik r6LOzo7Pf2dKAkgYLc/spWSyERe1FMUQ9BzhA9h+SEqwokxDDNMdmNVepiyQ/Mw776WP JRuE9bQ9PDXkchXeLT/OEr8E8IGRx7OMoayD4U4BCqi1nKBMJPrf7xpF4M1uQjvSXLma WeAQ== X-Gm-Message-State: ANoB5pm+/uXC5PFeU+iYnb4swuz2X4WRNIV+mtwdamNLsjfq9LsTsCJX unUpMHXyAYOY/KRUfrBHQLVmng== X-Google-Smtp-Source: AA0mqf6d9rfUIFY8b9xP3QC9gltABhmbCQF9thPu9QZ9Tr2WJgaf/kvsMW/2fAf+e26rRNFwZR5QaQ== X-Received: by 2002:a05:6512:2385:b0:4ab:13d7:5751 with SMTP id c5-20020a056512238500b004ab13d75751mr12849274lfv.631.1669375786097; Fri, 25 Nov 2022 03:29:46 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id b13-20020a2e894d000000b0026a92616cd2sm342500ljk.35.2022.11.25.03.29.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 03:29:45 -0800 (PST) Message-ID: <13a33962-ac55-e3f1-933a-a9addf9bc10d@linaro.org> Date: Fri, 25 Nov 2022 12:29:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC Content-Language: en-US To: Sriranjani P , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, devicetree@vger.kernel.org, alim.akhtar@samsung.com, pankaj.dubey@samsung.com, ravi.patel@samsung.com, Sam Protsenko , Chanho Park Cc: linux-kernel@vger.kernel.org References: <20221125070657.28335-1-sriranjani.p@samsung.com> <20221125070657.28335-2-sriranjani.p@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221125070657.28335-2-sriranjani.p@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/11/2022 08:06, Sriranjani P wrote: > Add compatible for Tesla SYSREG controllers found on FSD SoC. > > Signed-off-by: Sriranjani P > --- Thank you for your patch. There is something to discuss/improve. > Documentation/devicetree/bindings/mfd/syscon.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 4e4baf53796d..8c3334999bec 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -69,6 +69,7 @@ properties: > - samsung,exynos5433-sysreg > - samsung,exynos850-sysreg > - samsung,exynosautov9-sysreg > + - tesla,fsd-sysreg I think we made mistake starting from 5433. Before (Exynos3/4/5) there was only one block called actually SYSREG. For example on Exynos5433 we have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we should have dedicated compatibles. The same for Tesla - please provide dedicated compatibles per each block. I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9. Best regards, Krzysztof