From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0117FC433EF for ; Thu, 14 Apr 2022 07:46:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236904AbiDNHtP (ORCPT ); Thu, 14 Apr 2022 03:49:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241393AbiDNHsQ (ORCPT ); Thu, 14 Apr 2022 03:48:16 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 401133C4B5 for ; Thu, 14 Apr 2022 00:45:14 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id b21so7650820lfb.5 for ; Thu, 14 Apr 2022 00:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=VsJZVv9Fp+w5mZRNrHqB2RrnmbQjqZaqJf7SJY1IHwU=; b=bNKLdmwWS2mP4BOZRWUzvsAhXX3XkrXP86Tl4m8VpVW/RIhT56+TknjVkqAbPtHSQp gE9jXJdg+iruufoXKRU9wqoSbvso/HqEMBJnnS66KQjTb+eOE2Qi1HvgmxFRnlaqEUjL ppRzQQFMWrzByuekrk9Q30mlXm1OFt8ZADqsoFqDtrV6IkQQPMN5i+4jjPn1kWZNw/8k Njm8W532m5SvrVtjcYjswpb6jhQ2hdIlPx2K1vgV57JjtdMuul8JM2EefmoWBH3BmIoi NhAl83pFCAyM7UN9VV30XYI8Cijl9rnxr5KMxMLHrZ1TVHYKunws8D7eqEIzcpwICdo5 yChQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VsJZVv9Fp+w5mZRNrHqB2RrnmbQjqZaqJf7SJY1IHwU=; b=GugciW8SaFEOA6L4w1TSakdWVA0eU77H8Dq445z3gH4wEouOfzkcKpK77QgpzD2Lnz du9iiK508St3vk7oBvVwEPnNckrjE23X+GgQ5g+pfWP37cByMpVmOvG3piBug59QYhkq VRGxg7hie1gr+DNzpX3Ylos+xf73Jms4jVWXtYBzlydrqVuW8k338KKAXdRD1yJh5T05 nQ/vvuaOUyotHKWeeRDUkD1X1iiEoqyTLFterEzH56JZc2gNxibWqtFHaPtrBinLStE0 Kd8VRAA+2EF66Jp75LgROLakbXdcYneFot5wGA7cgjkQTJV6R7aIt1wc1Bsx+AKMF0Z+ gpBw== X-Gm-Message-State: AOAM530aBn9BJfSqFK4OLkjDSt74R2fe1VtVfnoJCKot1iK8hTBisA3e ViIoAzcBKTVdy+3UNMvHfJsMrw== X-Google-Smtp-Source: ABdhPJx1gONvZ7scsNJIkPnaxXsh8o2ETyU9I4MImuFKUDZqaP1VsA9C1q+oK3TVcrt5iN5JC13pfw== X-Received: by 2002:a05:6512:2829:b0:46d:2b1:e85d with SMTP id cf41-20020a056512282900b0046d02b1e85dmr1093350lfb.303.1649922312456; Thu, 14 Apr 2022 00:45:12 -0700 (PDT) Received: from [192.168.1.102] (88-113-46-102.elisa-laajakaista.fi. [88.113.46.102]) by smtp.gmail.com with ESMTPSA id p20-20020a056512329400b0046ba6832cf6sm152797lfe.155.2022.04.14.00.45.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 00:45:12 -0700 (PDT) Message-ID: <13ad033e-cd5d-3a8c-b036-50a3ac4245c0@linaro.org> Date: Thu, 14 Apr 2022 10:45:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: sm8250: camss: Add CAMSS block definition Content-Language: en-US To: Bryan O'Donoghue , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: dmitry.baryshkov@linaro.org, jonathan@marek.ca, hfink@snap.com, jgrahsl@snap.com References: <20220413231736.991368-1-bryan.odonoghue@linaro.org> <20220413231736.991368-3-bryan.odonoghue@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20220413231736.991368-3-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bryan, On 4/14/22 02:17, Bryan O'Donoghue wrote: > Adds a CAMSS definition block. > > Co-developed-by: Julian Grahsl > Signed-off-by: Julian Grahsl > Signed-off-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 153 +++++++++++++++++++++++++++ > 1 file changed, 153 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 906bc8ed25b7..c69a8a88657a 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -3150,6 +3150,159 @@ videocc: clock-controller@abf0000 { > #power-domain-cells = <1>; > }; > > + camss: camss@ac6a000 { > + compatible = "qcom,sm8250-camss"; > + status = "disabled"; > + > + reg = <0 0xac6a000 0 0x2000>, > + <0 0xac6c000 0 0x2000>, > + <0 0xac6e000 0 0x1000>, > + <0 0xac70000 0 0x1000>, > + <0 0xac72000 0 0x1000>, > + <0 0xac74000 0 0x1000>, > + <0 0xacb4000 0 0xd000>, > + <0 0xacc3000 0 0xd000>, > + <0 0xacd9000 0 0x2200>, > + <0 0xacdb200 0 0x2200>; > + reg-names = "csiphy0", > + "csiphy1", > + "csiphy2", > + "csiphy3", > + "csiphy4", > + "csiphy5", > + "vfe0", > + "vfe1", > + "vfe_lite0", > + "vfe_lite1"; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "csiphy0", > + "csiphy1", > + "csiphy2", > + "csiphy3", > + "csiphy4", > + "csiphy5", > + "csid0", > + "csid1", > + "csid2", > + "csid3", > + "vfe0", > + "vfe1", > + "vfe_lite0", > + "vfe_lite1"; > + > + power-domains = <&camcc IFE_0_GDSC>, > + <&camcc IFE_1_GDSC>, > + <&camcc TITAN_TOP_GDSC>; > + do you need to add 'power-domain-names' property here as well? > + clocks = <&gcc GCC_CAMERA_AHB_CLK>, > + <&gcc GCC_CAMERA_HF_AXI_CLK>, > + <&gcc GCC_CAMERA_SF_AXI_CLK>, > + <&camcc CAM_CC_CAMNOC_AXI_CLK>, > + <&camcc CAM_CC_CAMNOC_AXI_CLK_SRC>, > + <&camcc CAM_CC_CORE_AHB_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>, > + <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY1_CLK>, > + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY3_CLK>, > + <&camcc CAM_CC_CSI3PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY4_CLK>, > + <&camcc CAM_CC_CSI4PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY5_CLK>, > + <&camcc CAM_CC_CSI5PHYTIMER_CLK>, > + <&camcc CAM_CC_SLOW_AHB_CLK_SRC>, > + <&camcc CAM_CC_IFE_0_AHB_CLK>, > + <&camcc CAM_CC_IFE_0_AXI_CLK>, > + <&camcc CAM_CC_IFE_0_CLK>, > + <&camcc CAM_CC_IFE_0_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_0_CSID_CLK>, > + <&camcc CAM_CC_IFE_0_AREG_CLK>, > + <&camcc CAM_CC_IFE_1_AHB_CLK>, > + <&camcc CAM_CC_IFE_1_AXI_CLK>, > + <&camcc CAM_CC_IFE_1_CLK>, > + <&camcc CAM_CC_IFE_1_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_1_CSID_CLK>, > + <&camcc CAM_CC_IFE_1_AREG_CLK>, > + <&camcc CAM_CC_IFE_LITE_AHB_CLK>, > + <&camcc CAM_CC_IFE_LITE_AXI_CLK>, > + <&camcc CAM_CC_IFE_LITE_CLK>, > + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_LITE_CSID_CLK>; > + > + clock-names = "cam_ahb_clk", > + "cam_hf_axi", > + "cam_sf_axi", > + "camnoc_axi", > + "camnoc_axi_src", > + "core_ahb", > + "cpas_ahb", > + "csiphy0", > + "csiphy0_timer", > + "csiphy1", > + "csiphy1_timer", > + "csiphy2", > + "csiphy2_timer", > + "csiphy3", > + "csiphy3_timer", > + "csiphy4", > + "csiphy4_timer", > + "csiphy5", > + "csiphy5_timer", > + "slow_ahb_src", > + "vfe0_ahb", > + "vfe0_axi", > + "vfe0", > + "vfe0_cphy_rx", > + "vfe0_csid", > + "vfe0_areg", > + "vfe1_ahb", > + "vfe1_axi", > + "vfe1", > + "vfe1_cphy_rx", > + "vfe1_csid", > + "vfe1_areg", > + "vfe_lite_ahb", > + "vfe_lite_axi", > + "vfe_lite", > + "vfe_lite_cphy_rx", > + "vfe_lite_csid"; > + > + iommus = <&apps_smmu 0x800 0x400>, > + <&apps_smmu 0x801 0x400>, > + <&apps_smmu 0x840 0x400>, > + <&apps_smmu 0x841 0x400>, > + <&apps_smmu 0xc00 0x400>, > + <&apps_smmu 0xc01 0x400>, > + <&apps_smmu 0xc40 0x400>, > + <&apps_smmu 0xc41 0x400>; > + > + interconnects = <&gem_noc MASTER_AMPSS_M0 &config_noc SLAVE_CAMERA_CFG>, > + <&mmss_noc MASTER_CAMNOC_HF &mc_virt SLAVE_EBI_CH0>, > + <&mmss_noc MASTER_CAMNOC_SF &mc_virt SLAVE_EBI_CH0>, > + <&mmss_noc MASTER_CAMNOC_ICP &mc_virt SLAVE_EBI_CH0>; Recently there was a discussion on the list that interconnects are 2-cells, if so, the array above should be updated accordingly. > + interconnect-names = "cam_ahb", > + "cam_hf_0_mnoc", > + "cam_sf_0_mnoc", > + "cam_sf_icp_mnoc"; > + }; > + > camcc: clock-controller@ad00000 { > compatible = "qcom,sm8250-camcc"; > reg = <0 0x0ad00000 0 0x10000>; -- Best wishes, Vladimir