From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Julius Werner <jwerner@chromium.org>
Cc: Dmitry Osipenko <digetx@gmail.com>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: memory: lpddr2: Adjust revision ID property to match lpddr3
Date: Wed, 23 Feb 2022 08:17:52 +0100 [thread overview]
Message-ID: <13af6f53-2a8c-c8d5-f061-baf59b511e58@canonical.com> (raw)
In-Reply-To: <CAODwPW_JbcppFGKvrooxf25dLJuvf5iWoWim1xSXZ2wqgL1k0A@mail.gmail.com>
On 23/02/2022 03:44, Julius Werner wrote:
>>> + revision-id:
>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>> + minItems: 2
>>> + maxItems: 2
>>
>> You need maximum value under items. See:
>> Documentation/devicetree/bindings/arm/l2c2x0.yaml
>
> Sorry, can you clarify how this is supposed to be? Do you want
>
> revision-id:
> minItems: 2
> maxItems: 2
> items:
> minItems: 2
> maxItems: 2
>
> or just
>
> revision-id:
> items:
> minItems: 2
> maxItems: 2
>
> I see examples of both in the file you linked (and also examples of
> what my original patch did).
There is no example of the first case in linked file. I am not sure if
it is correct even... I did not ask about maximum number of items, but
"maximum value", so like this:
https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/arm/l2c2x0.yaml#L73
> Is there any authoritative documentation
> somewhere I can read that specifies which of those is correct? (I
> tried looking at
> https://json-schema.org/understanding-json-schema/reference/array.html#length
> but I'm not sure if that's relevant here.)
example-schema.yaml is the best, but it might not cover that part. We
need more docs, I know...
> For updating existing DTSes, do you want that in the same patch or a
> separate patch in a series?
Separate patch in this series, please.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-02-23 7:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 1:24 [PATCH v2] dt-bindings: memory: lpddr2: Adjust revision ID property to match lpddr3 Julius Werner
2022-02-19 12:49 ` Dmitry Osipenko
2022-02-19 15:41 ` Krzysztof Kozlowski
2022-02-23 2:44 ` Julius Werner
2022-02-23 7:17 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13af6f53-2a8c-c8d5-f061-baf59b511e58@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).