From: Krzysztof Kozlowski <krzk@kernel.org>
To: hrishabh.rajput@oss.qualcomm.com,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavan Kondeti <pavan.kondeti@oss.qualcomm.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v4 2/2] watchdog: Add driver for Gunyah Watchdog
Date: Fri, 31 Oct 2025 12:48:18 +0100 [thread overview]
Message-ID: <13d2963d-e931-4e51-b875-a1650b899bb7@kernel.org> (raw)
In-Reply-To: <20251031-gunyah_watchdog-v4-2-7abb1ee11315@oss.qualcomm.com>
On 31/10/2025 11:18, Hrishabh Rajput via B4 Relay wrote:
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(gunyah_wdt_pm_ops, gunyah_wdt_suspend, gunyah_wdt_resume);
> +
> +static struct platform_driver gunyah_wdt_driver = {
> + .probe = gunyah_wdt_probe,
> + .driver = {
> + .name = "gunyah-wdt",
> + .pm = pm_sleep_ptr(&gunyah_wdt_pm_ops),
> + },
> +};
> +
> +static int __init gunyah_wdt_init(void)
> +{
> + return platform_driver_register(&gunyah_wdt_driver);
> +}
> +
> +module_init(gunyah_wdt_init);
Heh, what was my last message? If I see module_init() I will NAK it.
At v3 you really ignored entire feedback and this one here continues the
pattern.
NAK, please read how Linux driver model is works.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-31 11:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 10:18 [PATCH v4 0/2] Add support for Gunyah Watchdog Hrishabh Rajput via B4 Relay
2025-10-31 10:18 ` [PATCH v4 1/2] soc: qcom: smem: Register gunyah watchdog device Hrishabh Rajput via B4 Relay
2025-10-31 14:40 ` Dmitry Baryshkov
2025-10-31 15:24 ` Guenter Roeck
2025-11-01 18:50 ` Bjorn Andersson
2025-11-03 9:53 ` Hrishabh Rajput
2025-11-04 0:38 ` Bjorn Andersson
2025-11-03 9:50 ` Hrishabh Rajput
2025-11-01 18:45 ` Bjorn Andersson
2025-11-03 10:33 ` Hrishabh Rajput
2025-11-04 1:01 ` Bjorn Andersson
2025-11-04 3:30 ` Pavan Kondeti
2025-11-04 3:52 ` Bjorn Andersson
2025-11-04 5:03 ` Pavan Kondeti
2025-11-05 12:11 ` Pavan Kondeti
2025-10-31 10:18 ` [PATCH v4 2/2] watchdog: Add driver for Gunyah Watchdog Hrishabh Rajput via B4 Relay
2025-10-31 11:48 ` Krzysztof Kozlowski [this message]
2025-10-31 12:11 ` Pavan Kondeti
2025-10-31 12:39 ` Krzysztof Kozlowski
2025-10-31 13:19 ` Pavan Kondeti
2025-10-31 14:36 ` Dmitry Baryshkov
2025-10-31 15:42 ` Guenter Roeck
2025-11-03 11:25 ` Hrishabh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13d2963d-e931-4e51-b875-a1650b899bb7@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=hrishabh.rajput@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=neil.armstrong@linaro.org \
--cc=pavan.kondeti@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox