devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes
@ 2024-06-24 21:18 Chris Packham
  2024-06-25  6:04 ` Arınç ÜNAL
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Chris Packham @ 2024-06-24 21:18 UTC (permalink / raw)
  To: andrew, f.fainelli, olteanv
  Cc: netdev, devicetree, linux-kernel, linux-arm-kernel,
	linux-mediatek, Chris Packham, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Arınç ÜNAL, Landen Chao, DENG Qingfang, Sean Wang,
	Daniel Golle

Update the mt7530 binding with some minor updates that make the document
easier to read.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---

Notes:
    I was referring to this dt binding and found a couple of places where
    the wording could be improved. I'm not exactly a techical writer but
    hopefully I've made things a bit better.
    
    Changes in v2:
    - Update title, this is not just fixing grammar
    - Add missing The instead of changing has to have

 .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml        | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
index 1c2444121e60..7e405ad96eb2 100644
--- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
@@ -22,16 +22,16 @@ description: |
 
   The MT7988 SoC comes with a built-in switch similar to MT7531 as well as four
   Gigabit Ethernet PHYs. The switch registers are directly mapped into the SoC's
-  memory map rather than using MDIO. The switch got an internally connected 10G
+  memory map rather than using MDIO. The switch has an internally connected 10G
   CPU port and 4 user ports connected to the built-in Gigabit Ethernet PHYs.
 
-  MT7530 in MT7620AN, MT7620DA, MT7620DAN and MT7620NN SoCs has got 10/100 PHYs
+  The MT7530 in MT7620AN, MT7620DA, MT7620DAN and MT7620NN SoCs has 10/100 PHYs
   and the switch registers are directly mapped into SoC's memory map rather than
   using MDIO. The DSA driver currently doesn't support MT7620 variants.
 
   There is only the standalone version of MT7531.
 
-  Port 5 on MT7530 has got various ways of configuration:
+  Port 5 on MT7530 supports various configurations:
 
     - Port 5 can be used as a CPU port.
 
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes
  2024-06-24 21:18 [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes Chris Packham
@ 2024-06-25  6:04 ` Arınç ÜNAL
  2024-06-25  7:10 ` Florian Fainelli
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Arınç ÜNAL @ 2024-06-25  6:04 UTC (permalink / raw)
  To: Chris Packham, andrew, f.fainelli, olteanv
  Cc: netdev, devicetree, linux-kernel, linux-arm-kernel,
	linux-mediatek, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, AngeloGioacchino Del Regno, Landen Chao,
	DENG Qingfang, Sean Wang, Daniel Golle

On 25/06/2024 00.18, Chris Packham wrote:
> Update the mt7530 binding with some minor updates that make the document
> easier to read.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> 
> Notes:
>      I was referring to this dt binding and found a couple of places where
>      the wording could be improved. I'm not exactly a techical writer but
>      hopefully I've made things a bit better.
>      
>      Changes in v2:
>      - Update title, this is not just fixing grammar
>      - Add missing The instead of changing has to have

Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Arınç

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes
  2024-06-24 21:18 [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes Chris Packham
  2024-06-25  6:04 ` Arınç ÜNAL
@ 2024-06-25  7:10 ` Florian Fainelli
  2024-06-25  7:15 ` Vladimir Oltean
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2024-06-25  7:10 UTC (permalink / raw)
  To: Chris Packham, andrew, olteanv
  Cc: netdev, devicetree, linux-kernel, linux-arm-kernel,
	linux-mediatek, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, AngeloGioacchino Del Regno,
	Arınç ÜNAL, Landen Chao, DENG Qingfang, Sean Wang,
	Daniel Golle



On 24/06/2024 22:18, Chris Packham wrote:
> Update the mt7530 binding with some minor updates that make the document
> easier to read.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes
  2024-06-24 21:18 [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes Chris Packham
  2024-06-25  6:04 ` Arınç ÜNAL
  2024-06-25  7:10 ` Florian Fainelli
@ 2024-06-25  7:15 ` Vladimir Oltean
  2024-06-25 16:00 ` Conor Dooley
  2024-06-26  1:00 ` patchwork-bot+netdevbpf
  4 siblings, 0 replies; 7+ messages in thread
From: Vladimir Oltean @ 2024-06-25  7:15 UTC (permalink / raw)
  To: Chris Packham
  Cc: andrew, f.fainelli, netdev, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Arınç ÜNAL, Landen Chao, DENG Qingfang, Sean Wang,
	Daniel Golle

On Tue, Jun 25, 2024 at 09:18:57AM +1200, Chris Packham wrote:
> Update the mt7530 binding with some minor updates that make the document
> easier to read.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes
  2024-06-24 21:18 [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes Chris Packham
                   ` (2 preceding siblings ...)
  2024-06-25  7:15 ` Vladimir Oltean
@ 2024-06-25 16:00 ` Conor Dooley
  2024-06-26  7:38   ` Krzysztof Kozlowski
  2024-06-26  1:00 ` patchwork-bot+netdevbpf
  4 siblings, 1 reply; 7+ messages in thread
From: Conor Dooley @ 2024-06-25 16:00 UTC (permalink / raw)
  To: Chris Packham
  Cc: andrew, f.fainelli, olteanv, netdev, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Arınç ÜNAL, Landen Chao, DENG Qingfang, Sean Wang,
	Daniel Golle

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

On Tue, Jun 25, 2024 at 09:18:57AM +1200, Chris Packham wrote:
> Update the mt7530 binding with some minor updates that make the document
> easier to read.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> 
> Notes:
>     I was referring to this dt binding and found a couple of places where
>     the wording could be improved. I'm not exactly a techical writer but
>     hopefully I've made things a bit better.
>     
>     Changes in v2:
>     - Update title, this is not just fixing grammar
>     - Add missing The instead of changing has to have
> 

I don't really want to ack this, a 4th ack for some wording that has
no impact on the binding itself just seems so utterly silly to me...
Instead I've spent more time writing how silly I think it is than
hitting the ack macro would take :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes
  2024-06-24 21:18 [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes Chris Packham
                   ` (3 preceding siblings ...)
  2024-06-25 16:00 ` Conor Dooley
@ 2024-06-26  1:00 ` patchwork-bot+netdevbpf
  4 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-26  1:00 UTC (permalink / raw)
  To: Chris Packham
  Cc: andrew, f.fainelli, olteanv, netdev, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, davem, edumazet, kuba, pabeni,
	robh, krzk+dt, conor+dt, matthias.bgg, angelogioacchino.delregno,
	arinc.unal, Landen.Chao, dqfext, sean.wang, daniel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 25 Jun 2024 09:18:57 +1200 you wrote:
> Update the mt7530 binding with some minor updates that make the document
> easier to read.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> 
> Notes:
>     I was referring to this dt binding and found a couple of places where
>     the wording could be improved. I'm not exactly a techical writer but
>     hopefully I've made things a bit better.
> 
> [...]

Here is the summary with links:
  - [v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes
    https://git.kernel.org/netdev/net-next/c/c0c68e4d52ed

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes
  2024-06-25 16:00 ` Conor Dooley
@ 2024-06-26  7:38   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-26  7:38 UTC (permalink / raw)
  To: Conor Dooley, Chris Packham
  Cc: andrew, f.fainelli, olteanv, netdev, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Arınç ÜNAL, Landen Chao, DENG Qingfang, Sean Wang,
	Daniel Golle

On 25/06/2024 18:00, Conor Dooley wrote:
> On Tue, Jun 25, 2024 at 09:18:57AM +1200, Chris Packham wrote:
>> Update the mt7530 binding with some minor updates that make the document
>> easier to read.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> ---
>>
>> Notes:
>>     I was referring to this dt binding and found a couple of places where
>>     the wording could be improved. I'm not exactly a techical writer but
>>     hopefully I've made things a bit better.
>>     
>>     Changes in v2:
>>     - Update title, this is not just fixing grammar
>>     - Add missing The instead of changing has to have
>>
> 
> I don't really want to ack this, a 4th ack for some wording that has
> no impact on the binding itself just seems so utterly silly to me...
> Instead I've spent more time writing how silly I think it is than
> hitting the ack macro would take :)

But look how many reviews/acks it got :). If you acked this, the patch
would have like 4 tags!

If only complex patches get so much attention... :)

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-06-26  7:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24 21:18 [PATCH v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes Chris Packham
2024-06-25  6:04 ` Arınç ÜNAL
2024-06-25  7:10 ` Florian Fainelli
2024-06-25  7:15 ` Vladimir Oltean
2024-06-25 16:00 ` Conor Dooley
2024-06-26  7:38   ` Krzysztof Kozlowski
2024-06-26  1:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).