From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C85627446 for ; Tue, 18 Jun 2024 14:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718719941; cv=none; b=QfDhdi1wnrPaubfnu3d3F5wMsN7IvG7FUhaSu5GVylYRY6+T1nYIyYG0La5y/2ogMoO48OX36SSLCargb84ETAdlnU91EXfYZHqo+JGdsXWgC1ViA+kkavkW0DrD/fSAcq8CXGtIhJQORPWbp1zlUJYq0kfhDQrHPzQVEAYtR9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718719941; c=relaxed/simple; bh=0av22ofhvv+G1ykCXRTuar9N3ZcJAK8et2AWxSzeNng=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cWspS634akpzI6+Nqs7cZaGZbkl0aPMGEFmT2q9zZ3xbEDiZmawULXD2eMb+7KRsVSskcZPXINJxRELxIB2sPGVjY4y3iMn9OHvD1IPpVcSXrHD+ryb7NgQ74ev65arU3Zx6oT3YY0X09e+EGHQAyLATdIthDnKmtIm/lLk9uW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zHcLB3wX; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zHcLB3wX" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-52cc1528c83so1225013e87.2 for ; Tue, 18 Jun 2024 07:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718719936; x=1719324736; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z6Y4EgoXPRwJTHBawpiMcURy3sFFDfTP4JTr3Ev81mc=; b=zHcLB3wXjK+ILG4tqLn10gDyPTobyjq3vbYbYoJpgiFaaLLSPrjSNPkr+J70bNvIPB c9IDDMsYOyvHsHJP1XW99NAA+W67toVRsAQOZ4RpyUveH3Pubmya05ciSRISXpOcvFYR ZMffKD3/nJIg+chWgC4KCFvS2/n8z4eWoIT3LWgKxyNSoyf1qnGKQQC2gCvBdf5rW09t Y8irguPBPNq8aNomobzsz4en2p1fECywlfqcdcwGSqfqyesVYK0uv1ibcpc/CvIVRTeu EqB+wYT8DMioCoTch5Hn8LX2uxRkWu8hhztrClpnu0GMlRsekb7pUTC3+5mDmcnFYnmT dLRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718719936; x=1719324736; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z6Y4EgoXPRwJTHBawpiMcURy3sFFDfTP4JTr3Ev81mc=; b=p45hBq9/8/3iiSZ6KLj+70ANOhBoQfPPq9xMFSw4v1QiRDHL+aMSl70t9LGvko44IF BxxVet5d1K+etqSe6jHAOt+DzYuCIYnqMtVcmQ6t4jr4LZtvno6PPhRcPX26Y3FqP3vL o6ow7IQ30Ee9vGjVpttPStfTsDHaM/w6Owdif/2LDoBNTtdr1EACwT9uNnIo+jgIFSyY mYN9ZSHRm7j7HXtdc9mmnXDczegjfQ/lXa1BWD6R9WzcXLwehltiMmD3SJ5o06T/pW9P EDZ6bHXWz59EcDC7VPJ1dxa9vUCCHIaAoDggmyynE0iYUHjJo0/SGmbR6kDLGy/WLort jJbg== X-Forwarded-Encrypted: i=1; AJvYcCXK2KCKEi0riWo6hvM0zzHFCWtNWTHMrvG350NoiGFMmzPUQi9HCtJzrDYOQgkyuhfgsBwqWRQg2hkzOPLx4phNAzLDzJZeQFgEPQ== X-Gm-Message-State: AOJu0YzOaa6QA2c4sfDrBkDQzkb4BZK1yi8dMHYJ7NtkLpVnGdqWgfHT MdZJI04btFmbmbKE/EqAxhCCsLVcimivvITC45winBUkIMYf8s0wENZ3+wa4vpk= X-Google-Smtp-Source: AGHT+IGZaIibqfCcQvl/1r3MYhEg7Ikhi/ZBC3FSzVQkmqP3CbCr8ETdFAVMl4V1LEjW+9OKcHaQjQ== X-Received: by 2002:a05:6512:15a:b0:52c:958a:4afa with SMTP id 2adb3069b0e04-52ca6e65889mr7126633e87.23.1718719936329; Tue, 18 Jun 2024 07:12:16 -0700 (PDT) Received: from ?IPV6:2a00:f41:9028:9df3:4fb7:492b:2c94:7283? ([2a00:f41:9028:9df3:4fb7:492b:2c94:7283]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ca2888658sm1508463e87.298.2024.06.18.07.12.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jun 2024 07:12:15 -0700 (PDT) Message-ID: <13fea5c0-5906-4075-b734-52649e35eb69@linaro.org> Date: Tue, 18 Jun 2024 16:12:08 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 23/23] arm64: dts: qcom: starqltechn: add new features To: Dzmitry Sankouski , Sebastian Reichel , Bjorn Andersson , Michael Turquette , Stephen Boyd , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Dmitry Torokhov , Pavel Machek , Liam Girdwood , Mark Brown , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Krzysztof Kozlowski , Chanwoo Choi , phone-devel@vger.kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20240618-starqltechn_integration_upstream-v3-0-e3f6662017ac@gmail.com> <20240618-starqltechn_integration_upstream-v3-23-e3f6662017ac@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240618-starqltechn_integration_upstream-v3-23-e3f6662017ac@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/18/24 15:59, Dzmitry Sankouski wrote: > Add support for new features: > - sound (headphones and mics only) > - gpu > - panel > - buttons > - MAX77705 MFD: >    - charger >    - fuelgauge >    - haptic >    - led > > Signed-off-by: Dzmitry Sankouski > --- Please split this up > .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 593 ++++++++++++++++++++- > 1 file changed, 592 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > index bad154b1e894..28a5210e22fb 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > @@ -7,15 +7,40 @@ > > /dts-v1/; > > +#include > #include > #include > +#include > +#include > + > #include "sdm845.dtsi" > +#include "pm8998.dtsi" > +#include "sdm845-wcd9340.dtsi" > + > +/delete-node/ &rmtfs_mem; > +/delete-node/ &adsp_mem; > +/delete-node/ &slpi_mem; > +/delete-node/ &spss_mem; > > / { > chassis-type = "handset"; > model = "Samsung Galaxy S9 SM-G9600"; > compatible = "samsung,starqltechn", "qcom,sdm845"; > > + aliases { > + serial0 = &uart9; > + }; > + > + battery: battery { > + compatible = "simple-battery"; > + constant-charge-current-max-microamp = <2150000>; > + charge-full-design-microamp-hours = <3000000>; > + > + over-voltage-threshold-microvolt = <4500000>; > + voltage-min-design-microvolt = <3400000>; > + voltage-max-design-microvolt = <4350000>; > + }; > + > chosen { > #address-cells = <2>; > #size-cells = <2>; > @@ -59,9 +84,199 @@ memory@a1300000 { > ftrace-size = <0x40000>; > pmsg-size = <0x40000>; > }; > + > + /* The rmtfs_mem needs to be guarded due to "XPU limitations" > + * it is otherwise possible for an allocation adjacent to the > + * rmtfs_mem region to trigger an XPU violation, causing a crash. > + */ > + rmtfs_lower_guard: memory@fde00000 { > + no-map; > + reg = <0 0xfde00000 0 0x1000>; > + }; qcom,use-guard-pages instead > + > + rmtfs_mem: rmtfs-mem@fde01000 { > + compatible = "qcom,rmtfs-mem"; > + reg = <0 0xfde01000 0 0x200000>; > + no-map; > + > + qcom,client-id = <1>; > + qcom,vmid = <15>; QCOM_SCM_VMID_MSS_MSA [...] > + /* > + * It seems like reserving the old rmtfs_mem region is also needed to prevent > + * random crashes which are most likely modem related, more testing needed. > + */ > + removed_region: removed-region@88f00000 { > + no-map; > + reg = <0 0x88f00000 0 0x1c00000>; Please keep no-map below reg for consistency [...] > + > +&gmu { > + status = "okay"; > +}; Drop this and remove the disablement in 845.dtsi, gmu is only probed when GPU is [...] > gpio-reserved-ranges = <0 4>, <27 4>, <81 4>, <85 4>; Do you know what these are for? Konrad