[PATCH v4 0/5] ARM: dts: enable hdmi for exynos5 based peach and snow boards

[PATCH v4 0/5] ARM: dts: enable hdmi for exynos5 based peach and snow boards

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable hdmi for exynos5250 based snow board, exynos5420
based peach pit board and 5800 based peach-pi board.
V4:
1) Removed hdmi_hpd_irq pin from peach-pi board as it already
present in exynos5420-pinctrl.dtsi.

V3:
1) Re-spin on dependent patches.
2) Added patch to enable hdmi for Peach-pi board.

V2:
1) Re-spin on dependent patches.
2) Added patch to remove chip specific hdmi hpd gpio from
board file top SoC file.

This series is based on Kukjin Kims, for-next branch.

It is dependent on

1) Sachin's patch: "ARM: dts: exynos5250-snow: add tps65090 power regulator"
at https://patches.linaro.org/28325/ : [Reviewed-by: Doug Anderson]

All other dependent patches are already landed in maintainers
tree.



Rahul Sharma (5):
  ARM: dts: enable hdmi for exynos5250 based snow board
  ARM: dts: change to correct compatible string for exynos5420 hdmi
  ARM: dts: enable hdmi for exynos5420 based peach-pit board
  ARM: dts: remove chip specific hdmi hpd pin from board
  ARM: dts: enable hdmi for exynos5800 based peach-pi board

 arch/arm/boot/dts/exynos5250-cros-common.dtsi |    6 +++++-
 arch/arm/boot/dts/exynos5250-pinctrl.dtsi     |    7 +++++++
 arch/arm/boot/dts/exynos5250-snow.dts         |    7 +++++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts    |   19 +++++++++++++++++++
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi     |    7 +++++++
 arch/arm/boot/dts/exynos5420-smdk5420.dts     |    9 ---------
 arch/arm/boot/dts/exynos5420.dtsi             |    7 ++++++-
 arch/arm/boot/dts/exynos5800-peach-pi.dts     |   19 +++++++++++++++++++
 8 files changed, 70 insertions(+), 11 deletions(-)

-- 
1.7.9.5

[PATCH v4 1/5] ARM: dts: enable hdmi for exynos5250 based snow board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable support for HDMI for exynos5250 based Snow board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250-cros-common.dtsi |    6 +++++-
 arch/arm/boot/dts/exynos5250-pinctrl.dtsi     |    7 +++++++
 arch/arm/boot/dts/exynos5250-snow.dts         |    7 +++++++
 3 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5250-cros-common.dtsi b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
index 2c1560d..89ac90f 100644
--- a/arch/arm/boot/dts/exynos5250-cros-common.dtsi
+++ b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
@@ -240,7 +240,7 @@
 		samsung,i2c-sda-delay = <100>;
 		samsung,i2c-max-bus-freq = <378000>;
 
-		hdmiphy@38 {
+		hdmiphy: hdmiphy@38 {
 			compatible = "samsung,exynos4212-hdmiphy";
 			reg = <0x38>;
 		};
@@ -304,6 +304,10 @@
 
 	hdmi {
 		hpd-gpio = <&gpx3 7 0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&hdmi_hpd_irq>;
+		phy = <&hdmiphy>;
+		ddc = <&i2c_2>;
 	};
 
 	gpio-keys {
diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
index 9a49e68..da3ae66 100644
--- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
@@ -560,6 +560,13 @@
 			samsung,pin-pud = <0>;
 			samsung,pin-drv = <0>;
 		};
+
+		hdmi_hpd_irq: hdmi-hpd-irq {
+			samsung,pins = "gpx3-7";
+			samsung,pin-function = <0>;
+			samsung,pin-pud = <1>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	pinctrl@13400000 {
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 1ce1088..696850a 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -206,4 +206,11 @@
 			clock-frequency = <24000000>;
 		};
 	};
+
+	hdmi {
+		hdmi-en-supply = <&tps65090_fet7>;
+		vdd-supply = <&ldo8_reg>;
+		vdd_osc-supply = <&ldo10_reg>;
+		vdd_pll-supply = <&ldo8_reg>;
+	};
 };
-- 
1.7.9.5

[PATCH v4 2/5] ARM: dts: change to correct compatible string for exynos5420 hdmi

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Replace compatible string for HDMI node in Exynos5420. Since
latest restructring in Drm hdmi driver, it is agreed to use
a seperate compatible string for Exynos5420 HDMI IP siince it
uses APB mapped Phy.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index a802f74..016992c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -640,7 +640,7 @@
 	};
 
 	hdmi: hdmi@14530000 {
-		compatible = "samsung,exynos4212-hdmi";
+		compatible = "samsung,exynos5420-hdmi";
 		reg = <0x14530000 0x70000>;
 		interrupts = <0 95 0>;
 		clocks = <&clock CLK_HDMI>, <&clock CLK_SCLK_HDMI>,
-- 
1.7.9.5

[PATCH v4 3/5] ARM: dts: enable hdmi for exynos5420 based peach-pit board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable hdmi for exynos5420 based peach-pit board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   19 +++++++++++++++++++
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 +++++++
 arch/arm/boot/dts/exynos5420.dtsi          |    5 +++++
 3 files changed, 31 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index fae33dd..8248255 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -137,6 +137,25 @@
 	};
 };
 
+&i2c_2	{
+	status = "okay";
+	samsung,i2c-sda-delay = <100>;
+	samsung,i2c-max-bus-freq = <66000>;
+	samsung,i2c-slave-addr = <0x50>;
+
+	hdmiddc@50 {
+		reg = <0x50>;
+	};
+};
+
+&hdmi {
+	status = "okay";
+	hpd-gpio = <&gpx3 7 2>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&hdmi_hpd_irq>;
+	ddc = <&i2c_2>;
+};
+
 /*
  * Use longest HW watchdog in SoC (32 seconds) since the hardware
  * watchdog provides no debugging information (compared to soft/hard
diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
index ba686e4..fc17797 100644
--- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
@@ -66,6 +66,13 @@
 			samsung,pin-pud = <0>;
 			samsung,pin-drv = <0>;
 		};
+
+		hdmi_hpd_irq: hdmi-hpd-irq {
+			samsung,pins = "gpx3-7";
+			samsung,pin-function = <0>;
+			samsung,pin-pud = <1>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	pinctrl@13410000 {
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 016992c..df4422c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -648,9 +648,14 @@
 			 <&clock CLK_MOUT_HDMI>;
 		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
 			"sclk_hdmiphy", "mout_hdmi";
+		phy = <&hdmiphy>;
 		status = "disabled";
 	};
 
+	hdmiphy: hdmiphy@145D0000 {
+		reg = <0x145D0000 0x20>;
+	};
+
 	mixer: mixer@14450000 {
 		compatible = "samsung,exynos5420-mixer";
 		reg = <0x14450000 0x10000>;
-- 
1.7.9.5

[PATCH v4 4/5] ARM: dts: remove chip specific hdmi hpd pin from board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

"gpx3-7" is chip specific pin in Exynos5420 for hdmi
hotplug. This pin is moved to exynos5420-pinctrl.dts
and removed from the board file.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-smdk5420.dts |    9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 6910485..11cd9bf 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -131,15 +131,6 @@
 		};
 	};
 
-	pinctrl@13400000 {
-		hdmi_hpd_irq: hdmi-hpd-irq {
-			samsung,pins = "gpx3-7";
-			samsung,pin-function = <0>;
-			samsung,pin-pud = <1>;
-			samsung,pin-drv = <0>;
-		};
-	};
-
 	hdmi@14530000 {
 		status = "okay";
 		hpd-gpio = <&gpx3 7 0>;
-- 
1.7.9.5

[PATCH v4 5/5] ARM: dts: enable hdmi for exynos5800 based peach-pi board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable hdmi for peach-pi board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5800-peach-pi.dts |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 742655b..2a6f23b8 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -134,6 +134,25 @@
 	};
 };
 
+&i2c_2 {
+	status = "okay";
+	samsung,i2c-sda-delay = <100>;
+	samsung,i2c-max-bus-freq = <66000>;
+	samsung,i2c-slave-addr = <0x50>;
+
+	hdmiddc@50 {
+		reg = <0x50>;
+	};
+};
+
+&hdmi {
+	status = "okay";
+	hpd-gpio = <&gpx3 7 2>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&hdmi_hpd_irq>;
+	ddc = <&i2c_2>;
+};
+
 /*
  * Use longest HW watchdog in SoC (32 seconds) since the hardware
  * watchdog provides no debugging information (compared to soft/hard
-- 
1.7.9.5

Re: [PATCH v4 4/5] ARM: dts: remove chip specific hdmi hpd pin from board

[Kukjin Kim]

On 05/14/14 11:46, Rahul Sharma wrote:
> From: Rahul Sharma<Rahul.Sharma@samsung.com>
>
> "gpx3-7" is chip specific pin in Exynos5420 for hdmi
> hotplug. This pin is moved to exynos5420-pinctrl.dts
> and removed from the board file.

Rahul, you may need to put the change (moving the pin from smdk5420 
board to exynos5420-pinctrl.dts) before the patch 3/5.

- Kukjin

>
> Signed-off-by: Rahul Sharma<Rahul.Sharma@samsung.com>
> ---
>   arch/arm/boot/dts/exynos5420-smdk5420.dts |    9 ---------
>   1 file changed, 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> index 6910485..11cd9bf 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -131,15 +131,6 @@
>   		};
>   	};
>
> -	pinctrl@13400000 {
> -		hdmi_hpd_irq: hdmi-hpd-irq {
> -			samsung,pins = "gpx3-7";
> -			samsung,pin-function =<0>;
> -			samsung,pin-pud =<1>;
> -			samsung,pin-drv =<0>;
> -		};
> -	};
> -
>   	hdmi@14530000 {
>   		status = "okay";
>   		hpd-gpio =<&gpx3 7 0>;

Re: [PATCH v4 4/5] ARM: dts: remove chip specific hdmi hpd pin from board

[Rahul Sharma]

On 15 May 2014 00:15, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 05/14/14 11:46, Rahul Sharma wrote:
>>
>> From: Rahul Sharma<Rahul.Sharma@samsung.com>
>>
>> "gpx3-7" is chip specific pin in Exynos5420 for hdmi
>> hotplug. This pin is moved to exynos5420-pinctrl.dts
>> and removed from the board file.
>
>
> Rahul, you may need to put the change (moving the pin from smdk5420 board to
> exynos5420-pinctrl.dts) before the patch 3/5.
>

Hi Kukjin,

Ok. I will post with that change tomorrow.

Regards,
Rahul Sharma.

> - Kukjin
>
>
>>
>> Signed-off-by: Rahul Sharma<Rahul.Sharma@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5420-smdk5420.dts |    9 ---------
>>   1 file changed, 9 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> index 6910485..11cd9bf 100644
>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> @@ -131,15 +131,6 @@
>>                 };
>>         };
>>
>> -       pinctrl@13400000 {
>> -               hdmi_hpd_irq: hdmi-hpd-irq {
>> -                       samsung,pins = "gpx3-7";
>> -                       samsung,pin-function =<0>;
>> -                       samsung,pin-pud =<1>;
>> -                       samsung,pin-drv =<0>;
>> -               };
>> -       };
>> -
>>         hdmi@14530000 {
>>                 status = "okay";
>>                 hpd-gpio =<&gpx3 7 0>;

Re: [PATCH v4 1/5] ARM: dts: enable hdmi for exynos5250 based snow board

[Tomasz Figa]

Hi Rahul,

On 14.05.2014 04:45, Rahul Sharma wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Enable support for HDMI for exynos5250 based Snow board.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250-cros-common.dtsi |    6 +++++-
>  arch/arm/boot/dts/exynos5250-pinctrl.dtsi     |    7 +++++++
>  arch/arm/boot/dts/exynos5250-snow.dts         |    7 +++++++
>  3 files changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-cros-common.dtsi b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
> index 2c1560d..89ac90f 100644
> --- a/arch/arm/boot/dts/exynos5250-cros-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
> @@ -240,7 +240,7 @@
>  		samsung,i2c-sda-delay = <100>;
>  		samsung,i2c-max-bus-freq = <378000>;
>  
> -		hdmiphy@38 {
> +		hdmiphy: hdmiphy@38 {
>  			compatible = "samsung,exynos4212-hdmiphy";
>  			reg = <0x38>;
>  		};
> @@ -304,6 +304,10 @@
>  
>  	hdmi {
>  		hpd-gpio = <&gpx3 7 0>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&hdmi_hpd_irq>;
> +		phy = <&hdmiphy>;
> +		ddc = <&i2c_2>;
>  	};
>  
>  	gpio-keys {
> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> index 9a49e68..da3ae66 100644
> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> @@ -560,6 +560,13 @@
>  			samsung,pin-pud = <0>;
>  			samsung,pin-drv = <0>;
>  		};
> +
> +		hdmi_hpd_irq: hdmi-hpd-irq {
> +			samsung,pins = "gpx3-7";
> +			samsung,pin-function = <0>;
> +			samsung,pin-pud = <1>;
> +			samsung,pin-drv = <0>;
> +		};

Based on the fact that this is just being configured as input, I don't
think this is a generic special function, but rather a board-specific
GPIO, which should be defined in dts of respective board.

>  	};
>  
>  	pinctrl@13400000 {
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 1ce1088..696850a 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -206,4 +206,11 @@
>  			clock-frequency = <24000000>;
>  		};
>  	};
> +
> +	hdmi {
> +		hdmi-en-supply = <&tps65090_fet7>;
> +		vdd-supply = <&ldo8_reg>;
> +		vdd_osc-supply = <&ldo10_reg>;
> +		vdd_pll-supply = <&ldo8_reg>;

Hmm, those regulators don't seem to be listed in
Documentation/devicetree/bindings/video/exynos_hdmi.txt, at least in
today's linux-next. The driver seems to use them, though.

This isn't a problem with this patch, but if you're working on this,
could you also fix the documentation in separate patch?

Best regards,
Tomasz

Re: [PATCH v4 2/5] ARM: dts: change to correct compatible string for exynos5420 hdmi

[Tomasz Figa]

Hi Rahul,

On 14.05.2014 04:45, Rahul Sharma wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Replace compatible string for HDMI node in Exynos5420. Since
> latest restructring in Drm hdmi driver, it is agreed to use
> a seperate compatible string for Exynos5420 HDMI IP siince it
> uses APB mapped Phy.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index a802f74..016992c 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -640,7 +640,7 @@
>  	};
>  
>  	hdmi: hdmi@14530000 {
> -		compatible = "samsung,exynos4212-hdmi";
> +		compatible = "samsung,exynos5420-hdmi";
>  		reg = <0x14530000 0x70000>;
>  		interrupts = <0 95 0>;
>  		clocks = <&clock CLK_HDMI>, <&clock CLK_SCLK_HDMI>,
> 

Acked-by: Tomasz Figa <t.figa@samsung.com>

The compatible string doesn't seem to be documented in linux-next,
though. Are the necessary patches adding it already merged?

Best regards,
Tomasz

Re: [PATCH v4 3/5] ARM: dts: enable hdmi for exynos5420 based peach-pit board

[Tomasz Figa]

Hi Rahul,

On 14.05.2014 04:46, Rahul Sharma wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Enable hdmi for exynos5420 based peach-pit board.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   19 +++++++++++++++++++
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 +++++++
>  arch/arm/boot/dts/exynos5420.dtsi          |    5 +++++
>  3 files changed, 31 insertions(+)

[snip]

> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> index ba686e4..fc17797 100644
> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> @@ -66,6 +66,13 @@
>  			samsung,pin-pud = <0>;
>  			samsung,pin-drv = <0>;
>  		};
> +
> +		hdmi_hpd_irq: hdmi-hpd-irq {
> +			samsung,pins = "gpx3-7";
> +			samsung,pin-function = <0>;
> +			samsung,pin-pud = <1>;
> +			samsung,pin-drv = <0>;

Same comment as for patch 1/5.

> +		};
>  	};
>  
>  	pinctrl@13410000 {
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 016992c..df4422c 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -648,9 +648,14 @@
>  			 <&clock CLK_MOUT_HDMI>;
>  		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
>  			"sclk_hdmiphy", "mout_hdmi";
> +		phy = <&hdmiphy>;
>  		status = "disabled";
>  	};
>  
> +	hdmiphy: hdmiphy@145D0000 {
> +		reg = <0x145D0000 0x20>;
> +	};

Hmm, this doesn't seem like a proper device node and I don't see other
properties present in exynos5.dtsi either. Are all the necessary patches
already merged in linux-next?

Best regards,
Tomasz

Re: [PATCH v4 4/5] ARM: dts: remove chip specific hdmi hpd pin from board

[Tomasz Figa]

Hi Rahul,

On 14.05.2014 04:46, Rahul Sharma wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> "gpx3-7" is chip specific pin in Exynos5420 for hdmi
> hotplug. This pin is moved to exynos5420-pinctrl.dts
> and removed from the board file.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> index 6910485..11cd9bf 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -131,15 +131,6 @@
>  		};
>  	};
>  
> -	pinctrl@13400000 {
> -		hdmi_hpd_irq: hdmi-hpd-irq {
> -			samsung,pins = "gpx3-7";
> -			samsung,pin-function = <0>;
> -			samsung,pin-pud = <1>;
> -			samsung,pin-drv = <0>;

Again, the same comment as for patch 1/5. This pin is being configured
as input, which doesn't look like a dedicated special function pin.
Shouldn't this node rather stay here?

Best regards,
Tomasz

Re: [PATCH v4 5/5] ARM: dts: enable hdmi for exynos5800 based peach-pi board

[Tomasz Figa]

Hi Rahul,

On 14.05.2014 04:46, Rahul Sharma wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Enable hdmi for peach-pi board.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5800-peach-pi.dts |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index 742655b..2a6f23b8 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -134,6 +134,25 @@
>  	};
>  };
>  
> +&i2c_2 {
> +	status = "okay";
> +	samsung,i2c-sda-delay = <100>;
> +	samsung,i2c-max-bus-freq = <66000>;
> +	samsung,i2c-slave-addr = <0x50>;
> +
> +	hdmiddc@50 {
> +		reg = <0x50>;
> +	};
> +};
> +
> +&hdmi {
> +	status = "okay";
> +	hpd-gpio = <&gpx3 7 2>;

What is the 2 flag? I don't see any value other than 0 and 1 defined in
include/dt-bindings/gpio/gpio.h. Also it would be better to use
preprocessor macros instead of magic numbers for flags like this.

Best regards,
Tomasz

Re: [PATCH v4 5/5] ARM: dts: enable hdmi for exynos5800 based peach-pi board

[Tomasz Figa]

On 14.05.2014 21:56, Tomasz Figa wrote:
> Hi Rahul,
> 
> On 14.05.2014 04:46, Rahul Sharma wrote:
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Enable hdmi for peach-pi board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5800-peach-pi.dts |   19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> index 742655b..2a6f23b8 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -134,6 +134,25 @@
>>  	};
>>  };
>>  
>> +&i2c_2 {
>> +	status = "okay";
>> +	samsung,i2c-sda-delay = <100>;
>> +	samsung,i2c-max-bus-freq = <66000>;
>> +	samsung,i2c-slave-addr = <0x50>;
>> +
>> +	hdmiddc@50 {
>> +		reg = <0x50>;
>> +	};

Aha, also with the new Exynos HDMI bindings, I don't think the DDC
device node is necessary any longer.

Best regards,
Tomasz

Re: [PATCH v4 1/5] ARM: dts: enable hdmi for exynos5250 based snow board

[Rahul Sharma]

Tomasz,

On 15 May 2014 01:11, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Rahul,
>
> On 14.05.2014 04:45, Rahul Sharma wrote:
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Enable support for HDMI for exynos5250 based Snow board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5250-cros-common.dtsi |    6 +++++-
>>  arch/arm/boot/dts/exynos5250-pinctrl.dtsi     |    7 +++++++
>>  arch/arm/boot/dts/exynos5250-snow.dts         |    7 +++++++
>>  3 files changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-cros-common.dtsi b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>> index 2c1560d..89ac90f 100644
>> --- a/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>> @@ -240,7 +240,7 @@
>>               samsung,i2c-sda-delay = <100>;
>>               samsung,i2c-max-bus-freq = <378000>;
>>
>> -             hdmiphy@38 {
>> +             hdmiphy: hdmiphy@38 {
>>                       compatible = "samsung,exynos4212-hdmiphy";
>>                       reg = <0x38>;
>>               };
>> @@ -304,6 +304,10 @@
>>
>>       hdmi {
>>               hpd-gpio = <&gpx3 7 0>;
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&hdmi_hpd_irq>;
>> +             phy = <&hdmiphy>;
>> +             ddc = <&i2c_2>;
>>       };
>>
>>       gpio-keys {
>> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
>> index 9a49e68..da3ae66 100644
>> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
>> @@ -560,6 +560,13 @@
>>                       samsung,pin-pud = <0>;
>>                       samsung,pin-drv = <0>;
>>               };
>> +
>> +             hdmi_hpd_irq: hdmi-hpd-irq {
>> +                     samsung,pins = "gpx3-7";
>> +                     samsung,pin-function = <0>;
>> +                     samsung,pin-pud = <1>;
>> +                     samsung,pin-drv = <0>;
>> +             };
>
> Based on the fact that this is just being configured as input, I don't
> think this is a generic special function, but rather a board-specific
> GPIO, which should be defined in dts of respective board.
>

Ok.

>>       };
>>
>>       pinctrl@13400000 {
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 1ce1088..696850a 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -206,4 +206,11 @@
>>                       clock-frequency = <24000000>;
>>               };
>>       };
>> +
>> +     hdmi {
>> +             hdmi-en-supply = <&tps65090_fet7>;
>> +             vdd-supply = <&ldo8_reg>;
>> +             vdd_osc-supply = <&ldo10_reg>;
>> +             vdd_pll-supply = <&ldo8_reg>;
>
> Hmm, those regulators don't seem to be listed in
> Documentation/devicetree/bindings/video/exynos_hdmi.txt, at least in
> today's linux-next. The driver seems to use them, though.
>
> This isn't a problem with this patch, but if you're working on this,
> could you also fix the documentation in separate patch?
>

I will post another patch for documentation update.

Regards,
Rahul Sharma.

> Best regards,
> Tomasz

Re: [PATCH v4 2/5] ARM: dts: change to correct compatible string for exynos5420 hdmi

[Rahul Sharma]

Thanks Tomasz,

Patch which add this compatible in documentation is available at
http://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/log/?h=exynos-drm-next

Regards,
Rahul Sharma

On 15 May 2014 01:14, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Rahul,
>
> On 14.05.2014 04:45, Rahul Sharma wrote:
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Replace compatible string for HDMI node in Exynos5420. Since
>> latest restructring in Drm hdmi driver, it is agreed to use
>> a seperate compatible string for Exynos5420 HDMI IP siince it
>> uses APB mapped Phy.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420.dtsi |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index a802f74..016992c 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -640,7 +640,7 @@
>>       };
>>
>>       hdmi: hdmi@14530000 {
>> -             compatible = "samsung,exynos4212-hdmi";
>> +             compatible = "samsung,exynos5420-hdmi";
>>               reg = <0x14530000 0x70000>;
>>               interrupts = <0 95 0>;
>>               clocks = <&clock CLK_HDMI>, <&clock CLK_SCLK_HDMI>,
>>
>
> Acked-by: Tomasz Figa <t.figa@samsung.com>
>
> The compatible string doesn't seem to be documented in linux-next,
> though. Are the necessary patches adding it already merged?
>
> Best regards,
> Tomasz

Re: [PATCH v4 3/5] ARM: dts: enable hdmi for exynos5420 based peach-pit board

[Rahul Sharma]

On 15 May 2014 01:20, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Rahul,
>
> On 14.05.2014 04:46, Rahul Sharma wrote:
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Enable hdmi for exynos5420 based peach-pit board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   19 +++++++++++++++++++
>>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 +++++++
>>  arch/arm/boot/dts/exynos5420.dtsi          |    5 +++++
>>  3 files changed, 31 insertions(+)
>
> [snip]
>
>> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> index ba686e4..fc17797 100644
>> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> @@ -66,6 +66,13 @@
>>                       samsung,pin-pud = <0>;
>>                       samsung,pin-drv = <0>;
>>               };
>> +
>> +             hdmi_hpd_irq: hdmi-hpd-irq {
>> +                     samsung,pins = "gpx3-7";
>> +                     samsung,pin-function = <0>;
>> +                     samsung,pin-pud = <1>;
>> +                     samsung,pin-drv = <0>;
>
> Same comment as for patch 1/5.

Ok.

>
>> +             };
>>       };
>>
>>       pinctrl@13410000 {
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index 016992c..df4422c 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -648,9 +648,14 @@
>>                        <&clock CLK_MOUT_HDMI>;
>>               clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
>>                       "sclk_hdmiphy", "mout_hdmi";
>> +             phy = <&hdmiphy>;
>>               status = "disabled";
>>       };
>>
>> +     hdmiphy: hdmiphy@145D0000 {
>> +             reg = <0x145D0000 0x20>;
>> +     };
>
> Hmm, this doesn't seem like a proper device node and I don't see other
> properties present in exynos5.dtsi either. Are all the necessary patches
> already merged in linux-next?

Yea hdmiphy is not a platform driver. It is mapped in hdmi_driver. This code
is already there in driver but documentation is not updated. I can also post
documentation update patch.

Regards,
Rahul Sharma.

>
> Best regards,
> Tomasz

Re: [PATCH v4 4/5] ARM: dts: remove chip specific hdmi hpd pin from board

[Rahul Sharma]

On 15 May 2014 01:21, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Rahul,
>
> On 14.05.2014 04:46, Rahul Sharma wrote:
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> "gpx3-7" is chip specific pin in Exynos5420 for hdmi
>> hotplug. This pin is moved to exynos5420-pinctrl.dts
>> and removed from the board file.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    9 ---------
>>  1 file changed, 9 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> index 6910485..11cd9bf 100644
>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> @@ -131,15 +131,6 @@
>>               };
>>       };
>>
>> -     pinctrl@13400000 {
>> -             hdmi_hpd_irq: hdmi-hpd-irq {
>> -                     samsung,pins = "gpx3-7";
>> -                     samsung,pin-function = <0>;
>> -                     samsung,pin-pud = <1>;
>> -                     samsung,pin-drv = <0>;
>
> Again, the same comment as for patch 1/5. This pin is being configured
> as input, which doesn't look like a dedicated special function pin.
> Shouldn't this node rather stay here?
>
Yea, I will take care fo this in v5.

> Best regards,
> Tomasz

Re: [PATCH v4 5/5] ARM: dts: enable hdmi for exynos5800 based peach-pi board

[Rahul Sharma]

On 15 May 2014 01:27, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>
>
> On 14.05.2014 21:56, Tomasz Figa wrote:
>> Hi Rahul,
>>
>> On 14.05.2014 04:46, Rahul Sharma wrote:
>>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>>
>>> Enable hdmi for peach-pi board.
>>>
>>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>>> ---
>>>  arch/arm/boot/dts/exynos5800-peach-pi.dts |   19 +++++++++++++++++++
>>>  1 file changed, 19 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> index 742655b..2a6f23b8 100644
>>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> @@ -134,6 +134,25 @@
>>>      };
>>>  };
>>>
>>> +&i2c_2 {
>>> +    status = "okay";
>>> +    samsung,i2c-sda-delay = <100>;
>>> +    samsung,i2c-max-bus-freq = <66000>;
>>> +    samsung,i2c-slave-addr = <0x50>;
>>> +
>>> +    hdmiddc@50 {
>>> +            reg = <0x50>;
>>> +    };
>
> Aha, also with the new Exynos HDMI bindings, I don't think the DDC
> device node is necessary any longer.

Yea it is not necessary now. I added it to list the i2c devices
under controller node. Just for completion.

>
> Best regards,
> Tomasz