From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Claudiu Manoil <claudiu.manoil@freescale.com>,
Grant Likely <grant.likely@linaro.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Richard Cochran <richardcochran@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Aida Mynzhasova <aida.mynzhasova@skitlab.ru>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Randy Dunlap <rdunlap@infradead.org>,
open list <linux-kernel@vger.kernel.org>,
davem@davemlof.net, Vitaly Bordug <vbordug@ru.mvista.com>,
Kumar Gala <galak@codeaurora.org>,
"open list:LINUX FOR POWERPC..." <linuxppc-dev@lists.ozlabs.org>,
David S.
Subject: [PATCH net-next 4/9] net: systemport: use the new fixed PHY helpers
Date: Mon, 19 May 2014 17:56:19 -0700 [thread overview]
Message-ID: <1400547384-11363-5-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1400547384-11363-1-git-send-email-f.fainelli@gmail.com>
of_phy_connect_fixed_link() is becoming obsolete, and also required
platform code to register the fixed PHYs at the specified addresses for
those to be usable. Get rid of it and use the new of_phy_is_fixed_link()
plus of_phy_register_fixed_link() helpers to transition over the new
scheme.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 17 +++++++++++++++--
drivers/net/ethernet/broadcom/bcmsysport.h | 1 +
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index d40c5b969e9e..dc708a888f80 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -1327,8 +1327,8 @@ static int bcm_sysport_open(struct net_device *dev)
/* Read CRC forward */
priv->crc_fwd = !!(umac_readl(priv, UMAC_CMD) & CMD_CRC_FWD);
- priv->phydev = of_phy_connect_fixed_link(dev, bcm_sysport_adj_link,
- priv->phy_interface);
+ priv->phydev = of_phy_connect(dev, priv->phy_dn, bcm_sysport_adj_link,
+ 0, priv->phy_interface);
if (!priv->phydev) {
netdev_err(dev, "could not attach to PHY\n");
return -ENODEV;
@@ -1551,6 +1551,19 @@ static int bcm_sysport_probe(struct platform_device *pdev)
if (priv->phy_interface < 0)
priv->phy_interface = PHY_INTERFACE_MODE_GMII;
+ /* In the case of a fixed PHY, the DT node associated
+ * to the PHY is the Ethernet MAC DT node.
+ */
+ if (of_phy_is_fixed_link(dn)) {
+ ret = of_phy_register_fixed_link(dn);
+ if (ret) {
+ dev_err(&pdev->dev, "failed to register fixed PHY\n");
+ goto err;
+ }
+
+ priv->phy_dn = dn;
+ }
+
/* Initialize netdevice members */
macaddr = of_get_mac_address(dn);
if (!macaddr || !is_valid_ether_addr(macaddr)) {
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.h b/drivers/net/ethernet/broadcom/bcmsysport.h
index abdeb62616df..73fd04a94797 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.h
+++ b/drivers/net/ethernet/broadcom/bcmsysport.h
@@ -656,6 +656,7 @@ struct bcm_sysport_priv {
unsigned int rx_c_index;
/* PHY device */
+ struct device_node *phy_dn;
struct phy_device *phydev;
phy_interface_t phy_interface;
int old_pause;
--
1.9.1
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2014-05-20 0:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 0:56 [PATCH 0/9 net-next] net: of_phy_connect_fixed_link removal Florian Fainelli
2014-05-20 0:56 ` [PATCH net-next 1/9] Documentation: devicetree: add old and deprecated 'fixed-link' Florian Fainelli
2014-05-20 0:56 ` [PATCH net-next 2/9] Documentation: devicetree: net: refer to fixed-link.txt Florian Fainelli
2014-05-20 0:56 ` [PATCH net-next 3/9] net: bcmgenet: use the new fixed PHY helpers Florian Fainelli
2014-05-20 0:56 ` Florian Fainelli [this message]
2014-05-20 0:56 ` [PATCH net-next 5/9] fs_enet: " Florian Fainelli
2014-05-20 0:56 ` [PATCH net-next 6/9] gianfar: " Florian Fainelli
2014-05-20 0:56 ` [PATCH net-next 7/9] ucc_geth: " Florian Fainelli
2014-05-20 0:56 ` [PATCH net-next 8/9] of: mdio: remove of_phy_connect_fixed_link Florian Fainelli
2014-05-20 0:56 ` [PATCH net-next 9/9] powerpc/fsl: fsl_soc: remove 'fixed-link' parsing code Florian Fainelli
2014-05-20 16:13 ` [PATCH 0/9 net-next] net: of_phy_connect_fixed_link removal Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400547384-11363-5-git-send-email-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=aida.mynzhasova@skitlab.ru \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemlof.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).