devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jihed Chaibi <jihed.chaibi.dev@gmail.com>, linux-sound@vger.kernel.org
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, drake@endlessm.com,
	katsuhiro@katsuster.net, matteomartelli3@gmail.com,
	zhoubinbin@loongson.cn, KCHSU0@nuvoton.com,
	patches@opensource.cirrus.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH 2/3] ASoC: dt-bindings: nau8825: Document routing strings
Date: Tue, 12 Aug 2025 09:42:59 +0200	[thread overview]
Message-ID: <1400fece-db6c-45b3-831d-f653d28eb192@kernel.org> (raw)
In-Reply-To: <20250809151853.47562-3-jihed.chaibi.dev@gmail.com>

On 09/08/2025 17:18, Jihed Chaibi wrote:
> The nau8825 driver defines several DAPM widget names that are used for
> audio routing in the Device Tree. However, these strings are not
> documented in the binding file.
> 
> This forces developers to read the C source to discover the valid
> names, which can be inefficient and error-prone.

Reading snd_soc_dapm_route can be automatize/scripted, so I don't
consider it error prone or difficult, comparing to reading free form
text in any documentation.

> 
> Add a list of the input and output widget names to the binding's
> description to make it self-contained and improve the user
> experience for board bring-up.
> 
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
> ---
>  .../devicetree/bindings/sound/nuvoton,nau8825.yaml   | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8825.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8825.yaml
> index a54f194a0..cb1c82aa3 100644
> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8825.yaml
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8825.yaml
> @@ -9,6 +9,18 @@ title: NAU8825 audio CODEC
>  maintainers:
>    - John Hsu <KCHSU0@nuvoton.com>
>  
> +description: |
> +  NAU8825 audio CODEC
> +
> +  Valid routing names defined in the driver for this codec include:
Describe pins on the device or device properties instead.

Best regards,
Krzysztof

  reply	other threads:[~2025-08-12  7:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-09 15:18 [PATCH 0/3] ASoC: dt-bindings: Document routing strings for various codecs Jihed Chaibi
2025-08-09 15:18 ` [PATCH 1/3] ASoC: dt-bindings: everest,es8316: Document routing strings Jihed Chaibi
2025-08-12  7:40   ` Krzysztof Kozlowski
2025-08-12 11:05     ` Mark Brown
2025-09-02  7:57       ` Krzysztof Kozlowski
2025-08-09 15:18 ` [PATCH 2/3] ASoC: dt-bindings: nau8825: " Jihed Chaibi
2025-08-12  7:42   ` Krzysztof Kozlowski [this message]
2025-08-09 15:18 ` [PATCH 3/3] ASoC: dt-bindings: wlf,wm8960: Document routing strings (pin names) Jihed Chaibi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400fece-db6c-45b3-831d-f653d28eb192@kernel.org \
    --to=krzk@kernel.org \
    --cc=KCHSU0@nuvoton.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drake@endlessm.com \
    --cc=jihed.chaibi.dev@gmail.com \
    --cc=katsuhiro@katsuster.net \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=matteomartelli3@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=robh@kernel.org \
    --cc=shuah@kernel.org \
    --cc=zhoubinbin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).