From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, wsa@the-dreams.de,
linus.walleij@linaro.org, linux-i2c@vger.kernel.org,
grant.likely@linaro.org, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 4/9] i2c: Make I2C ID tables non-mandatory for DT'ed devices
Date: Fri, 6 Jun 2014 16:52:27 +0100 [thread overview]
Message-ID: <1402069952-28022-5-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1402069952-28022-1-git-send-email-lee.jones@linaro.org>
Currently the I2C framework insists on devices supplying an I2C ID
table. Many of the devices which do so unnecessarily adding quite a
few wasted lines to kernel code. This patch allows drivers a means
to 'not' supply the aforementioned table and match on DT match tables
instead.
Acked-by: Grant Likely <grant.likely@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/i2c/i2c-core.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 80a2f2e..3507087 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -100,7 +100,7 @@ static int i2c_device_match(struct device *dev, struct device_driver *drv)
/* Attempt an OF style match */
- if (of_driver_match_device(dev, drv))
+ if (i2c_of_match_device(drv->of_match_table, dev))
return 1;
/* Then ACPI style match */
@@ -268,7 +268,15 @@ static int i2c_device_probe(struct device *dev)
return 0;
driver = to_i2c_driver(dev->driver);
- if (!driver->probe || !driver->id_table)
+ if (!driver->probe)
+ return -EINVAL;
+
+ /*
+ * An I2C ID table is not mandatory, if and only if, a suitable Device
+ * Tree match table entry is supplied for the probing device.
+ */
+ if (!driver->id_table &&
+ !i2c_of_match_device(dev->driver->of_match_table, dev))
return -ENODEV;
if (!device_can_wakeup(&client->dev))
--
1.8.3.2
next prev parent reply other threads:[~2014-06-06 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 15:52 [PATCH 0/9] i2c: Relax mandatory I2C ID table passing (+ some creep) Lee Jones
2014-06-06 15:52 ` [PATCH 1/9] i2c: Add pointer dereference protection to i2c_match_id() Lee Jones
2014-06-06 22:59 ` Grant Likely
2014-06-06 15:52 ` [PATCH 2/9] i2c: Add the ability to match device to compatible string without an of_node Lee Jones
2014-06-06 15:52 ` [PATCH 3/9] i2c: Match using traditional OF methods, then by vendor-less compatible strings Lee Jones
[not found] ` <1402069952-28022-4-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-06 23:19 ` Grant Likely
2014-06-06 15:52 ` Lee Jones [this message]
2014-06-06 15:52 ` [PATCH 6/9] i2c: Provide a temporary .probe2() call-back type Lee Jones
[not found] ` <1402069952-28022-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-06 15:52 ` [PATCH 5/9] i2c: Export i2c_match_id() for direct use by device drivers Lee Jones
2014-06-06 15:52 ` [PATCH 7/9] of/device: Allow I2C devices to OF match without supplying an OF node Lee Jones
[not found] ` <1402069952-28022-8-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-06 23:28 ` Grant Likely
2014-06-06 15:52 ` [PATCH 8/9] mfd: 88pm860x: Move over to new I2C device .probe() call Lee Jones
2014-06-06 15:52 ` [PATCH 9/9] mfd: as3722: Rid driver of superfluous I2C device ID structure Lee Jones
2014-06-06 23:33 ` [PATCH 0/9] i2c: Relax mandatory I2C ID table passing (+ some creep) Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402069952-28022-5-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).