From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: [PATCH 7/9] of/device: Allow I2C devices to OF match without supplying an OF node
Date: Fri, 6 Jun 2014 16:52:30 +0100 [thread overview]
Message-ID: <1402069952-28022-8-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1402069952-28022-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
The I2C framework supplies a means for devices to be registered without
the requirement for platform_data, DT or ACPI. The current solution is
that every single I2C device in the kernel is forced to supply a
normally empty/sparse I2C ID table so the I2C subsystem can match to.
In an effort to rid the kernel of these tables we need to provide some
temporary work arounds until we can straighten out the blocking factors.
This change is meant to be temporary and will be stripped out once
we've converted all I2C device drivers from of_match_device() over
to the new I2C generic i2c_of_match_device().
Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
drivers/of/device.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/of/device.c b/drivers/of/device.c
index dafb973..3b1c8f9 100644
--- a/drivers/of/device.c
+++ b/drivers/of/device.c
@@ -1,6 +1,7 @@
#include <linux/string.h>
#include <linux/kernel.h>
#include <linux/of.h>
+#include <linux/i2c.h>
#include <linux/of_device.h>
#include <linux/init.h>
#include <linux/module.h>
@@ -21,9 +22,25 @@
const struct of_device_id *of_match_device(const struct of_device_id *matches,
const struct device *dev)
{
+ const struct of_device_id *match;
+
if ((!matches) || (!dev->of_node))
return NULL;
- return of_match_node(matches, dev->of_node);
+
+ match = of_match_node(matches, dev->of_node);
+ if (match)
+ return match;
+
+ /*
+ * Low impact workaround, until we can convert all I2C compatible
+ * strings over to the correctly specified <vendor>,<device> format.
+ */
+ match = i2c_of_match_device_strip_vendor(matches, (struct device *)dev);
+ if (match)
+ dev_warn(dev,
+ "WARNING: Vendor ID missing from compatible string\n");
+
+ return match;
}
EXPORT_SYMBOL(of_match_device);
--
1.8.3.2
next prev parent reply other threads:[~2014-06-06 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 15:52 [PATCH 0/9] i2c: Relax mandatory I2C ID table passing (+ some creep) Lee Jones
2014-06-06 15:52 ` [PATCH 1/9] i2c: Add pointer dereference protection to i2c_match_id() Lee Jones
2014-06-06 22:59 ` Grant Likely
2014-06-06 15:52 ` [PATCH 2/9] i2c: Add the ability to match device to compatible string without an of_node Lee Jones
2014-06-06 15:52 ` [PATCH 3/9] i2c: Match using traditional OF methods, then by vendor-less compatible strings Lee Jones
[not found] ` <1402069952-28022-4-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-06 23:19 ` Grant Likely
2014-06-06 15:52 ` [PATCH 4/9] i2c: Make I2C ID tables non-mandatory for DT'ed devices Lee Jones
[not found] ` <1402069952-28022-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-06 15:52 ` [PATCH 5/9] i2c: Export i2c_match_id() for direct use by device drivers Lee Jones
2014-06-06 15:52 ` Lee Jones [this message]
[not found] ` <1402069952-28022-8-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-06 23:28 ` [PATCH 7/9] of/device: Allow I2C devices to OF match without supplying an OF node Grant Likely
2014-06-06 15:52 ` [PATCH 6/9] i2c: Provide a temporary .probe2() call-back type Lee Jones
2014-06-06 15:52 ` [PATCH 8/9] mfd: 88pm860x: Move over to new I2C device .probe() call Lee Jones
2014-06-06 15:52 ` [PATCH 9/9] mfd: as3722: Rid driver of superfluous I2C device ID structure Lee Jones
2014-06-06 23:33 ` [PATCH 0/9] i2c: Relax mandatory I2C ID table passing (+ some creep) Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402069952-28022-8-git-send-email-lee.jones@linaro.org \
--to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).