[PATCH] Doc: mfd: as3722: Add details of optional missing property

[PATCH] Doc: mfd: as3722: Add details of optional missing property

[Laxman Dewangan]

Add details of following properties which are used on driver but
not documented on DT binding document.
- ams,enable-internal-int-pullup
- ams,enable-internal-i2c-pullup

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reported-by: Lee Jones <lee.jones@linaro.org>
---
 Documentation/devicetree/bindings/mfd/as3722.txt | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
index 8edcb9b..4f64b2a 100644
--- a/Documentation/devicetree/bindings/mfd/as3722.txt
+++ b/Documentation/devicetree/bindings/mfd/as3722.txt
@@ -13,6 +13,14 @@ Required properties:
   The second cell is the flags, encoded as the trigger masks from binding document
 	interrupts.txt, using dt-bindings/irq.
 
+Optional properties:
+--------------------
+- ams,enable-internal-int-pullup: Boolean property, to enable internal pullup on
+	interrupt pin. Missing this will disable internal pullup on INT pin.
+- ams,enable-internal-i2c-pullup: Boolean property, to enable internal pullup on
+	i2c scl/sda pins. Missing this will disable internal pullup on i2c
+	scl/sda lines.
+
 Optional submodule and their properties:
 =======================================
 
-- 
1.8.1.5

Re: [PATCH] Doc: mfd: as3722: Add details of optional missing property

[Lee Jones]

CC'ing Linus as he had an opinion.

On Mon, 09 Jun 2014, Laxman Dewangan wrote:
> Add details of following properties which are used on driver but
> not documented on DT binding document.
> - ams,enable-internal-int-pullup
> - ams,enable-internal-i2c-pullup
> 
> Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Reported-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mfd/as3722.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
> index 8edcb9b..4f64b2a 100644
> --- a/Documentation/devicetree/bindings/mfd/as3722.txt
> +++ b/Documentation/devicetree/bindings/mfd/as3722.txt
> @@ -13,6 +13,14 @@ Required properties:
>    The second cell is the flags, encoded as the trigger masks from binding document
>  	interrupts.txt, using dt-bindings/irq.
>  
> +Optional properties:
> +--------------------
> +- ams,enable-internal-int-pullup: Boolean property, to enable internal pullup on
> +	interrupt pin. Missing this will disable internal pullup on INT pin.
> +- ams,enable-internal-i2c-pullup: Boolean property, to enable internal pullup on
> +	i2c scl/sda pins. Missing this will disable internal pullup on i2c
> +	scl/sda lines.
> +
>  Optional submodule and their properties:
>  =======================================
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Doc: mfd: as3722: Add details of optional missing property

[Linus Walleij]

On Mon, Jun 16, 2014 at 11:52 AM, Lee Jones <lee.jones@linaro.org> wrote:

> CC'ing Linus as he had an opinion.
>
> On Mon, 09 Jun 2014, Laxman Dewangan wrote:
>> Add details of following properties which are used on driver but
>> not documented on DT binding document.
>> - ams,enable-internal-int-pullup
>> - ams,enable-internal-i2c-pullup
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Reported-by: Lee Jones <lee.jones@linaro.org>

I can live with this.

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH] Doc: mfd: as3722: Add details of optional missing property

[Lee Jones]

On Mon, 09 Jun 2014, Laxman Dewangan wrote:

> Add details of following properties which are used on driver but
> not documented on DT binding document.
> - ams,enable-internal-int-pullup
> - ams,enable-internal-i2c-pullup
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Reported-by: Lee Jones <lee.jones@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/as3722.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)

Applied with Linus' Ack, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog