From: Joe Perches <joe@perches.com>
To: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Randy Dunlap <rdunlap@infradead.org>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Grant Likely <grant.likely@linaro.org>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 1/3] crypto: qce: Qualcomm crypto engine driver
Date: Mon, 09 Jun 2014 09:46:49 -0700 [thread overview]
Message-ID: <1402332409.3142.2.camel@joe-AO725> (raw)
In-Reply-To: <1402315720-5042-2-git-send-email-svarbanov@mm-sol.com>
On Mon, 2014-06-09 at 15:08 +0300, Stanimir Varbanov wrote:
> The driver is separated by functional parts. The core part
> implements a platform driver probe and remove callbaks.
> The probe enables clocks, checks crypto version, initialize
> and request dma channels, create done tasklet and init
> crypto queue and finally register the algorithms into crypto
> core subsystem.
trivia:
> diff --git a/drivers/crypto/qce/dma.h b/drivers/crypto/qce/dma.h
[]
> +#define AUTH_NONCE_NUM_WORDS_SHIFT 20
> +#define AUTH_NONCE_NUM_WORDS_MASK GENMASK(22, 20);
Unnecessary semicolon and appears to be unused.
next prev parent reply other threads:[~2014-06-09 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 12:08 [PATCH v3 0/3] Add Qualcomm crypto driver Stanimir Varbanov
2014-06-09 12:08 ` [PATCH v3 1/3] crypto: qce: Qualcomm crypto engine driver Stanimir Varbanov
2014-06-09 16:46 ` Joe Perches [this message]
2014-06-10 8:34 ` Stanimir Varbanov
2014-06-09 12:08 ` [PATCH v3 2/3] crypto: qce: Build Qualcomm crypto driver Stanimir Varbanov
2014-06-09 12:08 ` [PATCH v3 3/3] ARM: DT: qcom: Add Qualcomm crypto driver binding document Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402332409.3142.2.camel@joe-AO725 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=rob.herring@calxeda.com \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).