From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH v3 1/3] crypto: qce: Qualcomm crypto engine driver
Date: Mon, 09 Jun 2014 09:46:49 -0700
Message-ID: <1402332409.3142.2.camel@joe-AO725>
References: <1402315720-5042-1-git-send-email-svarbanov@mm-sol.com>
	 <1402315720-5042-2-git-send-email-svarbanov@mm-sol.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1402315720-5042-2-git-send-email-svarbanov@mm-sol.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Rob Herring <rob.herring@calxeda.com>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Randy Dunlap <rdunlap@infradead.org>, "David S. Miller" <davem@davemloft.net>, Herbert Xu <herbert@gondor.apana.org.au>, Grant Likely <grant.likely@linaro.org>, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org
List-Id: devicetree@vger.kernel.org

On Mon, 2014-06-09 at 15:08 +0300, Stanimir Varbanov wrote:
> The driver is separated by functional parts. The core part
> implements a platform driver probe and remove callbaks.
> The probe enables clocks, checks crypto version, initialize
> and request dma channels, create done tasklet and init
> crypto queue and finally register the algorithms into crypto
> core subsystem.

trivia:

> diff --git a/drivers/crypto/qce/dma.h b/drivers/crypto/qce/dma.h
[]
> +#define AUTH_NONCE_NUM_WORDS_SHIFT	20
> +#define AUTH_NONCE_NUM_WORDS_MASK	GENMASK(22, 20);

Unnecessary semicolon and appears to be unused.